Re: [PATCH -next] powerpc/85xx: use for_each_compatible_node() macro

[Kumar Gala]

On Dec 3, 2012, at 7:36 AM, Wei Yongjun wrote:

 From: Wei Yongjun yongjun_...@trendmicro.com.cn
 
 Use for_each_compatible_node() macro instead of open coding it.
 
 Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
 ---
 arch/powerpc/platforms/85xx/mpc85xx_mds.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

applied to next

- k
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH -next] powerpc/85xx: use for_each_compatible_node() macro

[Grant Likely]

On Mon, 3 Dec 2012 08:36:03 -0500, Wei Yongjun weiyj...@gmail.com wrote:
 From: Wei Yongjun yongjun_...@trendmicro.com.cn
 
 Use for_each_compatible_node() macro instead of open coding it.
 
 Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn

Acked-by: Grant Likely grant.lik...@secretlab.ca
 ---
  arch/powerpc/platforms/85xx/mpc85xx_mds.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
 
 diff --git a/arch/powerpc/platforms/85xx/mpc85xx_mds.c 
 b/arch/powerpc/platforms/85xx/mpc85xx_mds.c
 index bd12588..a7b3621 100644
 --- a/arch/powerpc/platforms/85xx/mpc85xx_mds.c
 +++ b/arch/powerpc/platforms/85xx/mpc85xx_mds.c
 @@ -206,9 +206,7 @@ static void __init mpc85xx_mds_reset_ucc_phys(void)
   setbits8(bcsr_regs[7], BCSR7_UCC12_GETHnRST);
   clrbits8(bcsr_regs[8], BCSR8_UEM_MARVELL_RST);
  
 - for (np = NULL; (np = of_find_compatible_node(np,
 - network,
 - ucc_geth)) != NULL;) {
 + for_each_compatible_node(np, network, ucc_geth) {
   const unsigned int *prop;
   int ucc_num;
  
 

-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH -next] powerpc/85xx: use for_each_compatible_node() macro

[Wei Yongjun]

From: Wei Yongjun yongjun_...@trendmicro.com.cn

Use for_each_compatible_node() macro instead of open coding it.

Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
 arch/powerpc/platforms/85xx/mpc85xx_mds.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/powerpc/platforms/85xx/mpc85xx_mds.c 
b/arch/powerpc/platforms/85xx/mpc85xx_mds.c
index bd12588..a7b3621 100644
--- a/arch/powerpc/platforms/85xx/mpc85xx_mds.c
+++ b/arch/powerpc/platforms/85xx/mpc85xx_mds.c
@@ -206,9 +206,7 @@ static void __init mpc85xx_mds_reset_ucc_phys(void)
setbits8(bcsr_regs[7], BCSR7_UCC12_GETHnRST);
clrbits8(bcsr_regs[8], BCSR8_UEM_MARVELL_RST);
 
-   for (np = NULL; (np = of_find_compatible_node(np,
-   network,
-   ucc_geth)) != NULL;) {
+   for_each_compatible_node(np, network, ucc_geth) {
const unsigned int *prop;
int ucc_num;
 

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev