Re: [PATCH -next] powerpc64/ftrace: Drop pointless static qualifier in is_b_op()

[Naveen N. Rao]

YueHaibing wrote:

There is no need to have the 'intoffset' variable static since new value
always be assigned before use it.

Signed-off-by: YueHaibing 
---
 arch/powerpc/kernel/trace/ftrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/trace/ftrace.c 
b/arch/powerpc/kernel/trace/ftrace.c
index 4bf051d..65248d4 100644
--- a/arch/powerpc/kernel/trace/ftrace.c
+++ b/arch/powerpc/kernel/trace/ftrace.c
@@ -107,7 +107,7 @@ static int is_b_op(unsigned int op)

 static unsigned long find_bl_target(unsigned long ip, unsigned int op)
 {
-   static int offset;
+   int offset;


That seems to go all the way back to the original commit by Steven.
Good catch.
Reviewed-by: Naveen N. Rao 

- Naveen

[PATCH -next] powerpc64/ftrace: Drop pointless static qualifier in is_b_op()

[YueHaibing]

There is no need to have the 'intoffset' variable static since new value
always be assigned before use it.

Signed-off-by: YueHaibing 
---
 arch/powerpc/kernel/trace/ftrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/trace/ftrace.c 
b/arch/powerpc/kernel/trace/ftrace.c
index 4bf051d..65248d4 100644
--- a/arch/powerpc/kernel/trace/ftrace.c
+++ b/arch/powerpc/kernel/trace/ftrace.c
@@ -107,7 +107,7 @@ static int is_b_op(unsigned int op)
 
 static unsigned long find_bl_target(unsigned long ip, unsigned int op)
 {
-   static int offset;
+   int offset;
 
offset = (op & 0x03fc);
/* make it signed */