[PATCH 0/2] PowerPC: 4xx uic updates
These patches update 4xx uic code. The first one fixes a minor issue with edge-triggered interrupts, while the second one makes it use generic level and edge irq handlers. I've added irq ack'ing to the unmask callback for level-triggered interrupts, because to de-assert them we have to do 2 things is the exact order as below: 1. de-assert the external source in the ISR. 2. ack the IRQ on the UIC. So, ack'ing level interrupts before unmasking them makes possible to use generic level irq handler and it doesn't hurt, cause we can never miss a level-triggered interrupt. It always stays asserted untill the external source is removed and ack'ed on UIC. These have been tested on Sequoia PowerPC 440EPx board. Thanks, Valentine. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 0/2] PowerPC: 4xx uic updates
On Tue, 13 Nov 2007 23:15:59 +0300 Valentine Barshak [EMAIL PROTECTED] wrote: These patches update 4xx uic code. The first one fixes a minor issue with edge-triggered interrupts, while the second one makes it use generic level and edge irq handlers. I've added irq ack'ing to the unmask callback for level-triggered interrupts, because to de-assert them we have to do 2 things is the exact order as below: 1. de-assert the external source in the ISR. 2. ack the IRQ on the UIC. So, ack'ing level interrupts before unmasking them makes possible to use generic level irq handler and it doesn't hurt, cause we can never miss a level-triggered interrupt. It always stays asserted untill the external source is removed and ack'ed on UIC. These have been tested on Sequoia PowerPC 440EPx board. Is my mail server slow, or did patch 2 of 2 never make it out? josh ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 0/2] PowerPC: 4xx uic updates
On Tue, Nov 13, 2007 at 08:05:14PM -0600, Josh Boyer wrote: On Tue, 13 Nov 2007 23:15:59 +0300 Valentine Barshak [EMAIL PROTECTED] wrote: These patches update 4xx uic code. The first one fixes a minor issue with edge-triggered interrupts, while the second one makes it use generic level and edge irq handlers. I've added irq ack'ing to the unmask callback for level-triggered interrupts, because to de-assert them we have to do 2 things is the exact order as below: 1. de-assert the external source in the ISR. 2. ack the IRQ on the UIC. So, ack'ing level interrupts before unmasking them makes possible to use generic level irq handler and it doesn't hurt, cause we can never miss a level-triggered interrupt. It always stays asserted untill the external source is removed and ack'ed on UIC. These have been tested on Sequoia PowerPC 440EPx board. Is my mail server slow, or did patch 2 of 2 never make it out? It reached me eventually, but only to my ibm address, not via the list (whereas I got both copies of 0 and 1). -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 0/2] PowerPC: 4xx uic updates
On Tue, 2007-11-13 at 20:05 -0600, Josh Boyer wrote: On Tue, 13 Nov 2007 23:15:59 +0300 Valentine Barshak [EMAIL PROTECTED] wrote: These patches update 4xx uic code. The first one fixes a minor issue with edge-triggered interrupts, while the second one makes it use generic level and edge irq handlers. I've added irq ack'ing to the unmask callback for level-triggered interrupts, because to de-assert them we have to do 2 things is the exact order as below: 1. de-assert the external source in the ISR. 2. ack the IRQ on the UIC. So, ack'ing level interrupts before unmasking them makes possible to use generic level irq handler and it doesn't hurt, cause we can never miss a level-triggered interrupt. It always stays asserted untill the external source is removed and ack'ed on UIC. These have been tested on Sequoia PowerPC 440EPx board. Is my mail server slow, or did patch 2 of 2 never make it out? It never reached me neither. Ben ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
