Re: [PATCH 0/4] defconfigs: cleanup obsolete MTD configs
On Sat, 2015-01-24 at 22:54 +0200, Sam Protsenko wrote: > > That's news for me. I thought they are silently ignored. Do you have an > > example of such a warning? > > Not really. It was just assumption. It seems you are right, they are just > ignored silently. But item 2 is still relevant and it was actually confused > me when I tried to figure out MTD configuration for my platform. > Anyway, garbage should be taken out from time to time. The usual way that this gets dealt with is that arch maintainers (ir)regularly run make savedefconfig on all their defconfigs. As it happens we've done that on powerpc just recently, if you rebase onto next you should see that, so you can drop the powerpc hunks from your patches. cheers ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 0/4] defconfigs: cleanup obsolete MTD configs
On Sat, Jan 24, 2015 at 06:33:29PM +0200, Semen Protsenko wrote: > This patch series removes next obsolete MTD configs from all defconfig files: > - CONFIG_MTD_CHAR > - CONFIG_MTD_CONCAT > - CONFIG_MTD_DEBUG > - CONFIG_MTD_DEBUG_VERBOSE > - CONFIG_MTD_PARTITIONS > > All those configs were removed from drivers/mtd/Kconfig earlier, but their > usage > in defconfig files was remain unnoticed. There are at least two obvious > reasons > to get rid of those configs: > 1. Their usage may cause to build warnings > 2. Their usage may confuse someone who is grepping defconfig files to get > the clue what MTD configuration may look like. > > This series is harmless for all those defconfigs and will not break anything. FYI, there is a plan to remove arch/arm/configs/mackerel_defconfig in v3.21. > > > Semen Protsenko (4): > defconfigs: remove CONFIG_MTD_CONCAT > defconfigs: remove CONFIG_MTD_PARTITIONS > defconfigs: remove CONFIG_MTD_CHAR > defconfigs: remove CONFIG_MTD_DEBUG* > > arch/arm/configs/acs5k_defconfig |3 --- > arch/arm/configs/acs5k_tiny_defconfig |3 --- > arch/arm/configs/am200epdkit_defconfig |1 - > arch/arm/configs/assabet_defconfig |2 -- > arch/arm/configs/badge4_defconfig |3 --- > arch/arm/configs/bockw_defconfig |1 - > arch/arm/configs/cerfcube_defconfig|2 -- > arch/arm/configs/cm_x2xx_defconfig |1 - > arch/arm/configs/cm_x300_defconfig |2 -- > arch/arm/configs/cns3420vb_defconfig |2 -- > arch/arm/configs/colibri_pxa270_defconfig |2 -- > arch/arm/configs/collie_defconfig |2 -- > arch/arm/configs/corgi_defconfig |2 -- > arch/arm/configs/davinci_all_defconfig |2 -- > arch/arm/configs/em_x270_defconfig |1 - > arch/arm/configs/ezx_defconfig |1 - > arch/arm/configs/h5000_defconfig |1 - > arch/arm/configs/hackkit_defconfig |3 --- > arch/arm/configs/imote2_defconfig |1 - > arch/arm/configs/iop13xx_defconfig |1 - > arch/arm/configs/iop32x_defconfig |2 -- > arch/arm/configs/iop33x_defconfig |2 -- > arch/arm/configs/ixp4xx_defconfig |2 -- > arch/arm/configs/ks8695_defconfig |2 -- > arch/arm/configs/lart_defconfig|4 > arch/arm/configs/lpc32xx_defconfig |1 - > arch/arm/configs/lpd270_defconfig |2 -- > arch/arm/configs/lubbock_defconfig |2 -- > arch/arm/configs/mackerel_defconfig|3 --- > arch/arm/configs/magician_defconfig|2 -- > arch/arm/configs/mainstone_defconfig |2 -- > arch/arm/configs/mini2440_defconfig|3 --- > arch/arm/configs/mv78xx0_defconfig |2 -- > arch/arm/configs/neponset_defconfig|2 -- > arch/arm/configs/netx_defconfig|2 -- > arch/arm/configs/nuc910_defconfig |3 --- > arch/arm/configs/nuc950_defconfig |3 --- > arch/arm/configs/nuc960_defconfig |3 --- > arch/arm/configs/omap1_defconfig |4 > arch/arm/configs/orion5x_defconfig |1 - > arch/arm/configs/pcm027_defconfig |2 -- > arch/arm/configs/pleb_defconfig|2 -- > arch/arm/configs/pxa255-idp_defconfig |2 -- > arch/arm/configs/pxa3xx_defconfig |2 -- > arch/arm/configs/raumfeld_defconfig|3 --- > arch/arm/configs/realview-smp_defconfig|3 --- > arch/arm/configs/realview_defconfig|3 --- > arch/arm/configs/s3c2410_defconfig |1 - > arch/arm/configs/shannon_defconfig |2 -- > arch/arm/configs/simpad_defconfig |3 --- > arch/arm/configs/spear13xx_defconfig |1 - > arch/arm/configs/spear3xx_defconfig|1 - > arch/arm/configs/spear6xx_defconfig|1 - > arch/arm/configs/spitz_defconfig |2 -- > arch/arm/configs/tct_hammer_defconfig |2 -- > arch/arm/configs/trizeps4_defconfig|2 -- > arch/arm/configs/viper_defconfig |1 - > arch/arm/configs/xcep_defconfig|1 - > arch/arm/configs/zeus_defconfig|1 - > arch/avr32/configs/atngw100_defconfig |1 - > arch/avr32/configs/atngw100_evklcd100_defconfig|1 - > arch/avr32/configs/atngw100_evklcd101_defconfig|1 - > arch/avr32/con
Re: [PATCH 0/4] defconfigs: cleanup obsolete MTD configs
> That's news for me. I thought they are silently ignored. Do you have an > example of such a warning? Not really. It was just assumption. It seems you are right, they are just ignored silently. But item 2 is still relevant and it was actually confused me when I tried to figure out MTD configuration for my platform. Anyway, garbage should be taken out from time to time. > Seems like the kind of change that can only be reviewed by a script. Good point. Because these patches were done by script to start with. Anyway, I reviewed result patches manually to be completely sure. You can write verifying script though, if you need to, it wouldn't take more than 2 minutes (it takes one-liner, actually). > I seem to remember Greg stating that defconfig files are on their way > out. Did I remember that correctly? Maybe they are. But they still in place, and why it's so, we should maintain them up-to-date. Ideally, this kind of work should be done by someone who introduces changes into Kconfig files. So I just fixed that oversight. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
[PATCH 0/4] defconfigs: cleanup obsolete MTD configs
This patch series removes next obsolete MTD configs from all defconfig files: - CONFIG_MTD_CHAR - CONFIG_MTD_CONCAT - CONFIG_MTD_DEBUG - CONFIG_MTD_DEBUG_VERBOSE - CONFIG_MTD_PARTITIONS All those configs were removed from drivers/mtd/Kconfig earlier, but their usage in defconfig files was remain unnoticed. There are at least two obvious reasons to get rid of those configs: 1. Their usage may cause to build warnings 2. Their usage may confuse someone who is grepping defconfig files to get the clue what MTD configuration may look like. This series is harmless for all those defconfigs and will not break anything. Semen Protsenko (4): defconfigs: remove CONFIG_MTD_CONCAT defconfigs: remove CONFIG_MTD_PARTITIONS defconfigs: remove CONFIG_MTD_CHAR defconfigs: remove CONFIG_MTD_DEBUG* arch/arm/configs/acs5k_defconfig |3 --- arch/arm/configs/acs5k_tiny_defconfig |3 --- arch/arm/configs/am200epdkit_defconfig |1 - arch/arm/configs/assabet_defconfig |2 -- arch/arm/configs/badge4_defconfig |3 --- arch/arm/configs/bockw_defconfig |1 - arch/arm/configs/cerfcube_defconfig|2 -- arch/arm/configs/cm_x2xx_defconfig |1 - arch/arm/configs/cm_x300_defconfig |2 -- arch/arm/configs/cns3420vb_defconfig |2 -- arch/arm/configs/colibri_pxa270_defconfig |2 -- arch/arm/configs/collie_defconfig |2 -- arch/arm/configs/corgi_defconfig |2 -- arch/arm/configs/davinci_all_defconfig |2 -- arch/arm/configs/em_x270_defconfig |1 - arch/arm/configs/ezx_defconfig |1 - arch/arm/configs/h5000_defconfig |1 - arch/arm/configs/hackkit_defconfig |3 --- arch/arm/configs/imote2_defconfig |1 - arch/arm/configs/iop13xx_defconfig |1 - arch/arm/configs/iop32x_defconfig |2 -- arch/arm/configs/iop33x_defconfig |2 -- arch/arm/configs/ixp4xx_defconfig |2 -- arch/arm/configs/ks8695_defconfig |2 -- arch/arm/configs/lart_defconfig|4 arch/arm/configs/lpc32xx_defconfig |1 - arch/arm/configs/lpd270_defconfig |2 -- arch/arm/configs/lubbock_defconfig |2 -- arch/arm/configs/mackerel_defconfig|3 --- arch/arm/configs/magician_defconfig|2 -- arch/arm/configs/mainstone_defconfig |2 -- arch/arm/configs/mini2440_defconfig|3 --- arch/arm/configs/mv78xx0_defconfig |2 -- arch/arm/configs/neponset_defconfig|2 -- arch/arm/configs/netx_defconfig|2 -- arch/arm/configs/nuc910_defconfig |3 --- arch/arm/configs/nuc950_defconfig |3 --- arch/arm/configs/nuc960_defconfig |3 --- arch/arm/configs/omap1_defconfig |4 arch/arm/configs/orion5x_defconfig |1 - arch/arm/configs/pcm027_defconfig |2 -- arch/arm/configs/pleb_defconfig|2 -- arch/arm/configs/pxa255-idp_defconfig |2 -- arch/arm/configs/pxa3xx_defconfig |2 -- arch/arm/configs/raumfeld_defconfig|3 --- arch/arm/configs/realview-smp_defconfig|3 --- arch/arm/configs/realview_defconfig|3 --- arch/arm/configs/s3c2410_defconfig |1 - arch/arm/configs/shannon_defconfig |2 -- arch/arm/configs/simpad_defconfig |3 --- arch/arm/configs/spear13xx_defconfig |1 - arch/arm/configs/spear3xx_defconfig|1 - arch/arm/configs/spear6xx_defconfig|1 - arch/arm/configs/spitz_defconfig |2 -- arch/arm/configs/tct_hammer_defconfig |2 -- arch/arm/configs/trizeps4_defconfig|2 -- arch/arm/configs/viper_defconfig |1 - arch/arm/configs/xcep_defconfig|1 - arch/arm/configs/zeus_defconfig|1 - arch/avr32/configs/atngw100_defconfig |1 - arch/avr32/configs/atngw100_evklcd100_defconfig|1 - arch/avr32/configs/atngw100_evklcd101_defconfig|1 - arch/avr32/configs/atngw100_mrmt_defconfig |1 - arch/avr32/configs/atngw100mkii_defconfig |1 - .../avr32/configs/atngw100mkii_evklcd100_defconfig |1 - .../avr32/configs/atngw100mkii_evklcd101_defconfig |1 - arch/avr32/configs/atstk1002_defconfig |1 - arch/avr32/configs/atstk1003_de
Re: [PATCH 0/4] defconfigs: cleanup obsolete MTD configs
On Sat, 2015-01-24 at 18:33 +0200, Semen Protsenko wrote: > This patch series removes next obsolete MTD configs from all defconfig files: > - CONFIG_MTD_CHAR > - CONFIG_MTD_CONCAT > - CONFIG_MTD_DEBUG > - CONFIG_MTD_DEBUG_VERBOSE > - CONFIG_MTD_PARTITIONS > > All those configs were removed from drivers/mtd/Kconfig earlier, but their > usage > in defconfig files was remain unnoticed. There are at least two obvious > reasons > to get rid of those configs: > 1. Their usage may cause to build warnings That's news for me. I thought they are silently ignored. Do you have an example of such a warning? > 2. Their usage may confuse someone who is grepping defconfig files to get > the clue what MTD configuration may look like. > > This series is harmless for all those defconfigs and will not break anything. > > > Semen Protsenko (4): > defconfigs: remove CONFIG_MTD_CONCAT > defconfigs: remove CONFIG_MTD_PARTITIONS > defconfigs: remove CONFIG_MTD_CHAR > defconfigs: remove CONFIG_MTD_DEBUG* > > arch/arm/configs/acs5k_defconfig |3 --- > [...] > arch/unicore32/configs/unicore32_defconfig |2 -- > 226 files changed, 364 deletions(-) Seems like the kind of change that can only be reviewed by a script. Is there any policy on keeping defconfig files up to date? Because, only slightly exaggerated, all the defconfig files are outdated, in minor or major ways, at any given moment. I seem to remember Greg stating that defconfig files are on their way out. Did I remember that correctly? Paul Bolle ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
