[PATCH 0/5] ehea checkpatch fixups

2008-01-31 Thread Doug Maxey

A small set of fixups for checkpatch.

Based on upstream pull from a few hours ago.

 drivers/net/ehea/ehea.h |3 +
 drivers/net/ehea/ehea_ethtool.c |4 +-
 drivers/net/ehea/ehea_hw.h  |8 +-
 drivers/net/ehea/ehea_main.c|   87 +++--
 drivers/net/ehea/ehea_phyp.c|  158 +++---
 drivers/net/ehea/ehea_phyp.h|   22 +++---
 drivers/net/ehea/ehea_qmr.c |   32 
 drivers/net/ehea/ehea_qmr.h |   16 ++--
 8 files changed, 169 insertions(+), 161 deletions(-)
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH 0/5] ehea checkpatch fixups

2008-01-31 Thread Nathan Lynch
Doug Maxey wrote:
 
 A small set of fixups for checkpatch.
 
 Based on upstream pull from a few hours ago.

Er, ehea doesn't even build right now[1], maybe that could get fixed
first?  :-)

[1] http://lkml.org/lkml/2008/1/28/337
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH 0/5] ehea checkpatch fixups

2008-01-31 Thread Doug Maxey

On Thu, 31 Jan 2008 21:05:42 CST, Nathan Lynch wrote:
 Doug Maxey wrote:
  
  A small set of fixups for checkpatch.
  
  Based on upstream pull from a few hours ago.
 
 Er, ehea doesn't even build right now[1], maybe that could get fixed
 first?  :-)
 
 [1] http://lkml.org/lkml/2008/1/28/337

For sure these won't break it any worse.  ;)  Think of these more as a 
janitorial thing vs. structural.

Doesn't gregkh's patch work?  At least for the interim?

Jan-Bernd,
What tools are looking in sysfs? distro scripts?  I don't see any link 
between ethtool and the driver (other than the driver internal bits).
Am I missing something obvious?

++doug




___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev