Re: [PATCH 02/12] IB/ehca: Add 1 is not longer needed because of firmware interface change
> If the rest of this patchset is okay with you, could you apply it and > leave out this one patch? The patchset will apply cleanly without it. Yes, no problem, I'll drop this patch for now. - R. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 02/12] IB/ehca: Add 1 is not longer needed because of firmware interface change
Roland Dreier <[EMAIL PROTECTED]> wrote on 12.09.2007 22:21:54: > What happens if someone runs the new driver with older firmware? Or > what if someone upgrades the firmware without updating the driver? Thanks for pointing our noses to this. Your comment triggered some further internal discussions about the meaning of the values for the current system implementation. We'll think this one over again and repost the final solution in time for 2.6.24-rc1. If the rest of this patchset is okay with you, could you apply it and leave out this one patch? The patchset will apply cleanly without it. Thanks, Joachim ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 02/12] IB/ehca: Add 1 is not longer needed because of firmware interface change
What happens if someone runs the new driver with older firmware? Or what if someone upgrades the firmware without updating the driver? - R. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
[PATCH 02/12] IB/ehca: Add 1 is not longer needed because of firmware interface change
From: Stefan Roscher <[EMAIL PROTECTED]> Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/hcp_if.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/ehca/hcp_if.c b/drivers/infiniband/hw/ehca/hcp_if.c index 24f4541..8534061 100644 --- a/drivers/infiniband/hw/ehca/hcp_if.c +++ b/drivers/infiniband/hw/ehca/hcp_if.c @@ -317,9 +317,9 @@ u64 hipz_h_alloc_resource_qp(const struct ipz_adapter_handle adapter_handle, max_r10_reg = EHCA_BMASK_SET(H_ALL_RES_QP_MAX_OUTST_SEND_WR, - parms->squeue.max_wr + 1) + parms->squeue.max_wr) | EHCA_BMASK_SET(H_ALL_RES_QP_MAX_OUTST_RECV_WR, -parms->rqueue.max_wr + 1) +parms->rqueue.max_wr) | EHCA_BMASK_SET(H_ALL_RES_QP_MAX_SEND_SGE, parms->squeue.max_sge) | EHCA_BMASK_SET(H_ALL_RES_QP_MAX_RECV_SGE, -- 1.5.2 ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev