Re: [PATCH 08/20] ethernet: hinic: convert tasklets to use new tasklet_setup() API

[Jakub Kicinski]

On Mon, 17 Aug 2020 13:54:22 +0530 Allen Pais wrote:
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly.
> 
> Signed-off-by: Romain Perier 
> Signed-off-by: Allen Pais 

drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:374: warning: Function 
parameter or member 't' not described in 'ceq_tasklet'
drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:374: warning: Excess function 
parameter 'ceq_data' description in 'ceq_tasklet'

[PATCH 08/20] ethernet: hinic: convert tasklets to use new tasklet_setup() API

[Allen Pais]

In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.

Signed-off-by: Romain Perier 
Signed-off-by: Allen Pais 
---
 drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c 
b/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c
index ca8cb68a8d20..f304a5b16d75 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c
@@ -370,9 +370,9 @@ static void eq_irq_work(struct work_struct *work)
  * ceq_tasklet - the tasklet of the EQ that received the event
  * @ceq_data: the eq
  **/
-static void ceq_tasklet(unsigned long ceq_data)
+static void ceq_tasklet(struct tasklet_struct *t)
 {
-   struct hinic_eq *ceq = (struct hinic_eq *)ceq_data;
+   struct hinic_eq *ceq = from_tasklet(ceq, t, ceq_tasklet);
 
eq_irq_handler(ceq);
 }
@@ -782,8 +782,7 @@ static int init_eq(struct hinic_eq *eq, struct hinic_hwif 
*hwif,
 
INIT_WORK(_work->work, eq_irq_work);
} else if (type == HINIC_CEQ) {
-   tasklet_init(>ceq_tasklet, ceq_tasklet,
-(unsigned long)eq);
+   tasklet_setup(>ceq_tasklet, ceq_tasklet);
}
 
/* set the attributes of the msix entry */
-- 
2.17.1