Re: [PATCH 09/10] powerpc: Enable OpenCAPI Storage Class Memory driver on bare metal
On Thu, Jan 30, 2020 at 8:57 PM Alastair D'Silva wrote: > > On Fri, 2019-11-08 at 08:10 +0100, Frederic Barrat wrote: > > > > Le 25/10/2019 à 06:47, Alastair D'Silva a écrit : > > > From: Alastair D'Silva > > > > > > Enable OpenCAPI Storage Class Memory driver on bare metal > > > > > > Signed-off-by: Alastair D'Silva > > > --- > > > arch/powerpc/configs/powernv_defconfig | 4 > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/arch/powerpc/configs/powernv_defconfig > > > b/arch/powerpc/configs/powernv_defconfig > > > index 6658cceb928c..45c0eff94964 100644 > > > --- a/arch/powerpc/configs/powernv_defconfig > > > +++ b/arch/powerpc/configs/powernv_defconfig > > > @@ -352,3 +352,7 @@ CONFIG_KVM_BOOK3S_64=m > > > CONFIG_KVM_BOOK3S_64_HV=m > > > CONFIG_VHOST_NET=m > > > CONFIG_PRINTK_TIME=y > > > +CONFIG_OCXL_SCM=m > > > +CONFIG_DEV_DAX=y > > > +CONFIG_DEV_DAX_PMEM=y This specific line is not needed since DEV_DAX_PMEM already defaults to DEV_DAX. > > > +CONFIG_FS_DAX=y > > > > If this really the intent or do we want to activate DAX only if > > CONFIG_OCXL_SCM is enabled? > > > >Fred > > We had a bit of a play around with reworking this the other day. > > Putting them in as depends didn't make sense, as they are "soft" > dependancies - the driver works and you can do some things without DAX. > > Adding them as selects was rejected as selecting symbols that can also > be manually select is discouraged. > > We ended up going full circle and adding them back to the defconfig. This dovetails with a suggestion Dave made a while back [1]. Given all the pieces that need to be turned on to have a "feature complete" persistent memory enabled build it would be nice to have general config symbols that go and select all the necessary dependencies for DAX, and let the rest happen by default. [1]: https://lore.kernel.org/lkml/20161129021052.GF28177@dastard/
Re: [PATCH 09/10] powerpc: Enable OpenCAPI Storage Class Memory driver on bare metal
On Fri, 2019-11-08 at 08:10 +0100, Frederic Barrat wrote: > > Le 25/10/2019 à 06:47, Alastair D'Silva a écrit : > > From: Alastair D'Silva > > > > Enable OpenCAPI Storage Class Memory driver on bare metal > > > > Signed-off-by: Alastair D'Silva > > --- > > arch/powerpc/configs/powernv_defconfig | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/powerpc/configs/powernv_defconfig > > b/arch/powerpc/configs/powernv_defconfig > > index 6658cceb928c..45c0eff94964 100644 > > --- a/arch/powerpc/configs/powernv_defconfig > > +++ b/arch/powerpc/configs/powernv_defconfig > > @@ -352,3 +352,7 @@ CONFIG_KVM_BOOK3S_64=m > > CONFIG_KVM_BOOK3S_64_HV=m > > CONFIG_VHOST_NET=m > > CONFIG_PRINTK_TIME=y > > +CONFIG_OCXL_SCM=m > > +CONFIG_DEV_DAX=y > > +CONFIG_DEV_DAX_PMEM=y > > +CONFIG_FS_DAX=y > > If this really the intent or do we want to activate DAX only if > CONFIG_OCXL_SCM is enabled? > >Fred We had a bit of a play around with reworking this the other day. Putting them in as depends didn't make sense, as they are "soft" dependancies - the driver works and you can do some things without DAX. Adding them as selects was rejected as selecting symbols that can also be manually select is discouraged. We ended up going full circle and adding them back to the defconfig. -- Alastair D'Silva Open Source Developer Linux Technology Centre, IBM Australia mob: 0423 762 819
Re: [PATCH 09/10] powerpc: Enable OpenCAPI Storage Class Memory driver on bare metal
"Alastair D'Silva" writes: > From: Alastair D'Silva > > Enable OpenCAPI Storage Class Memory driver on bare metal But that doesn't explain why these need to be builtin. > > Signed-off-by: Alastair D'Silva > --- > arch/powerpc/configs/powernv_defconfig | 4 > 1 file changed, 4 insertions(+) > > diff --git a/arch/powerpc/configs/powernv_defconfig > b/arch/powerpc/configs/powernv_defconfig > index 6658cceb928c..45c0eff94964 100644 > --- a/arch/powerpc/configs/powernv_defconfig > +++ b/arch/powerpc/configs/powernv_defconfig > @@ -352,3 +352,7 @@ CONFIG_KVM_BOOK3S_64=m > CONFIG_KVM_BOOK3S_64_HV=m > CONFIG_VHOST_NET=m > CONFIG_PRINTK_TIME=y > +CONFIG_OCXL_SCM=m > +CONFIG_DEV_DAX=y > +CONFIG_DEV_DAX_PMEM=y > +CONFIG_FS_DAX=y > -- > 2.21.0 > ___ > Linux-nvdimm mailing list -- linux-nvd...@lists.01.org > To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
Re: [PATCH 09/10] powerpc: Enable OpenCAPI Storage Class Memory driver on bare metal
Le 25/10/2019 à 06:47, Alastair D'Silva a écrit : From: Alastair D'Silva Enable OpenCAPI Storage Class Memory driver on bare metal Signed-off-by: Alastair D'Silva --- arch/powerpc/configs/powernv_defconfig | 4 1 file changed, 4 insertions(+) diff --git a/arch/powerpc/configs/powernv_defconfig b/arch/powerpc/configs/powernv_defconfig index 6658cceb928c..45c0eff94964 100644 --- a/arch/powerpc/configs/powernv_defconfig +++ b/arch/powerpc/configs/powernv_defconfig @@ -352,3 +352,7 @@ CONFIG_KVM_BOOK3S_64=m CONFIG_KVM_BOOK3S_64_HV=m CONFIG_VHOST_NET=m CONFIG_PRINTK_TIME=y +CONFIG_OCXL_SCM=m +CONFIG_DEV_DAX=y +CONFIG_DEV_DAX_PMEM=y +CONFIG_FS_DAX=y If this really the intent or do we want to activate DAX only if CONFIG_OCXL_SCM is enabled? Fred
Re: [PATCH 09/10] powerpc: Enable OpenCAPI Storage Class Memory driver on bare metal
On Fri, Oct 25, 2019 at 3:51 PM Alastair D'Silva wrote: > > From: Alastair D'Silva > > Enable OpenCAPI Storage Class Memory driver on bare metal > > Signed-off-by: Alastair D'Silva > --- > arch/powerpc/configs/powernv_defconfig | 4 > 1 file changed, 4 insertions(+) > > diff --git a/arch/powerpc/configs/powernv_defconfig > b/arch/powerpc/configs/powernv_defconfig > index 6658cceb928c..45c0eff94964 100644 > --- a/arch/powerpc/configs/powernv_defconfig > +++ b/arch/powerpc/configs/powernv_defconfig > @@ -352,3 +352,7 @@ CONFIG_KVM_BOOK3S_64=m > CONFIG_KVM_BOOK3S_64_HV=m > CONFIG_VHOST_NET=m > CONFIG_PRINTK_TIME=y > +CONFIG_OCXL_SCM=m > +CONFIG_DEV_DAX=y > +CONFIG_DEV_DAX_PMEM=y These should probably be modules. Having them as builtins will force their dependencies (i.e. libnvdimm) to be built into the kernel too. > +CONFIG_FS_DAX=y > -- > 2.21.0 > ___ > Linux-nvdimm mailing list -- linux-nvd...@lists.01.org > To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
[PATCH 09/10] powerpc: Enable OpenCAPI Storage Class Memory driver on bare metal
From: Alastair D'Silva Enable OpenCAPI Storage Class Memory driver on bare metal Signed-off-by: Alastair D'Silva --- arch/powerpc/configs/powernv_defconfig | 4 1 file changed, 4 insertions(+) diff --git a/arch/powerpc/configs/powernv_defconfig b/arch/powerpc/configs/powernv_defconfig index 6658cceb928c..45c0eff94964 100644 --- a/arch/powerpc/configs/powernv_defconfig +++ b/arch/powerpc/configs/powernv_defconfig @@ -352,3 +352,7 @@ CONFIG_KVM_BOOK3S_64=m CONFIG_KVM_BOOK3S_64_HV=m CONFIG_VHOST_NET=m CONFIG_PRINTK_TIME=y +CONFIG_OCXL_SCM=m +CONFIG_DEV_DAX=y +CONFIG_DEV_DAX_PMEM=y +CONFIG_FS_DAX=y -- 2.21.0
