Re: [PATCH 1/1] ASoC: fsl: fsl_ssi: Add dev_err_probe if PCM DMA init fails

[Mark Brown]

On Thu, 14 Mar 2024 15:16:42 +0100, Alexander Stein wrote:
> This happens especially if this driver is built-in, but SDMA driver
> is configured as module.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: fsl: fsl_ssi: Add dev_err_probe if PCM DMA init fails
  commit: 3ca49e7f9475ac06614edf1bfece123eafbdf8f3

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH 1/1] ASoC: fsl: fsl_ssi: Add dev_err_probe if PCM DMA init fails

[Shengjiu Wang]

On Thu, Mar 14, 2024 at 10:16 PM Alexander Stein
 wrote:
>
> This happens especially if this driver is built-in, but SDMA driver
> is configured as module.
>
> Signed-off-by: Alexander Stein 

Acked-by: Shengjiu Wang 

Best Regards
Shengjiu Wang
> ---
>  sound/soc/fsl/fsl_ssi.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
> index ab6ec1974807..4ca3a16f7ac0 100644
> --- a/sound/soc/fsl/fsl_ssi.c
> +++ b/sound/soc/fsl/fsl_ssi.c
> @@ -1401,8 +1401,10 @@ static int fsl_ssi_imx_probe(struct platform_device 
> *pdev,
> goto error_pcm;
> } else {
> ret = imx_pcm_dma_init(pdev);
> -   if (ret)
> +   if (ret) {
> +   dev_err_probe(dev, ret, "Failed to init PCM DMA\n");
> goto error_pcm;
> +   }
> }
>
> return 0;
> --
> 2.34.1
>

[PATCH 1/1] ASoC: fsl: fsl_ssi: Add dev_err_probe if PCM DMA init fails

[Alexander Stein]

This happens especially if this driver is built-in, but SDMA driver
is configured as module.

Signed-off-by: Alexander Stein 
---
 sound/soc/fsl/fsl_ssi.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index ab6ec1974807..4ca3a16f7ac0 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -1401,8 +1401,10 @@ static int fsl_ssi_imx_probe(struct platform_device 
*pdev,
goto error_pcm;
} else {
ret = imx_pcm_dma_init(pdev);
-   if (ret)
+   if (ret) {
+   dev_err_probe(dev, ret, "Failed to init PCM DMA\n");
goto error_pcm;
+   }
}
 
return 0;
-- 
2.34.1