Re: [PATCH 1/2] genirq: reliably replay pending edge-triggered irq
On Tue, 27 Apr 2010 15:42:11 +0200 (CEST) Thomas Gleixner t...@linutronix.de wrote: On Thu, 22 Apr 2010, Guillaume Knispel wrote: [snip] acked and masked at controller level and IRQ_PENDING is set. --- arch/arm/Kconfig |4 arch/arm/configs/acs5k_defconfig |1 - arch/arm/configs/acs5k_tiny_defconfig |1 - Changing the defconfigs should be a separate patch and I'm not going to push such a thing through the genirq tree. The stale entries do not hurt. Ok In this separate patch, to I put genirq in the title? Do I put it in the same series? Cheers, Guillaume Knispel ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 1/2] genirq: reliably replay pending edge-triggered irq
On Wed, 28 Apr 2010, Guillaume Knispel wrote: On Tue, 27 Apr 2010 15:42:11 +0200 (CEST) Thomas Gleixner t...@linutronix.de wrote: On Thu, 22 Apr 2010, Guillaume Knispel wrote: [snip] acked and masked at controller level and IRQ_PENDING is set. --- arch/arm/Kconfig |4 arch/arm/configs/acs5k_defconfig |1 - arch/arm/configs/acs5k_tiny_defconfig |1 - Changing the defconfigs should be a separate patch and I'm not going to push such a thing through the genirq tree. The stale entries do not hurt. Ok In this separate patch, to I put genirq in the title? Do I put it in the same series? Just keep them out for now and send them to the arch maintainers once the change hits linus tree. Thanks, tglx ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 1/2] genirq: reliably replay pending edge-triggered irq
On Thu, 22 Apr 2010, Guillaume Knispel wrote: When the critical section in handle_edge_irq() is executed after IRQ_DISABLED has been set in the one in disable_irq(), the interrupt is in the one ? -ENOPARSE acked and masked at controller level and IRQ_PENDING is set. --- arch/arm/Kconfig |4 arch/arm/configs/acs5k_defconfig |1 - arch/arm/configs/acs5k_tiny_defconfig |1 - Changing the defconfigs should be a separate patch and I'm not going to push such a thing through the genirq tree. The stale entries do not hurt. diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c index 127b871..9bec343 100644 --- a/arch/x86/kernel/apic/io_apic.c +++ b/arch/x86/kernel/apic/io_apic.c @@ -1423,7 +1423,7 @@ int setup_ioapic_entry(int apic_id, int irq, entry-polarity = polarity; /* Mask level triggered irqs. - * Use IRQ_DELAYED_DISABLE for edge triggered irqs. + * Edge triggered irqs can be resent by software. That change is unrelated and should be done in a seperate patch. Thanks, tglx ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
