Re: [PATCH 1/2] powerpc/83xx: add DS1339 RTC support for MPC8349E-mITX boards

2008-10-21 Thread Scott Wood 
On Fri, Oct 17, 2008 at 10:56:59PM +0400, Anton Vorontsov wrote:
 diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts 
 b/arch/powerpc/boot/dts/mpc8349emitx.dts
 index 5cedf37..7fc5414 100644
 --- a/arch/powerpc/boot/dts/mpc8349emitx.dts
 +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
 @@ -83,6 +83,14 @@
   interrupts = 15 0x8;
   interrupt-parent = ipic;
   dfsrr;
 +
 + [EMAIL PROTECTED] {
 + device_type = rtc;
 + compatible = dallas,ds1339;
 + reg = 0x68;
 + interrupts = 18 0x8;
 + interrupt-parent = ipic;
 + };

Why are we adding more device_types?

-Scott
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 1/2] powerpc/83xx: add DS1339 RTC support for MPC8349E-mITX boards

2008-10-21 Thread Kumar Gala 


On Oct 21, 2008, at 1:23 PM, Scott Wood wrote:


On Fri, Oct 17, 2008 at 10:56:59PM +0400, Anton Vorontsov wrote:
diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/ 
boot/dts/mpc8349emitx.dts

index 5cedf37..7fc5414 100644
--- a/arch/powerpc/boot/dts/mpc8349emitx.dts
+++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
@@ -83,6 +83,14 @@
interrupts = 15 0x8;
interrupt-parent = ipic;
dfsrr;
+
+   [EMAIL PROTECTED] {
+   device_type = rtc;
+   compatible = dallas,ds1339;
+   reg = 0x68;
+   interrupts = 18 0x8;
+   interrupt-parent = ipic;
+   };


Why are we adding more device_types?


I think the 'rtc' device_type is legacy from OF.

- k
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 1/2] powerpc/83xx: add DS1339 RTC support for MPC8349E-mITX boards

2008-10-21 Thread Scott Wood 

Kumar Gala wrote:

On Oct 21, 2008, at 1:23 PM, Scott Wood wrote:

Why are we adding more device_types?


I think the 'rtc' device_type is legacy from OF.


Yes, and it advertises a run-time service that we do not and cannot 
support.  We should not have it in flat trees.


-Scott
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 1/2] powerpc/83xx: add DS1339 RTC support for MPC8349E-mITX boards

2008-10-21 Thread Anton Vorontsov 
On Tue, Oct 21, 2008 at 01:23:44PM -0500, Scott Wood wrote:
 On Fri, Oct 17, 2008 at 10:56:59PM +0400, Anton Vorontsov wrote:
  diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts 
  b/arch/powerpc/boot/dts/mpc8349emitx.dts
  index 5cedf37..7fc5414 100644
  --- a/arch/powerpc/boot/dts/mpc8349emitx.dts
  +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
  @@ -83,6 +83,14 @@
  interrupts = 15 0x8;
  interrupt-parent = ipic;
  dfsrr;
  +
  +   [EMAIL PROTECTED] {
  +   device_type = rtc;
  +   compatible = dallas,ds1339;
  +   reg = 0x68;
  +   interrupts = 18 0x8;
  +   interrupt-parent = ipic;
  +   };
 
 Why are we adding more device_types?

It seems that CHRP is using the device_type for rtc devices, which
means that real OF also provide it. But I guess we don't need it,
right? Then we should cleanup all the boards.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 1/2] powerpc/83xx: add DS1339 RTC support for MPC8349E-mITX boards

2008-10-20 Thread Kumar Gala 


On Oct 17, 2008, at 1:56 PM, Anton Vorontsov wrote:

The RTC is sitting on the I2C2 bus at address 0x68. RTC interrupt  
signal
is connected to the IPIC's EXT2 interrupt line, the line is shared  
with

Vitesse 8201 Ethernet PHY.

Signed-off-by: Anton Vorontsov [EMAIL PROTECTED]
---
arch/powerpc/boot/dts/mpc8349emitx.dts   |8 
arch/powerpc/boot/dts/mpc8349emitxgp.dts |8 
2 files changed, 16 insertions(+), 0 deletions(-)


applied

- k
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH 1/2] powerpc/83xx: add DS1339 RTC support for MPC8349E-mITX boards

2008-10-17 Thread Anton Vorontsov 
The RTC is sitting on the I2C2 bus at address 0x68. RTC interrupt signal
is connected to the IPIC's EXT2 interrupt line, the line is shared with
Vitesse 8201 Ethernet PHY.

Signed-off-by: Anton Vorontsov [EMAIL PROTECTED]
---
 arch/powerpc/boot/dts/mpc8349emitx.dts   |8 
 arch/powerpc/boot/dts/mpc8349emitxgp.dts |8 
 2 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts 
b/arch/powerpc/boot/dts/mpc8349emitx.dts
index 5cedf37..7fc5414 100644
--- a/arch/powerpc/boot/dts/mpc8349emitx.dts
+++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
@@ -83,6 +83,14 @@
interrupts = 15 0x8;
interrupt-parent = ipic;
dfsrr;
+
+   [EMAIL PROTECTED] {
+   device_type = rtc;
+   compatible = dallas,ds1339;
+   reg = 0x68;
+   interrupts = 18 0x8;
+   interrupt-parent = ipic;
+   };
};
 
[EMAIL PROTECTED] {
diff --git a/arch/powerpc/boot/dts/mpc8349emitxgp.dts 
b/arch/powerpc/boot/dts/mpc8349emitxgp.dts
index 81ae1d3..fa40647 100644
--- a/arch/powerpc/boot/dts/mpc8349emitxgp.dts
+++ b/arch/powerpc/boot/dts/mpc8349emitxgp.dts
@@ -81,6 +81,14 @@
interrupts = 15 0x8;
interrupt-parent = ipic;
dfsrr;
+
+   [EMAIL PROTECTED] {
+   device_type = rtc;
+   compatible = dallas,ds1339;
+   reg = 0x68;
+   interrupts = 18 0x8;
+   interrupt-parent = ipic;
+   };
};
 
[EMAIL PROTECTED] {
-- 
1.5.6.3

___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev