Re: [PATCH 1/2] powerpc/crypto: fix missing skcipher dependency for aes-gcm-p10

2023-08-10 Thread Michael Ellerman
On Mon, 10 Jul 2023 09:46:46 -0700, Omar Sandoval wrote:
> My stripped down configuration fails to build with:
> 
>   ERROR: modpost: "skcipher_walk_aead_encrypt" 
> [arch/powerpc/crypto/aes-gcm-p10-crypto.ko] undefined!
>   ERROR: modpost: "skcipher_walk_done" 
> [arch/powerpc/crypto/aes-gcm-p10-crypto.ko] undefined!
>   ERROR: modpost: "skcipher_walk_aead_decrypt" 
> [arch/powerpc/crypto/aes-gcm-p10-crypto.ko] undefined!
> 
> Fix it by selecting CRYPTO_SKCIPHER.
> 
> [...]

Applied to powerpc/next.

[1/2] powerpc/crypto: fix missing skcipher dependency for aes-gcm-p10
  https://git.kernel.org/powerpc/c/9d6e1c21e1be4643628ee343e0b8d79828485ba2
[2/2] powerpc/crypto: don't build aes-gcm-p10 by default
  https://git.kernel.org/powerpc/c/026fa6c52da5fc559d896a62cb6f8e208c22738d

cheers


[PATCH 1/2] powerpc/crypto: fix missing skcipher dependency for aes-gcm-p10

2023-07-10 Thread Omar Sandoval
From: Omar Sandoval 

My stripped down configuration fails to build with:

  ERROR: modpost: "skcipher_walk_aead_encrypt" 
[arch/powerpc/crypto/aes-gcm-p10-crypto.ko] undefined!
  ERROR: modpost: "skcipher_walk_done" 
[arch/powerpc/crypto/aes-gcm-p10-crypto.ko] undefined!
  ERROR: modpost: "skcipher_walk_aead_decrypt" 
[arch/powerpc/crypto/aes-gcm-p10-crypto.ko] undefined!

Fix it by selecting CRYPTO_SKCIPHER.

Signed-off-by: Omar Sandoval 
---
 arch/powerpc/crypto/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig
index ad1872518992..81ae015861c0 100644
--- a/arch/powerpc/crypto/Kconfig
+++ b/arch/powerpc/crypto/Kconfig
@@ -100,6 +100,7 @@ config CRYPTO_AES_GCM_P10
select CRYPTO_LIB_AES
select CRYPTO_ALGAPI
select CRYPTO_AEAD
+   select CRYPTO_SKCIPHER
default m
help
  AEAD cipher: AES cipher algorithms (FIPS-197)
-- 
2.41.0