RE: [PATCH 1/3] [POWERPC] Add docs for Freescale 83xx SATA device tree nodes

2007-12-02 Thread Li Yang 
 -Original Message-
 From: Kumar Gala [mailto:[EMAIL PROTECTED] 
 Sent: Wednesday, November 21, 2007 1:13 PM
 To: linuxppc-dev@ozlabs.org
 Cc: Segher Boessenkool; Li Yang
 Subject: [PATCH 1/3] [POWERPC] Add docs for Freescale 83xx 
 SATA device tree nodes
 
 ---
  Documentation/powerpc/booting-without-of.txt |   23 
 +++
  1 files changed, 23 insertions(+), 0 deletions(-)
 
 diff --git a/Documentation/powerpc/booting-without-of.txt 
 b/Documentation/powerpc/booting-without-of.txt
 index e9a3cb1..eb14dd5 100644
 --- a/Documentation/powerpc/booting-without-of.txt
 +++ b/Documentation/powerpc/booting-without-of.txt
 @@ -2514,6 +2514,29 @@ platforms are moved over to use the 
 flattened-device-tree model.
Requred properties:
 - current-speed : Baud rate of uartlite
 
 +* Freescale 8xxx/3.0 Gb/s SATA nodes
 +
 +SATA nodes are defined to describe on-chip Serial ATA 
 controllers.
 +Each SATA port should have its own node.
 +
 +Required properties:
 +- compatible: compatible list, contains 2 
 entries, first is
 +  fsl,sata-CHIP, where CHIP is the processor

Should be fsl,CHIP-sata

 +  (mpc8315, mpc8379, etc.) and the second is
 +  fsl,sata-pq2pro

Why not use pq2pro-sata to be consistent with the CHIP version?

 +- interrupts: interrupt mapping for SATA IRQ
 +- interrupt-parent  : optional, if needed for interrupt mapping
 +- reg   : registers mapping
 +
 +   Example:
 +
 + [EMAIL PROTECTED] {
 + compatible = fsl,mpc8315-sata, fsl,sata-pq2pro;

Quotation mark missing.

- Leo
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 1/3] [POWERPC] Add docs for Freescale 83xx SATA device tree nodes

2007-11-26 Thread Kumar Gala 

On Nov 25, 2007, at 4:22 PM, Arnd Bergmann wrote:

 On Wednesday 21 November 2007, Kumar Gala wrote:
 +* Freescale 8xxx/3.0 Gb/s SATA nodes
 +
 +SATA nodes are defined to describe on-chip Serial ATA  
 controllers.
 +Each SATA port should have its own node.
 +
 +Required properties:
 +- compatible: compatible list, contains 2 entries,  
 first is
 +fsl,sata-CHIP, where CHIP is the processor
 +(mpc8315, mpc8379, etc.) and the second is
 +fsl,sata-pq2pro
 +- interrupts: interrupt mapping for SATA IRQ
 +- interrupt-parent  : optional, if needed for interrupt mapping
 +- reg   : registers mapping
 +

 Should this maybe also mandate a compatible property that is defined
 in a way to match the generic (p)ata_of_platform driver?

Is there something about the (p)ata_of_platform driver you think we  
can use.  The SATA controller here is a unique piece of HW and  
requires a unique driver so I'm not sure what we get from  
(p)ata_of_platform.

- k
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 1/3] [POWERPC] Add docs for Freescale 83xx SATA device tree nodes

2007-11-26 Thread Arnd Bergmann 
On Monday 26 November 2007, you wrote:
 On Nov 25, 2007, at 4:22 PM, Arnd Bergmann wrote:

  Should this maybe also mandate a compatible property that is defined
  in a way to match the generic (p)ata_of_platform driver?
 
 Is there something about the (p)ata_of_platform driver you think we  
 can use.  The SATA controller here is a unique piece of HW and  
 requires a unique driver so I'm not sure what we get from  
 (p)ata_of_platform.

All ata controllers I've dealt with so far are to some degree compatible
to the old PC style controllers. My point was that this should ideally
be reflected in the device tree so that you could in theory use the
ata_of_platform driver, even if you normally would prefer the new
driver for performance reasons.

If your controller doesn't have the legacy register set, this clearly
doesn't make any sense and you should not list it as compatible with
something generic.

Arnd 
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH 1/3] [POWERPC] Add docs for Freescale 83xx SATA device tree nodes

2007-11-20 Thread Kumar Gala 
---
 Documentation/powerpc/booting-without-of.txt |   23 +++
 1 files changed, 23 insertions(+), 0 deletions(-)

diff --git a/Documentation/powerpc/booting-without-of.txt 
b/Documentation/powerpc/booting-without-of.txt
index e9a3cb1..eb14dd5 100644
--- a/Documentation/powerpc/booting-without-of.txt
+++ b/Documentation/powerpc/booting-without-of.txt
@@ -2514,6 +2514,29 @@ platforms are moved over to use the 
flattened-device-tree model.
   Requred properties:
- current-speed : Baud rate of uartlite

+* Freescale 8xxx/3.0 Gb/s SATA nodes
+
+SATA nodes are defined to describe on-chip Serial ATA controllers.
+Each SATA port should have its own node.
+
+Required properties:
+- compatible: compatible list, contains 2 entries, first is
+fsl,sata-CHIP, where CHIP is the processor
+(mpc8315, mpc8379, etc.) and the second is
+fsl,sata-pq2pro
+- interrupts: interrupt mapping for SATA IRQ
+- interrupt-parent  : optional, if needed for interrupt mapping
+- reg   : registers mapping
+
+   Example:
+
+   [EMAIL PROTECTED] {
+   compatible = fsl,mpc8315-sata, fsl,sata-pq2pro;
+   reg = 19000 1000;
+   interrupts = 2d 8;
+   interrupt-parent =  ipic ;
+};
+
More devices will be defined as this spec matures.

 VII - Specifying interrupt information for devices
-- 
1.5.3.4

___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev