Re: [PATCH 1/3] rtc: ds1374: add uie_unsupported property to drop warning
Hi, On 08/05/2020 13:49:23+0800, Biwen Li wrote: > From: Biwen Li > > Add uie_unsupported property to drop warning as follows: > - $ hwclock.util-linux > hwclock.util-liux: select() /dev/rtc0 > to wait for clock tick timed out > > My case: > - RTC ds1374's INT pin is connected to VCC on T4240RDB, > then the RTC cannot inform cpu about the alarm > interrupt > > Signed-off-by: Biwen Li > --- > drivers/rtc/rtc-ds1374.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/rtc/rtc-ds1374.c b/drivers/rtc/rtc-ds1374.c > index 9c51a12cf70f..e530e887a17e 100644 > --- a/drivers/rtc/rtc-ds1374.c > +++ b/drivers/rtc/rtc-ds1374.c > @@ -651,6 +651,10 @@ static int ds1374_probe(struct i2c_client *client, > if (ret) > return ret; > > + if (of_property_read_bool(client->dev.of_node, > + "uie_unsupported")) > + ds1374->rtc->uie_unsupported = true; > + This is not how this is supposed to work, either the RTC support uie or don't, it is not board dependent and certainly doesn't require an (undocumented) DT property. > #ifdef CONFIG_RTC_DRV_DS1374_WDT > save_client = client; > ret = misc_register(_miscdev); > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
RE: [PATCH 1/3] rtc: ds1374: add uie_unsupported property to drop warning
> > Hi, > > On 08/05/2020 13:49:23+0800, Biwen Li wrote: > > From: Biwen Li > > > > Add uie_unsupported property to drop warning as follows: > > - $ hwclock.util-linux > > hwclock.util-liux: select() /dev/rtc0 > > to wait for clock tick timed out > > > > My case: > > - RTC ds1374's INT pin is connected to VCC on T4240RDB, > > then the RTC cannot inform cpu about the alarm > > interrupt > > > > Signed-off-by: Biwen Li > > --- > > drivers/rtc/rtc-ds1374.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/rtc/rtc-ds1374.c b/drivers/rtc/rtc-ds1374.c index > > 9c51a12cf70f..e530e887a17e 100644 > > --- a/drivers/rtc/rtc-ds1374.c > > +++ b/drivers/rtc/rtc-ds1374.c > > @@ -651,6 +651,10 @@ static int ds1374_probe(struct i2c_client *client, > > if (ret) > > return ret; > > > > + if (of_property_read_bool(client->dev.of_node, > > +"uie_unsupported")) > > + ds1374->rtc->uie_unsupported = true; > > + > > This is not how this is supposed to work, either the RTC support uie or > don't, it is > not board dependent and certainly doesn't require an > (undocumented) DT property. Okay, got it. Thanks. > > > #ifdef CONFIG_RTC_DRV_DS1374_WDT > > save_client = client; > > ret = misc_register(_miscdev); > > -- > > 2.17.1 > > > > -- > Alexandre Belloni, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
[PATCH 1/3] rtc: ds1374: add uie_unsupported property to drop warning
From: Biwen Li Add uie_unsupported property to drop warning as follows: - $ hwclock.util-linux hwclock.util-liux: select() /dev/rtc0 to wait for clock tick timed out My case: - RTC ds1374's INT pin is connected to VCC on T4240RDB, then the RTC cannot inform cpu about the alarm interrupt Signed-off-by: Biwen Li --- drivers/rtc/rtc-ds1374.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/rtc/rtc-ds1374.c b/drivers/rtc/rtc-ds1374.c index 9c51a12cf70f..e530e887a17e 100644 --- a/drivers/rtc/rtc-ds1374.c +++ b/drivers/rtc/rtc-ds1374.c @@ -651,6 +651,10 @@ static int ds1374_probe(struct i2c_client *client, if (ret) return ret; + if (of_property_read_bool(client->dev.of_node, +"uie_unsupported")) + ds1374->rtc->uie_unsupported = true; + #ifdef CONFIG_RTC_DRV_DS1374_WDT save_client = client; ret = misc_register(_miscdev); -- 2.17.1
