Re: [PATCH 1/6] powerpc/pseries: fix the object owners enum value in plpks driver

2022-11-24 Thread Andrew Donnellan
On Sun, 2022-11-06 at 15:58 -0500, Nayna Jain wrote:
> OS_VAR_LINUX enum in PLPKS driver should be 0x02 instead of 0x01.

This should be PLPKS_VAR_LINUX. And it's a macro, not an enum.

The new value does indeed match the (currently IBM internal)
specification - 0x01 is AIX.

> 
> Fixes: 2454a7af0f2a ("powerpc/pseries: define driver for Platform
> KeyStore")
> Signed-off-by: Nayna Jain 

Should be noted that at present, this macro isn't used anywhere - it is
used in a future series.

> ---
>  arch/powerpc/platforms/pseries/plpks.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/platforms/pseries/plpks.h
> b/arch/powerpc/platforms/pseries/plpks.h
> index c6a291367bb1..275ccd86bfb5 100644
> --- a/arch/powerpc/platforms/pseries/plpks.h
> +++ b/arch/powerpc/platforms/pseries/plpks.h
> @@ -17,7 +17,7 @@
>  #define WORLDREADABLE 0x0800
>  #define SIGNEDUPDATE 0x0100
>  
> -#define PLPKS_VAR_LINUX0x01
> +#define PLPKS_VAR_LINUX0x02
>  #define PLPKS_VAR_COMMON   0x04
>  
>  struct plpks_var {

-- 
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com   IBM Australia Limited


[PATCH 1/6] powerpc/pseries: fix the object owners enum value in plpks driver

2022-11-06 Thread Nayna Jain
OS_VAR_LINUX enum in PLPKS driver should be 0x02 instead of 0x01.

Fixes: 2454a7af0f2a ("powerpc/pseries: define driver for Platform KeyStore")
Signed-off-by: Nayna Jain 
---
 arch/powerpc/platforms/pseries/plpks.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/pseries/plpks.h 
b/arch/powerpc/platforms/pseries/plpks.h
index c6a291367bb1..275ccd86bfb5 100644
--- a/arch/powerpc/platforms/pseries/plpks.h
+++ b/arch/powerpc/platforms/pseries/plpks.h
@@ -17,7 +17,7 @@
 #define WORLDREADABLE 0x0800
 #define SIGNEDUPDATE 0x0100
 
-#define PLPKS_VAR_LINUX0x01
+#define PLPKS_VAR_LINUX0x02
 #define PLPKS_VAR_COMMON   0x04
 
 struct plpks_var {
-- 
2.31.1