Re: [PATCH 1/6] pseries: avoid excess rtas calls

2007-08-08 Thread Nathan Lynch
Linas Vepstas wrote:
 
 We don't need to look up the rtas event token once per 
 cpu per second. This avoids some misc string ops and 
 rtas calls and provides some minor performance improvement.

It does not avoid any calls to RTAS.  (rtas_token merely looks up
properties under the /rtas node.)

Otherwise, looks okay.

___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH 1/6] pseries: avoid excess rtas calls

2007-08-08 Thread Linas Vepstas
On Wed, Aug 08, 2007 at 04:57:39PM -0500, Nathan Lynch wrote:
 Linas Vepstas wrote:
  
  We don't need to look up the rtas event token once per 
  cpu per second. This avoids some misc string ops and 
  rtas calls and provides some minor performance improvement.
 
 It does not avoid any calls to RTAS.  (rtas_token merely looks up
 properties under the /rtas node.)

Right. I'd vaguely known but forgotten that of_get_property didn't 
actually turn into an rtas call.

 Otherwise, looks okay.

Should I resubmit with modified commit message, or does anyone care?

--linas
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev