Re: [PATCH 13/15] raid: Remove now superfluous sentinel element from ctl_table array

[Song Liu]

On Thu, Sep 28, 2023 at 6:20 AM Joel Granados via B4 Relay
 wrote:
>
> From: Joel Granados 
>
> This commit comes at the tail end of a greater effort to remove the
> empty elements at the end of the ctl_table arrays (sentinels) which
> will reduce the overall build time size of the kernel and run time
> memory bloat by ~64 bytes per sentinel (further information Link :
> https://lore.kernel.org/all/zo5yx5jfoggi%2f...@bombadil.infradead.org/)
>
> Remove sentinel from raid_table
>
> Signed-off-by: Joel Granados 
> ---
>  drivers/md/md.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index a104a025084d..3866d8f754a0 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -304,8 +304,7 @@ static struct ctl_table raid_table[] = {
> .maxlen = sizeof(int),
> .mode   = S_IRUGO|S_IWUSR,
> .proc_handler   = proc_dointvec,
> -   },
> -   { }
> +   }
>  };

Please keep "}," as Greg suggested. Otherwise,

Acked-by: Song Liu 

Thanks,
Song

[PATCH 13/15] raid: Remove now superfluous sentinel element from ctl_table array

[Joel Granados via B4 Relay]

From: Joel Granados 

This commit comes at the tail end of a greater effort to remove the
empty elements at the end of the ctl_table arrays (sentinels) which
will reduce the overall build time size of the kernel and run time
memory bloat by ~64 bytes per sentinel (further information Link :
https://lore.kernel.org/all/zo5yx5jfoggi%2f...@bombadil.infradead.org/)

Remove sentinel from raid_table

Signed-off-by: Joel Granados 
---
 drivers/md/md.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index a104a025084d..3866d8f754a0 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -304,8 +304,7 @@ static struct ctl_table raid_table[] = {
.maxlen = sizeof(int),
.mode   = S_IRUGO|S_IWUSR,
.proc_handler   = proc_dointvec,
-   },
-   { }
+   }
 };
 
 static int start_readonly;

-- 
2.30.2