Re: [PATCH 14/15] hyper-v/azure: Remove now superfluous sentinel element from ctl_table array
On Thu, Sep 28, 2023 at 03:26:16PM +, Wei Liu wrote: > Please change the prefix to "Drivers: hv:" in the subject line in the > two patches. I'll change the commit message for the 14/15 patch from "hyper-v/azure" to "Drivers: hv:". But I only see one patch that needs this. Which is the other one? best > > On Thu, Sep 28, 2023 at 03:21:39PM +0200, Joel Granados via B4 Relay wrote: > > From: Joel Granados > > > > This commit comes at the tail end of a greater effort to remove the > > empty elements at the end of the ctl_table arrays (sentinels) which > > will reduce the overall build time size of the kernel and run time > > memory bloat by ~64 bytes per sentinel (further information Link : > > https://lore.kernel.org/all/zo5yx5jfoggi%2f...@bombadil.infradead.org/) > > > > Remove sentinel from hv_ctl_table > > > > Signed-off-by: Joel Granados > > --- > > drivers/hv/hv_common.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c > > index ccad7bca3fd3..bc7d678030aa 100644 > > --- a/drivers/hv/hv_common.c > > +++ b/drivers/hv/hv_common.c > > @@ -147,8 +147,7 @@ static struct ctl_table hv_ctl_table[] = { > > .proc_handler = proc_dointvec_minmax, > > .extra1 = SYSCTL_ZERO, > > .extra2 = SYSCTL_ONE > > - }, > > - {} > > + } > > Please keep the comma at the end. > > > }; > > > > static int hv_die_panic_notify_crash(struct notifier_block *self, > > > > -- > > 2.30.2 > > -- Joel Granados signature.asc Description: PGP signature
Re: [PATCH 14/15] hyper-v/azure: Remove now superfluous sentinel element from ctl_table array
On Thu, Sep 28, 2023 at 03:26:16PM +, Wei Liu wrote: > Please change the prefix to "Drivers: hv:" in the subject line in the > two patches. > > On Thu, Sep 28, 2023 at 03:21:39PM +0200, Joel Granados via B4 Relay wrote: > > From: Joel Granados > > > > This commit comes at the tail end of a greater effort to remove the > > empty elements at the end of the ctl_table arrays (sentinels) which > > will reduce the overall build time size of the kernel and run time > > memory bloat by ~64 bytes per sentinel (further information Link : > > https://lore.kernel.org/all/zo5yx5jfoggi%2f...@bombadil.infradead.org/) > > > > Remove sentinel from hv_ctl_table > > > > Signed-off-by: Joel Granados > > --- > > drivers/hv/hv_common.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c > > index ccad7bca3fd3..bc7d678030aa 100644 > > --- a/drivers/hv/hv_common.c > > +++ b/drivers/hv/hv_common.c > > @@ -147,8 +147,7 @@ static struct ctl_table hv_ctl_table[] = { > > .proc_handler = proc_dointvec_minmax, > > .extra1 = SYSCTL_ZERO, > > .extra2 = SYSCTL_ONE > > - }, > > - {} > > + } > > Please keep the comma at the end. My V2 will have this. > > > }; > > > > static int hv_die_panic_notify_crash(struct notifier_block *self, > > > > -- > > 2.30.2 > > -- Joel Granados signature.asc Description: PGP signature
Re: [PATCH 14/15] hyper-v/azure: Remove now superfluous sentinel element from ctl_table array
Please change the prefix to "Drivers: hv:" in the subject line in the two patches. On Thu, Sep 28, 2023 at 03:21:39PM +0200, Joel Granados via B4 Relay wrote: > From: Joel Granados > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_table arrays (sentinels) which > will reduce the overall build time size of the kernel and run time > memory bloat by ~64 bytes per sentinel (further information Link : > https://lore.kernel.org/all/zo5yx5jfoggi%2f...@bombadil.infradead.org/) > > Remove sentinel from hv_ctl_table > > Signed-off-by: Joel Granados > --- > drivers/hv/hv_common.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c > index ccad7bca3fd3..bc7d678030aa 100644 > --- a/drivers/hv/hv_common.c > +++ b/drivers/hv/hv_common.c > @@ -147,8 +147,7 @@ static struct ctl_table hv_ctl_table[] = { > .proc_handler = proc_dointvec_minmax, > .extra1 = SYSCTL_ZERO, > .extra2 = SYSCTL_ONE > - }, > - {} > + } Please keep the comma at the end. > }; > > static int hv_die_panic_notify_crash(struct notifier_block *self, > > -- > 2.30.2 >
[PATCH 14/15] hyper-v/azure: Remove now superfluous sentinel element from ctl_table array
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https://lore.kernel.org/all/zo5yx5jfoggi%2f...@bombadil.infradead.org/) Remove sentinel from hv_ctl_table Signed-off-by: Joel Granados --- drivers/hv/hv_common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c index ccad7bca3fd3..bc7d678030aa 100644 --- a/drivers/hv/hv_common.c +++ b/drivers/hv/hv_common.c @@ -147,8 +147,7 @@ static struct ctl_table hv_ctl_table[] = { .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE - }, - {} + } }; static int hv_die_panic_notify_crash(struct notifier_block *self, -- 2.30.2