Re: [PATCH 2/2] drivers: tty: Mark the function hvc_poll_init() as static in hvc_console.c

2013-12-16 Thread Josh Triplett 
On Mon, Dec 16, 2013 at 04:31:28PM +0530, Rashika Kheria wrote:
 Mark the function hvc_poll_init() as static in hvc/hvc_console.c because
 it is not used outside this file.
 
 This eliminates the following warning in hvc/hvc_console.c:
 drivers/tty/hvc/hvc_console.c:791:5: warning: no previous prototype for 
 ‘hvc_poll_init’ [-Wmissing-prototypes]
 
 Signed-off-by: Rashika Kheria rashika.khe...@gmail.com

Reviewed-by: Josh Triplett j...@joshtriplett.org

  drivers/tty/hvc/hvc_console.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c
 index 9eba119..50b4688 100644
 --- a/drivers/tty/hvc/hvc_console.c
 +++ b/drivers/tty/hvc/hvc_console.c
 @@ -788,7 +788,7 @@ static int hvc_tiocmset(struct tty_struct *tty,
  }
  
  #ifdef CONFIG_CONSOLE_POLL
 -int hvc_poll_init(struct tty_driver *driver, int line, char *options)
 +static int hvc_poll_init(struct tty_driver *driver, int line, char *options)
  {
   return 0;
  }
 -- 
 1.7.9.5
 
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH 2/2] drivers: tty: Mark the function hvc_poll_init() as static in hvc_console.c

2013-12-16 Thread Rashika Kheria 
Mark the function hvc_poll_init() as static in hvc/hvc_console.c because
it is not used outside this file.

This eliminates the following warning in hvc/hvc_console.c:
drivers/tty/hvc/hvc_console.c:791:5: warning: no previous prototype for 
‘hvc_poll_init’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria rashika.khe...@gmail.com
---
 drivers/tty/hvc/hvc_console.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c
index 9eba119..50b4688 100644
--- a/drivers/tty/hvc/hvc_console.c
+++ b/drivers/tty/hvc/hvc_console.c
@@ -788,7 +788,7 @@ static int hvc_tiocmset(struct tty_struct *tty,
 }
 
 #ifdef CONFIG_CONSOLE_POLL
-int hvc_poll_init(struct tty_driver *driver, int line, char *options)
+static int hvc_poll_init(struct tty_driver *driver, int line, char *options)
 {
return 0;
 }
-- 
1.7.9.5

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev