Re: [PATCH 2/2] mpc82xx: Embedded Planet EP8248E support

2008-01-21 Thread Sergej Stepanov 

Am Freitag, den 18.01.2008, 10:03 -0600 schrieb Scott Wood:
 On Fri, Jan 18, 2008 at 12:07:07PM +0100, Sergej Stepanov wrote:
  
   + /* Serial port/SCC1 */
   + scc1: [EMAIL PROTECTED] {
   + device_type = serial;
   + compatible = fsl,mpc8248-scc-uart,
   +  fsl,cpm2-scc-uart;
   + reg = 0x11a00 0x20 0x8000 0x100;
   + interrupts = 40 8;
  are you sure with 40 as interrupt? has not it be 28(hex) here?
 
 This is a version 1 dts file -- the default base is decimal.
 
 -Scott
yes, you are right, sorry.

___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 2/2] mpc82xx: Embedded Planet EP8248E support

2008-01-21 Thread Kumar Gala 
On Thu, 17 Jan 2008, Scott Wood wrote:

 This board is also resold by Freescale under the names
 QUICCStart MPC8248 Evaluation System and CWH-PPC-8248N-VE.

 Signed-off-by: Scott Wood [EMAIL PROTECTED]
 ---
 Removed const/initdata combo, and used simple-bus for probing.

 Please apply for 2.6.25.

  arch/powerpc/boot/Makefile |3 +-
  arch/powerpc/boot/dts/ep8248e.dts  |  207 
  arch/powerpc/boot/ep8248e.c|   55 +++
  arch/powerpc/boot/wrapper  |2 +-
  arch/powerpc/configs/ep8248e_defconfig |  821 
 
  arch/powerpc/platforms/82xx/Kconfig|   13 +
  arch/powerpc/platforms/82xx/Makefile   |1 +
  arch/powerpc/platforms/82xx/ep8248e.c  |  324 +
  include/asm-powerpc/mpc8260.h  |1 +
  9 files changed, 1425 insertions(+), 2 deletions(-)
  create mode 100644 arch/powerpc/boot/dts/ep8248e.dts
  create mode 100644 arch/powerpc/boot/ep8248e.c
  create mode 100644 arch/powerpc/configs/ep8248e_defconfig
  create mode 100644 arch/powerpc/platforms/82xx/ep8248e.c


applied.

- k
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 2/2] mpc82xx: Embedded Planet EP8248E support

2008-01-18 Thread Scott Wood 
On Fri, Jan 18, 2008 at 12:07:07PM +0100, Sergej Stepanov wrote:
 
  +   /* Serial port/SCC1 */
  +   scc1: [EMAIL PROTECTED] {
  +   device_type = serial;
  +   compatible = fsl,mpc8248-scc-uart,
  +fsl,cpm2-scc-uart;
  +   reg = 0x11a00 0x20 0x8000 0x100;
  +   interrupts = 40 8;
 are you sure with 40 as interrupt? has not it be 28(hex) here?

This is a version 1 dts file -- the default base is decimal.

-Scott
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH 2/2] mpc82xx: Embedded Planet EP8248E support

2008-01-17 Thread Scott Wood 
This board is also resold by Freescale under the names
QUICCStart MPC8248 Evaluation System and CWH-PPC-8248N-VE.

Signed-off-by: Scott Wood [EMAIL PROTECTED]
---
Removed const/initdata combo, and used simple-bus for probing.

Please apply for 2.6.25.

 arch/powerpc/boot/Makefile |3 +-
 arch/powerpc/boot/dts/ep8248e.dts  |  207 
 arch/powerpc/boot/ep8248e.c|   55 +++
 arch/powerpc/boot/wrapper  |2 +-
 arch/powerpc/configs/ep8248e_defconfig |  821 
 arch/powerpc/platforms/82xx/Kconfig|   13 +
 arch/powerpc/platforms/82xx/Makefile   |1 +
 arch/powerpc/platforms/82xx/ep8248e.c  |  324 +
 include/asm-powerpc/mpc8260.h  |1 +
 9 files changed, 1425 insertions(+), 2 deletions(-)
 create mode 100644 arch/powerpc/boot/dts/ep8248e.dts
 create mode 100644 arch/powerpc/boot/ep8248e.c
 create mode 100644 arch/powerpc/configs/ep8248e_defconfig
 create mode 100644 arch/powerpc/platforms/82xx/ep8248e.c

diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
index 08bf7aa..fcca455 100644
--- a/arch/powerpc/boot/Makefile
+++ b/arch/powerpc/boot/Makefile
@@ -62,7 +62,7 @@ src-plat := of.c cuboot-52xx.c cuboot-83xx.c cuboot-85xx.c 
holly.c \
ps3-head.S ps3-hvcall.S ps3.c treeboot-bamboo.c cuboot-8xx.c \
cuboot-pq2.c cuboot-sequoia.c treeboot-walnut.c cuboot-bamboo.c 
\
fixed-head.S ep88xc.c cuboot-hpc2.c ep405.c cuboot-taishan.c \
-   cuboot-katmai.c cuboot-rainier.c redboot-8xx.c
+   cuboot-katmai.c cuboot-rainier.c redboot-8xx.c ep8248e.c
 src-boot := $(src-wlib) $(src-plat) empty.c
 
 src-boot := $(addprefix $(obj)/, $(src-boot))
@@ -195,6 +195,7 @@ image-$(CONFIG_PPC_8xx) += cuImage.8xx
 image-$(CONFIG_PPC_EP88XC) += zImage.ep88xc
 image-$(CONFIG_EP405)  += zImage.ep405
 image-$(CONFIG_8260)   += cuImage.pq2
+image-$(CONFIG_EP8248E)+= zImage.ep8248e
 image-$(CONFIG_PPC_MPC52xx)+= cuImage.52xx
 image-$(CONFIG_PPC_83xx)   += cuImage.83xx
 image-$(CONFIG_PPC_85xx)   += cuImage.85xx
diff --git a/arch/powerpc/boot/dts/ep8248e.dts 
b/arch/powerpc/boot/dts/ep8248e.dts
new file mode 100644
index 000..5d2fb76
--- /dev/null
+++ b/arch/powerpc/boot/dts/ep8248e.dts
@@ -0,0 +1,207 @@
+/*
+ * Device Tree for the Embedded Planet EP8248E board running PlanetCore.
+ *
+ * Copyright 2007 Freescale Semiconductor Inc.
+ *
+ * This program is free software; you can redistribute  it and/or modify it
+ * under  the terms of  the GNU General  Public License as published by the
+ * Free Software Foundation;  either version 2 of the  License, or (at your
+ * option) any later version.
+ */
+
+/dts-v1/;
+/ {
+   model = EP8248E;
+   compatible = fsl,ep8248e;
+   #address-cells = 1;
+   #size-cells = 1;
+
+   aliases {
+   planetcore-SMC1 = smc1;
+   planetcore-SCC1 = scc1;
+   ethernet0 = eth0;
+   ethernet1 = eth1;
+   serial0 = smc1;
+   serial1 = scc1;
+   };
+
+   cpus {
+   #address-cells = 1;
+   #size-cells = 0;
+
+   PowerPC,[EMAIL PROTECTED] {
+   device_type = cpu;
+   reg = 0;
+   d-cache-line-size = 32;
+   i-cache-line-size = 32;
+   d-cache-size = 16384;
+   i-cache-size = 16384;
+   timebase-frequency = 0;
+   clock-frequency = 0;
+   };
+   };
+
+   [EMAIL PROTECTED] {
+   compatible = fsl,mpc8248-localbus,
+fsl,pq2-localbus,
+simple-bus;
+   #address-cells = 2;
+   #size-cells = 1;
+   reg = 0xf0010100 0x40;
+
+   ranges = 0 0 0xfc00 0x0400
+ 1 0 0xfa00 0x8000;
+
+   [EMAIL PROTECTED],380 {
+   compatible = cfi-flash;
+   reg = 0 0x380 0x80;
+   bank-width = 4;
+   device-width = 2;
+   };
+
+   [EMAIL PROTECTED],0 {
+   #address-cells = 2;
+   #size-cells = 1;
+   reg = 1 0 0x10;
+   compatible = fsl,ep8248e-bcsr;
+   ranges;
+
+   mdio {
+   device_type = mdio;
+   compatible = fsl,ep8248e-mdio-bitbang;
+   #address-cells = 1;
+   #size-cells = 0;
+   reg = 1 8 1;
+
+   PHY0: [EMAIL PROTECTED] {
+

[PATCH 2/2] mpc82xx: Embedded Planet EP8248E support

2008-01-15 Thread Scott Wood 
This board is also resold by Freescale under the names
QUICCStart MPC8248 Evaluation System and CWH-PPC-8248N-VE.

Signed-off-by: Scott Wood [EMAIL PROTECTED]
---
 arch/powerpc/boot/Makefile |3 +-
 arch/powerpc/boot/dts/ep8248e.dts  |  205 
 arch/powerpc/boot/ep8248e.c|   55 +++
 arch/powerpc/boot/wrapper  |2 +-
 arch/powerpc/configs/ep8248e_defconfig |  821 
 arch/powerpc/platforms/82xx/Kconfig|   13 +
 arch/powerpc/platforms/82xx/Makefile   |1 +
 arch/powerpc/platforms/82xx/ep8248e.c  |  326 +
 include/asm-powerpc/mpc8260.h  |1 +
 9 files changed, 1425 insertions(+), 2 deletions(-)
 create mode 100644 arch/powerpc/boot/dts/ep8248e.dts
 create mode 100644 arch/powerpc/boot/ep8248e.c
 create mode 100644 arch/powerpc/configs/ep8248e_defconfig
 create mode 100644 arch/powerpc/platforms/82xx/ep8248e.c

diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
index 08bf7aa..fcca455 100644
--- a/arch/powerpc/boot/Makefile
+++ b/arch/powerpc/boot/Makefile
@@ -62,7 +62,7 @@ src-plat := of.c cuboot-52xx.c cuboot-83xx.c cuboot-85xx.c 
holly.c \
ps3-head.S ps3-hvcall.S ps3.c treeboot-bamboo.c cuboot-8xx.c \
cuboot-pq2.c cuboot-sequoia.c treeboot-walnut.c cuboot-bamboo.c 
\
fixed-head.S ep88xc.c cuboot-hpc2.c ep405.c cuboot-taishan.c \
-   cuboot-katmai.c cuboot-rainier.c redboot-8xx.c
+   cuboot-katmai.c cuboot-rainier.c redboot-8xx.c ep8248e.c
 src-boot := $(src-wlib) $(src-plat) empty.c
 
 src-boot := $(addprefix $(obj)/, $(src-boot))
@@ -195,6 +195,7 @@ image-$(CONFIG_PPC_8xx) += cuImage.8xx
 image-$(CONFIG_PPC_EP88XC) += zImage.ep88xc
 image-$(CONFIG_EP405)  += zImage.ep405
 image-$(CONFIG_8260)   += cuImage.pq2
+image-$(CONFIG_EP8248E)+= zImage.ep8248e
 image-$(CONFIG_PPC_MPC52xx)+= cuImage.52xx
 image-$(CONFIG_PPC_83xx)   += cuImage.83xx
 image-$(CONFIG_PPC_85xx)   += cuImage.85xx
diff --git a/arch/powerpc/boot/dts/ep8248e.dts 
b/arch/powerpc/boot/dts/ep8248e.dts
new file mode 100644
index 000..9b8b258
--- /dev/null
+++ b/arch/powerpc/boot/dts/ep8248e.dts
@@ -0,0 +1,205 @@
+/*
+ * Device Tree for the Embedded Planet EP8248E board running PlanetCore.
+ *
+ * Copyright 2007 Freescale Semiconductor Inc.
+ *
+ * This program is free software; you can redistribute  it and/or modify it
+ * under  the terms of  the GNU General  Public License as published by the
+ * Free Software Foundation;  either version 2 of the  License, or (at your
+ * option) any later version.
+ */
+
+/dts-v1/;
+/ {
+   model = EP8248E;
+   compatible = fsl,ep8248e;
+   #address-cells = 1;
+   #size-cells = 1;
+
+   aliases {
+   planetcore-SMC1 = smc1;
+   planetcore-SCC1 = scc1;
+   ethernet0 = eth0;
+   ethernet1 = eth1;
+   serial0 = smc1;
+   serial1 = scc1;
+   };
+
+   cpus {
+   #address-cells = 1;
+   #size-cells = 0;
+
+   PowerPC,[EMAIL PROTECTED] {
+   device_type = cpu;
+   reg = 0;
+   d-cache-line-size = 32;
+   i-cache-line-size = 32;
+   d-cache-size = 16384;
+   i-cache-size = 16384;
+   timebase-frequency = 0;
+   clock-frequency = 0;
+   };
+   };
+
+   localbus {
+   compatible = fsl,mpc8248-localbus,
+fsl,pq2-localbus,
+simple-bus;
+   #address-cells = 2;
+   #size-cells = 1;
+   reg = 0xf0010100 0x40;
+
+   ranges = 0 0 0xfc00 0x0400
+ 1 0 0xfa00 0x8000;
+
+   [EMAIL PROTECTED],380 {
+   compatible = cfi-flash;
+   reg = 0 0x380 0x80;
+   bank-width = 4;
+   device-width = 2;
+   };
+
+   [EMAIL PROTECTED],0 {
+   #address-cells = 2;
+   #size-cells = 1;
+   reg = 1 0 0x10;
+   compatible = fsl,ep8248e-bcsr;
+   ranges;
+
+   mdio {
+   device_type = mdio;
+   compatible = fsl,ep8248e-mdio-bitbang;
+   #address-cells = 1;
+   #size-cells = 0;
+   reg = 1 8 1;
+
+   PHY0: [EMAIL PROTECTED] {
+   interrupt-parent = PIC;
+   reg = 0;
+

Re: [PATCH 2/2] mpc82xx: Embedded Planet EP8248E support

2008-01-15 Thread Stephen Rothwell 
Hi Scott,

On Tue, 15 Jan 2008 17:30:47 -0600 Scott Wood [EMAIL PROTECTED] wrote:

 +++ b/arch/powerpc/platforms/82xx/ep8248e.c

 +static __initdata const struct cpm_pin ep8248e_pins[] = {

Again, const doesn't mix with __initdata so just use __initdata.

 +static  __initdata const struct of_device_id of_bus_ids[] = {

Here as well.

-- 
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/


pgp21hBoyeTYM.pgp
Description: PGP signature
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev