Re: [PATCH 2/2] powerpc/config: enable mdio buses muxing via Memory-mapped device
Hello Shao-Hui, On 01/03/2015 10:58 PM, Xie Shaohui-B21989 wrote: Hello Emil, The patches sent by Shruti were marked as Changes Requested over 5 months. to me if the patches do need changes, the possible changes seems not in 'config' but in corenet_generic.c. It was part of a series that needed changes in other patches I'm not sure if it's OK to add some compatibles in corenet_generic.c. if we can use the existing compatible simple-bus, Then we will only need to enable MDIO mux option in config without adding compatible in corenet_generic.c. The container bus of the muxing nodes doesn't carry the simple-bus compatible and (as per the ePAPR definition) I'm unsure it would be applicable Cheers, Best Regards, Shaohui Xie -Original Message- From: Emil Medve [mailto:emilian.me...@freescale.com] Sent: Friday, January 02, 2015 4:43 PM To: shh@gmail.com; linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421 Cc: Andy Fleming; Xie Shaohui-B21989; Kanetkar Shruti-B44454 Subject: Re: [PATCH 2/2] powerpc/config: enable mdio buses muxing via Memory-mapped device Hello Shao-Hui, On 12/22/2014 03:21 AM, shh@gmail.com wrote: From: Andy Fleming aflem...@gmail.com Signed-off-by: Andy Fleming aflem...@gmail.com Signed-off-by: Shaohui Xie shaohui@freescale.com --- arch/powerpc/configs/corenet32_smp_defconfig | 1 + arch/powerpc/configs/corenet64_smp_defconfig | 1 + 2 files changed, 2 insertions(+) Shruti submitted a more complete version of this patch here: http://patchwork.ozlabs.org/patch/370873 We should stick with that version Cheers, ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
RE: [PATCH 2/2] powerpc/config: enable mdio buses muxing via Memory-mapped device
-Original Message- From: Emil Medve [mailto:emilian.me...@freescale.com] Sent: Monday, January 05, 2015 5:29 PM To: Xie Shaohui-B21989; linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421 Cc: Andy Fleming; Kanetkar Shruti-B44454 Subject: Re: [PATCH 2/2] powerpc/config: enable mdio buses muxing via Memory-mapped device Hello Shao-Hui, On 01/03/2015 10:58 PM, Xie Shaohui-B21989 wrote: Hello Emil, The patches sent by Shruti were marked as Changes Requested over 5 months. to me if the patches do need changes, the possible changes seems not in 'config' but in corenet_generic.c. It was part of a series that needed changes in other patches [S.H] So the patch itself has no issue? if that is the case maybe the patch can be sent Individually since it does not depend on others? I'm not sure if it's OK to add some compatibles in corenet_generic.c. if we can use the existing compatible simple-bus, Then we will only need to enable MDIO mux option in config without adding compatible in corenet_generic.c. The container bus of the muxing nodes doesn't carry the simple-bus compatible and (as per the ePAPR definition) I'm unsure it would be applicable [S.H] I'm not sure if the simple-bus can be used as an extension of MDIO mux compatible. I was thinking another option, if simple-bus is not suitable here, then forget it.:) Thanks! Shaohui -Original Message- From: Emil Medve [mailto:emilian.me...@freescale.com] Sent: Friday, January 02, 2015 4:43 PM To: shh@gmail.com; linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421 Cc: Andy Fleming; Xie Shaohui-B21989; Kanetkar Shruti-B44454 Subject: Re: [PATCH 2/2] powerpc/config: enable mdio buses muxing via Memory-mapped device Hello Shao-Hui, On 12/22/2014 03:21 AM, shh@gmail.com wrote: From: Andy Fleming aflem...@gmail.com Signed-off-by: Andy Fleming aflem...@gmail.com Signed-off-by: Shaohui Xie shaohui@freescale.com --- arch/powerpc/configs/corenet32_smp_defconfig | 1 + arch/powerpc/configs/corenet64_smp_defconfig | 1 + 2 files changed, 2 insertions(+) Shruti submitted a more complete version of this patch here: http://patchwork.ozlabs.org/patch/370873 We should stick with that version Cheers, ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
RE: [PATCH 2/2] powerpc/config: enable mdio buses muxing via Memory-mapped device
Hello Emil, The patches sent by Shruti were marked as Changes Requested over 5 months. to me if the patches do need changes, the possible changes seems not in 'config' but in corenet_generic.c. I'm not sure if it's OK to add some compatibles in corenet_generic.c. if we can use the existing compatible simple-bus, Then we will only need to enable MDIO mux option in config without adding compatible in corenet_generic.c. Best Regards, Shaohui Xie -Original Message- From: Emil Medve [mailto:emilian.me...@freescale.com] Sent: Friday, January 02, 2015 4:43 PM To: shh@gmail.com; linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421 Cc: Andy Fleming; Xie Shaohui-B21989; Kanetkar Shruti-B44454 Subject: Re: [PATCH 2/2] powerpc/config: enable mdio buses muxing via Memory-mapped device Hello Shao-Hui, On 12/22/2014 03:21 AM, shh@gmail.com wrote: From: Andy Fleming aflem...@gmail.com Signed-off-by: Andy Fleming aflem...@gmail.com Signed-off-by: Shaohui Xie shaohui@freescale.com --- arch/powerpc/configs/corenet32_smp_defconfig | 1 + arch/powerpc/configs/corenet64_smp_defconfig | 1 + 2 files changed, 2 insertions(+) Shruti submitted a more complete version of this patch here: http://patchwork.ozlabs.org/patch/370873 We should stick with that version Cheers, ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 2/2] powerpc/config: enable mdio buses muxing via Memory-mapped device
Hello Shao-Hui, On 12/22/2014 03:21 AM, shh@gmail.com wrote: From: Andy Fleming aflem...@gmail.com Signed-off-by: Andy Fleming aflem...@gmail.com Signed-off-by: Shaohui Xie shaohui@freescale.com --- arch/powerpc/configs/corenet32_smp_defconfig | 1 + arch/powerpc/configs/corenet64_smp_defconfig | 1 + 2 files changed, 2 insertions(+) Shruti submitted a more complete version of this patch here: http://patchwork.ozlabs.org/patch/370873 We should stick with that version Cheers, ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
[PATCH 2/2] powerpc/config: enable mdio buses muxing via Memory-mapped device
From: Andy Fleming aflem...@gmail.com Signed-off-by: Andy Fleming aflem...@gmail.com Signed-off-by: Shaohui Xie shaohui@freescale.com --- arch/powerpc/configs/corenet32_smp_defconfig | 1 + arch/powerpc/configs/corenet64_smp_defconfig | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/powerpc/configs/corenet32_smp_defconfig b/arch/powerpc/configs/corenet32_smp_defconfig index 7525835..6577c41 100644 --- a/arch/powerpc/configs/corenet32_smp_defconfig +++ b/arch/powerpc/configs/corenet32_smp_defconfig @@ -105,6 +105,7 @@ CONFIG_AT803X_PHY=y CONFIG_FIXED_PHY=y CONFIG_MDIO_BUS_MUX=y CONFIG_MDIO_BUS_MUX_GPIO=y +CONFIG_MDIO_BUS_MUX_MMIOREG=y # CONFIG_INPUT_MOUSEDEV is not set # CONFIG_INPUT_KEYBOARD is not set # CONFIG_INPUT_MOUSE is not set diff --git a/arch/powerpc/configs/corenet64_smp_defconfig b/arch/powerpc/configs/corenet64_smp_defconfig index f915fe4..4016cf6 100644 --- a/arch/powerpc/configs/corenet64_smp_defconfig +++ b/arch/powerpc/configs/corenet64_smp_defconfig @@ -82,6 +82,7 @@ CONFIG_DUMMY=y CONFIG_E1000E=y CONFIG_MDIO_BUS_MUX=y CONFIG_MDIO_BUS_MUX_GPIO=y +CONFIG_MDIO_BUS_MUX_MMIOREG=y CONFIG_INPUT_FF_MEMLESS=m # CONFIG_INPUT_MOUSEDEV is not set # CONFIG_INPUT_KEYBOARD is not set -- 1.8.4.1 ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
