Re: [PATCH 29/60] microblaze_v4: traps support

[Paul Mundt]

On Thu, Jun 26, 2008 at 02:29:58PM +0200, [EMAIL PROTECTED] wrote:
> +static int kstack_depth_to_print = 24;
> +
x86 has a sysctl for this. It may be worth making this non-static and
generalizing the ifdef case. Plenty of other architectures could benefit
from this also.

> +void show_trace(struct task_struct *task, unsigned long *stack)
> +{
> + unsigned long addr;
> +
> + if (!stack)
> + stack = (unsigned long *)&stack;
> +
> + printk(KERN_INFO "Call Trace: ");
> +#ifdef CONFIG_KALLSYMS
> + printk(KERN_INFO "\n");
> +#endif
> + while (!kstack_end(stack)) {
> + addr = *stack++;
> + if (__kernel_text_address(addr)) {
> + printk(KERN_INFO "[<%08lx>] ", addr);
> + print_symbol("%s\n", addr);

Use print_ip_sym() here for future-proofing.

> + }
> + }
> + printk(KERN_INFO "\n");

And here you can:

if (!tsk)
tsk = current;

debug_show_held_locks(tsk);
> +}
> +

for when you get around to implementing lockdep.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH 29/60] microblaze_v4: traps support

[monstr]

From: Michal Simek <[EMAIL PROTECTED]>


Signed-off-by: Michal Simek <[EMAIL PROTECTED]>
---
 arch/microblaze/kernel/traps.c |   86 
 1 files changed, 86 insertions(+), 0 deletions(-)
 create mode 100644 arch/microblaze/kernel/traps.c

diff --git a/arch/microblaze/kernel/traps.c b/arch/microblaze/kernel/traps.c
new file mode 100644
index 000..69d75ee
--- /dev/null
+++ b/arch/microblaze/kernel/traps.c
@@ -0,0 +1,86 @@
+/*
+ * Copyright (C) 2006 Atmark Techno, Inc.
+ *
+ * This file is subject to the terms and conditions of the GNU General Public
+ * License. See the file "COPYING" in the main directory of this archive
+ * for more details.
+ */
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+
+void trap_init(void)
+{
+   initialize_exception_handlers();
+   __enable_hw_exceptions();
+}
+
+void __bad_xchg(volatile void *ptr, int size)
+{
+   printk(KERN_INFO "xchg: bad data size: pc 0x%p, ptr 0x%p, size %d\n",
+   __builtin_return_address(0), ptr, size);
+   BUG();
+}
+EXPORT_SYMBOL(__bad_xchg);
+
+static int kstack_depth_to_print = 24;
+
+void show_trace(struct task_struct *task, unsigned long *stack)
+{
+   unsigned long addr;
+
+   if (!stack)
+   stack = (unsigned long *)&stack;
+
+   printk(KERN_INFO "Call Trace: ");
+#ifdef CONFIG_KALLSYMS
+   printk(KERN_INFO "\n");
+#endif
+   while (!kstack_end(stack)) {
+   addr = *stack++;
+   if (__kernel_text_address(addr)) {
+   printk(KERN_INFO "[<%08lx>] ", addr);
+   print_symbol("%s\n", addr);
+   }
+   }
+   printk(KERN_INFO "\n");
+}
+
+void show_stack(struct task_struct *task, unsigned long *sp)
+{
+   unsigned long *stack;
+   int i;
+
+   if (sp == NULL) {
+   if (task)
+   sp = (unsigned long *) ((struct thread_info *)
+   (task->stack))->cpu_context.r1;
+   else
+   sp = (unsigned long *)&sp;
+   }
+
+   stack = sp;
+
+   printk(KERN_INFO "\nStack:\n  ");
+
+   for (i = 0; i < kstack_depth_to_print; i++) {
+   if (kstack_end(sp))
+   break;
+   if (i && ((i % 8) == 0))
+   printk("\n  ");
+   printk("%08lx ", *sp++);
+   }
+   printk("\n");
+   show_trace(task, stack);
+}
+
+void dump_stack(void)
+{
+   show_stack(NULL, NULL);
+}
+EXPORT_SYMBOL(dump_stack);
-- 
1.5.4.GIT

___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev