Re: [PATCH 3/3] PCI/AER: Use explicit register sizes for struct members

[Jonathan Cameron]

On Wed,  6 Dec 2023 16:42:31 -0600
Bjorn Helgaas  wrote:

> From: Bjorn Helgaas 
> 
> aer_irq() reads the AER Root Error Status and Error Source Identification
> (PCI_ERR_ROOT_STATUS and PCI_ERR_ROOT_ERR_SRC) registers directly into
> struct aer_err_source.  Both registers are 32 bits, so declare the members
> explicitly as "u32" instead of "unsigned int".
> 
> Similarly, aer_get_device_error_info() reads the AER Header Log
> (PCI_ERR_HEADER_LOG) registers, which are also 32 bits, into struct
> aer_header_log_regs.  Declare those members as "u32" as well.
> 
> No functional changes intended.
> 
> Signed-off-by: Bjorn Helgaas 

Another sensible cleanup. FWIW on such simple patches
Reviewed-by: Jonathan Cameron 

[PATCH 3/3] PCI/AER: Use explicit register sizes for struct members

[Bjorn Helgaas]

From: Bjorn Helgaas 

aer_irq() reads the AER Root Error Status and Error Source Identification
(PCI_ERR_ROOT_STATUS and PCI_ERR_ROOT_ERR_SRC) registers directly into
struct aer_err_source.  Both registers are 32 bits, so declare the members
explicitly as "u32" instead of "unsigned int".

Similarly, aer_get_device_error_info() reads the AER Header Log
(PCI_ERR_HEADER_LOG) registers, which are also 32 bits, into struct
aer_header_log_regs.  Declare those members as "u32" as well.

No functional changes intended.

Signed-off-by: Bjorn Helgaas 
---
 drivers/pci/pcie/aer.c | 4 ++--
 include/linux/aer.h| 8 
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
index 2ff6bac9979f..60f84414ec2a 100644
--- a/drivers/pci/pcie/aer.c
+++ b/drivers/pci/pcie/aer.c
@@ -41,8 +41,8 @@
 #define AER_MAX_TYPEOF_UNCOR_ERRS  27  /* as per PCI_ERR_UNCOR_STATUS*/
 
 struct aer_err_source {
-   unsigned int status;
-   unsigned int id;
+   u32 status; /* PCI_ERR_ROOT_STATUS */
+   u32 id; /* PCI_ERR_ROOT_ERR_SRC */
 };
 
 struct aer_rpc {
diff --git a/include/linux/aer.h b/include/linux/aer.h
index f6ea2f57d808..ae0fae70d4bd 100644
--- a/include/linux/aer.h
+++ b/include/linux/aer.h
@@ -19,10 +19,10 @@
 struct pci_dev;
 
 struct aer_header_log_regs {
-   unsigned int dw0;
-   unsigned int dw1;
-   unsigned int dw2;
-   unsigned int dw3;
+   u32 dw0;
+   u32 dw1;
+   u32 dw2;
+   u32 dw3;
 };
 
 struct aer_capability_regs {
-- 
2.34.1