Re: [PATCH 3/7] i2c/rtc-ds3232: Fix irq for probing

[Scott Wood]

On Fri, 2013-09-06 at 08:43 -0700, York Sun wrote:
 Driver shouldn't request irq when irq = 0. It is returned from parsing
 device tree. 0 means no interrupt.
 
 Signed-off-by: York Sun york...@freescale.com
 Reviewed-by: Zang Tiefei-R61911 tie-fei.z...@freescale.com
 Reviewed-by: Fleming Andrew-AFLEMING aflem...@freescale.com
 Tested-by: Fleming Andrew-AFLEMING aflem...@freescale.com
 ---
  drivers/rtc/rtc-ds3232.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

This should go via the i2c list and maintainer.  It's not a PPC patch at
all.

Please do not lump unrelated patches into a single patchset.

-Scott



___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH 3/7] i2c/rtc-ds3232: Fix irq for probing

[York Sun]

Driver shouldn't request irq when irq = 0. It is returned from parsing
device tree. 0 means no interrupt.

Signed-off-by: York Sun york...@freescale.com
Reviewed-by: Zang Tiefei-R61911 tie-fei.z...@freescale.com
Reviewed-by: Fleming Andrew-AFLEMING aflem...@freescale.com
Tested-by: Fleming Andrew-AFLEMING aflem...@freescale.com
---
 drivers/rtc/rtc-ds3232.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-ds3232.c b/drivers/rtc/rtc-ds3232.c
index b83bb5a5..ae8a28e 100644
--- a/drivers/rtc/rtc-ds3232.c
+++ b/drivers/rtc/rtc-ds3232.c
@@ -418,7 +418,7 @@ static int ds3232_probe(struct i2c_client *client,
return PTR_ERR(ds3232-rtc);
}
 
-   if (client-irq = 0) {
+   if (client-irq  0) {
ret = devm_request_irq(client-dev, client-irq, ds3232_irq, 0,
 ds3232, client);
if (ret) {
-- 
1.7.9.5


___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev