Re: [PATCH 4/8] PCI/hotplug: Needn't remove EEH cache again

2013-07-05 Thread Bjorn Helgaas
On Thu, Jul 4, 2013 at 8:57 PM, Gavin Shan sha...@linux.vnet.ibm.com wrote:
 Since pci_stop_and_remove_bus_device() has removed the EEH cache,
 we needn't do that again.

 Cc: Bjorn Helgaas bhelg...@google.com
 Cc: linux-...@vger.kernel.org
 Signed-off-by: Gavin Shan sha...@linux.vnet.ibm.com

Acked-by: Bjorn Helgaas bhelg...@google.com

Please merge this along with the rest of your series via whatever tree
you choose.

 ---
  drivers/pci/hotplug/rpadlpar_core.c |1 -
  1 files changed, 0 insertions(+), 1 deletions(-)

 diff --git a/drivers/pci/hotplug/rpadlpar_core.c 
 b/drivers/pci/hotplug/rpadlpar_core.c
 index b29e20b..bb7af78 100644
 --- a/drivers/pci/hotplug/rpadlpar_core.c
 +++ b/drivers/pci/hotplug/rpadlpar_core.c
 @@ -388,7 +388,6 @@ int dlpar_remove_pci_slot(char *drc_name, struct 
 device_node *dn)
 /* Remove the EADS bridge device itself */
 BUG_ON(!bus-self);
 pr_debug(PCI: Now removing bridge device %s\n, pci_name(bus-self));
 -   eeh_remove_bus_device(bus-self, true);
 pci_stop_and_remove_bus_device(bus-self);

 return 0;
 --
 1.7.5.4

 --
 To unsubscribe from this list: send the line unsubscribe linux-pci in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


[PATCH 4/8] PCI/hotplug: Needn't remove EEH cache again

2013-07-04 Thread Gavin Shan
Since pci_stop_and_remove_bus_device() has removed the EEH cache,
we needn't do that again.

Cc: Bjorn Helgaas bhelg...@google.com
Cc: linux-...@vger.kernel.org
Signed-off-by: Gavin Shan sha...@linux.vnet.ibm.com
---
 drivers/pci/hotplug/rpadlpar_core.c |1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/pci/hotplug/rpadlpar_core.c 
b/drivers/pci/hotplug/rpadlpar_core.c
index b29e20b..bb7af78 100644
--- a/drivers/pci/hotplug/rpadlpar_core.c
+++ b/drivers/pci/hotplug/rpadlpar_core.c
@@ -388,7 +388,6 @@ int dlpar_remove_pci_slot(char *drc_name, struct 
device_node *dn)
/* Remove the EADS bridge device itself */
BUG_ON(!bus-self);
pr_debug(PCI: Now removing bridge device %s\n, pci_name(bus-self));
-   eeh_remove_bus_device(bus-self, true);
pci_stop_and_remove_bus_device(bus-self);
 
return 0;
-- 
1.7.5.4

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev