RE: [PATCH V3] QorIQ/TMU: add TMU node to device tree for QorIQ T1040

2015-07-09 Thread Hongtao Jia
Hi Scott,

Patch updated to V3, please help to review.
Thanks.

---
Best Regards,
Hongtao

 -Original Message-
 From: Jia Hongtao [mailto:hongtao@freescale.com]
 Sent: Thursday, June 11, 2015 3:53 PM
 To: Wood Scott-B07421
 Cc: linuxppc-dev@lists.ozlabs.org; devicet...@vger.kernel.org;
 robh...@kernel.org; edubez...@gmail.com; Jia Hongtao-B38951
 Subject: [PATCH V3] QorIQ/TMU: add TMU node to device tree for QorIQ
 T1040
 
 This is Thermal Monitoring Unit for QorIQ platform.
 
 Signed-off-by: Jia Hongtao hongtao@freescale.com
 ---
 Changes of V3:
 * Put TMU node directly into t1040si-post.dtsi file.
 * Add fsl,tmu-range property.
 * Change calibration property to fsl,tmu-calibration.
 * Update the calibration data.
 
 Changes of V2:
 * Provide more details on compatible and calibration properties.
 
  .../devicetree/bindings/thermal/qoriq-thermal.txt  | 63
 ++
  arch/powerpc/boot/dts/fsl/t1040si-post.dtsi| 42 +++
  2 files changed, 105 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/thermal/qoriq-
 thermal.txt
 
 diff --git a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
 b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
 new file mode 100644
 index 000..2bc9cb3
 --- /dev/null
 +++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
 @@ -0,0 +1,63 @@
 +* Thermal Monitoring Unit (TMU) on Freescale QorIQ SoCs
 +
 +Required properties:
 +- compatible : Must include fsl,qoriq-tmu. The version of the device
 is
 + determined by the TMU IP Block Revision Register (IPBRR0) at
 + offset 0x0BF8.
 + Table of correspondences between IPBRR0 values and example  chips:
 + Value   Device
 + --  -
 + 0x01900102  T1040
 +- reg : Address range of TMU registers.
 +- interrupts : Contains the interrupt for TMU.
 +- fsl,tmu-range : Temperature range for TMU. Including the starting
 + temperature and number of calibration points for each range.
 +- fsl,tmu-calibration : Calibration table for TMU. This is required to
 + determine what a specific sensor reading translates to in degrees
 + Celsius. There are four calibration ranges, for each range we need
 + a couple of calibration data formatted like TTCFGR, TSCFGR.
 + Freescale provides the data required.
 +
 +Example:
 +
 +tmu@f {
 + compatible = fsl,qoriq-tmu;
 + reg = 0xf 0x1000;
 + interrupts = 18 2 0 0;
 + fsl,tmu-range = 0x000a 0x00090026 0x0008004a 0x0001006a;
 + fsl,tmu-calibration = 0x 0x0025
 +0x0001 0x0028
 +0x0002 0x002d
 +0x0003 0x0031
 +0x0004 0x0036
 +0x0005 0x003a
 +0x0006 0x0040
 +0x0007 0x0044
 +0x0008 0x004a
 +0x0009 0x004f
 +0x000a 0x0054
 +
 +0x0001 0x000d
 +0x00010001 0x0013
 +0x00010002 0x0019
 +0x00010003 0x001f
 +0x00010004 0x0025
 +0x00010005 0x002d
 +0x00010006 0x0033
 +0x00010007 0x0043
 +0x00010008 0x004b
 +0x00010009 0x0053
 +
 +0x0002 0x0010
 +0x00020001 0x0017
 +0x00020002 0x001f
 +0x00020003 0x0029
 +0x00020004 0x0031
 +0x00020005 0x003c
 +0x00020006 0x0042
 +0x00020007 0x004d
 +0x00020008 0x0056
 +
 +0x0003 0x0012
 +0x00030001 0x001d;
 +};
 diff --git a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
 b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
 index 5cc01be..6d9ca4d 100644
 --- a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
 +++ b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
 @@ -407,6 +407,48 @@
   reg= 0xea000 0x4000;
   };
 
 + tmu@f {
 + compatible = fsl,qoriq-tmu;
 + reg = 0xf 0x1000;
 + interrupts = 18 2 0 0;
 + fsl,tmu-range = 0x000a 0x00090026 0x0008004a 0x0001006a;
 + fsl,tmu-calibration = 0x 0x0025
 +0x0001 0x0028
 +0x0002 0x002d

Re: [PATCH V3] QorIQ/TMU: add TMU node to device tree for QorIQ T1040

2015-07-09 Thread Scott Wood
On Thu, 2015-07-09 at 03:00 -0500, Jia Hongtao-B38951 wrote:
 Hi Scott,
 
 Patch updated to V3, please help to review.
 Thanks.
 
 ---
 Best Regards,
 Hongtao

It looks OK.

-Scott


___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH V3] QorIQ/TMU: add TMU node to device tree for QorIQ T1040

2015-06-11 Thread Jia Hongtao
This is Thermal Monitoring Unit for QorIQ platform.

Signed-off-by: Jia Hongtao hongtao@freescale.com
---
Changes of V3:
* Put TMU node directly into t1040si-post.dtsi file.
* Add fsl,tmu-range property.
* Change calibration property to fsl,tmu-calibration.
* Update the calibration data.

Changes of V2:
* Provide more details on compatible and calibration properties.

 .../devicetree/bindings/thermal/qoriq-thermal.txt  | 63 ++
 arch/powerpc/boot/dts/fsl/t1040si-post.dtsi| 42 +++
 2 files changed, 105 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/thermal/qoriq-thermal.txt

diff --git a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt 
b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
new file mode 100644
index 000..2bc9cb3
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
@@ -0,0 +1,63 @@
+* Thermal Monitoring Unit (TMU) on Freescale QorIQ SoCs
+
+Required properties:
+- compatible : Must include fsl,qoriq-tmu. The version of the device is
+   determined by the TMU IP Block Revision Register (IPBRR0) at
+   offset 0x0BF8.
+   Table of correspondences between IPBRR0 values and example  chips:
+   Value   Device
+   --  -
+   0x01900102  T1040
+- reg : Address range of TMU registers.
+- interrupts : Contains the interrupt for TMU.
+- fsl,tmu-range : Temperature range for TMU. Including the starting
+   temperature and number of calibration points for each range.
+- fsl,tmu-calibration : Calibration table for TMU. This is required to
+   determine what a specific sensor reading translates to in degrees
+   Celsius. There are four calibration ranges, for each range we need
+   a couple of calibration data formatted like TTCFGR, TSCFGR.
+   Freescale provides the data required.
+
+Example:
+
+tmu@f {
+   compatible = fsl,qoriq-tmu;
+   reg = 0xf 0x1000;
+   interrupts = 18 2 0 0;
+   fsl,tmu-range = 0x000a 0x00090026 0x0008004a 0x0001006a;
+   fsl,tmu-calibration = 0x 0x0025
+  0x0001 0x0028
+  0x0002 0x002d
+  0x0003 0x0031
+  0x0004 0x0036
+  0x0005 0x003a
+  0x0006 0x0040
+  0x0007 0x0044
+  0x0008 0x004a
+  0x0009 0x004f
+  0x000a 0x0054
+
+  0x0001 0x000d
+  0x00010001 0x0013
+  0x00010002 0x0019
+  0x00010003 0x001f
+  0x00010004 0x0025
+  0x00010005 0x002d
+  0x00010006 0x0033
+  0x00010007 0x0043
+  0x00010008 0x004b
+  0x00010009 0x0053
+
+  0x0002 0x0010
+  0x00020001 0x0017
+  0x00020002 0x001f
+  0x00020003 0x0029
+  0x00020004 0x0031
+  0x00020005 0x003c
+  0x00020006 0x0042
+  0x00020007 0x004d
+  0x00020008 0x0056
+
+  0x0003 0x0012
+  0x00030001 0x001d;
+};
diff --git a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi 
b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
index 5cc01be..6d9ca4d 100644
--- a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
@@ -407,6 +407,48 @@
reg= 0xea000 0x4000;
};
 
+   tmu@f {
+   compatible = fsl,qoriq-tmu;
+   reg = 0xf 0x1000;
+   interrupts = 18 2 0 0;
+   fsl,tmu-range = 0x000a 0x00090026 0x0008004a 0x0001006a;
+   fsl,tmu-calibration = 0x 0x0025
+  0x0001 0x0028
+  0x0002 0x002d
+  0x0003 0x0031
+  0x0004 0x0036
+  0x0005 0x003a
+  0x0006 0x0040
+  0x0007 0x0044
+  0x0008 0x004a
+  0x0009 0x004f
+