Re: [PATCH V4 00/10] perf: New conditional branch filter
On Fri, 2013-12-06 at 10:18 -0300, Arnaldo Carvalho de Melo wrote: Em Thu, Dec 05, 2013 at 03:47:54PM +1100, Michael Ellerman escreveu: On Wed, 2013-12-04 at 16:02 +0530, Anshuman Khandual wrote: This patchset is the re-spin of the original branch stack sampling patchset which introduced new PERF_SAMPLE_BRANCH_COND branch filter. This patchset also enables SW based branch filtering support for book3s powerpc platforms which have PMU HW backed branch stack sampling support. Summary of code changes in this patchset: (1) Introduces a new PERF_SAMPLE_BRANCH_COND branch filter (2) Add the cond branch filter options in the perf record tool (3) Enable PERF_SAMPLE_BRANCH_COND in X86 platforms (4) Enable PERF_SAMPLE_BRANCH_COND in POWER8 platform (5) Update the documentation regarding perf record tool Hi Arnaldo, Can you please take just patches 1-5 into the perf tree? And do you mind putting them in a topic branch so Benh can merge that. This is mostly kernel code, I process the userspace ones, so I think either Ingo or PeterZ should pick these, Ingo, Peter? Urgh, sorry. MAINTAINERS just lists all of you in a block. Added PeterZ to CC. Peter/Ingo can you please take just patches 1-5 into the perf tree? And do you mind putting them in a topic branch so Benh can merge that. The generic x86 changes have a Reviewed-by from Stephane, and the change to tools/perf has an ack-of-sorts from Arnaldo: Only: Subject: [PATCH V4 03/10] perf, tool: Conditional branch filter 'cond' added to perf record Which is a one liner, touches tools/perf/, and I'm ok with it. cheers ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH V4 00/10] perf: New conditional branch filter
Em Thu, Dec 05, 2013 at 03:47:54PM +1100, Michael Ellerman escreveu: On Wed, 2013-12-04 at 16:02 +0530, Anshuman Khandual wrote: This patchset is the re-spin of the original branch stack sampling patchset which introduced new PERF_SAMPLE_BRANCH_COND branch filter. This patchset also enables SW based branch filtering support for book3s powerpc platforms which have PMU HW backed branch stack sampling support. Summary of code changes in this patchset: (1) Introduces a new PERF_SAMPLE_BRANCH_COND branch filter (2) Add the cond branch filter options in the perf record tool (3) Enable PERF_SAMPLE_BRANCH_COND in X86 platforms (4) Enable PERF_SAMPLE_BRANCH_COND in POWER8 platform (5) Update the documentation regarding perf record tool Hi Arnaldo, Can you please take just patches 1-5 into the perf tree? And do you mind putting them in a topic branch so Benh can merge that. This is mostly kernel code, I process the userspace ones, so I think either Ingo or PeterZ should pick these, Ingo, Peter? Only: Subject: [PATCH V4 03/10] perf, tool: Conditional branch filter 'cond' added to perf record Which is a one liner, touches tools/perf/, and I'm ok with it. - Arnaldo The remaining patches are powerpc specific and still need some more review. cheers ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
[PATCH V4 00/10] perf: New conditional branch filter
This patchset is the re-spin of the original branch stack sampling patchset which introduced new PERF_SAMPLE_BRANCH_COND branch filter. This patchset also enables SW based branch filtering support for book3s powerpc platforms which have PMU HW backed branch stack sampling support. Summary of code changes in this patchset: (1) Introduces a new PERF_SAMPLE_BRANCH_COND branch filter (2) Add the cond branch filter options in the perf record tool (3) Enable PERF_SAMPLE_BRANCH_COND in X86 platforms (4) Enable PERF_SAMPLE_BRANCH_COND in POWER8 platform (5) Update the documentation regarding perf record tool (6) Add some new powerpc instruction analysis functions in code-patching library (7) Enable SW based branch filter support for powerpc book3s (8) Changed BHRB configuration in POWER8 to accommodate SW branch filters With this new SW enablement, the branch filter support for book3s platforms have been extended to include all these combinations discussed below with a sample test application program (included here). Changes in V2 = (1) Enabled PPC64 SW branch filtering support (2) Incorporated changes required for all previous comments Changes in V3 = (1) Split the SW branch filter enablement into multiple patches (2) Added PMU neutral SW branch filtering code, PMU specific HW branch filtering code (3) Added new instruction analysis functionality into powerpc code-patching library (4) Changed name for some of the functions (5) Fixed couple of spelling mistakes (6) Changed code documentation in multiple places Changes in V4 = (1) Changed the commit message for patch (01/10) (2) Changed the patch (02/10) to accommodate review comments from Michael Ellerman (3) Rebased the patchset against latest Linus's tree PMU HW branch filters = (1) perf record -j any_call -e branch-misses:u ./cprog # Overhead Command Source Shared Object Source Symbol Target Shared Object Target Symbol # ... . # 7.00%cprog cprog [.] sw_3_1 cprog [.] sw_3_1_2 6.99%cprog cprog [.] hw_1_1 cprog [.] symbol1 6.52%cprog cprog [.] sw_3_1 cprog [.] success_3_1_2 5.41%cprog cprog [.] sw_3_1 cprog [.] sw_3_1_3 5.40%cprog cprog [.] hw_1_2 cprog [.] symbol2 5.40%cprog cprog [.] callme cprog [.] hw_1_2 5.40%cprog cprog [.] sw_3_1 cprog [.] success_3_1_1 5.40%cprog cprog [.] callme cprog [.] hw_1_1 5.39%cprog cprog [.] sw_3_1 cprog [.] sw_3_1_1 5.39%cprog cprog [.] sw_4_2 cprog [.] lr_addr 5.39%cprog cprog [.] callme cprog [.] sw_4_2 5.37%cprog [unknown] [.] cprog [.] ctr_addr 4.30%cprog cprog [.] callme cprog [.] hw_2_1 4.28%cprog cprog [.] callme cprog [.] sw_3_1 3.82%cprog cprog [.] sw_3_1 cprog [.] success_3_1_3 3.81%cprog cprog [.] callme cprog [.] hw_2_2 3.81%cprog cprog [.] callme cprog [.] sw_3_2 2.71%cprog [unknown] [.] cprog [.] lr_addr 2.70%cprog cprog [.] main cprog [.] callme 2.70%cprog cprog [.] sw_4_1 cprog [.] ctr_addr 2.70%cprog cprog [.] callme cprog [.] sw_4_1 0.08%cprog [unknown] [.] 0xf78676c4 [unknown] [.] 0xf78522c0 0.02%cprog [unknown] [k] cprog [k] ctr_addr 0.01%cprog [kernel.kallsyms] [.] .power_pmu_enable [kernel.kallsyms] [.] .power8_compute_mmcr 0.00%cprog ld-2.11.2.so [.] malloc [unknown] [.] 0xf786b380 0.00%cprog
Re: [PATCH V4 00/10] perf: New conditional branch filter
On Wed, 2013-12-04 at 16:02 +0530, Anshuman Khandual wrote: This patchset is the re-spin of the original branch stack sampling patchset which introduced new PERF_SAMPLE_BRANCH_COND branch filter. This patchset also enables SW based branch filtering support for book3s powerpc platforms which have PMU HW backed branch stack sampling support. Summary of code changes in this patchset: (1) Introduces a new PERF_SAMPLE_BRANCH_COND branch filter (2) Add the cond branch filter options in the perf record tool (3) Enable PERF_SAMPLE_BRANCH_COND in X86 platforms (4) Enable PERF_SAMPLE_BRANCH_COND in POWER8 platform (5) Update the documentation regarding perf record tool Hi Arnaldo, Can you please take just patches 1-5 into the perf tree? And do you mind putting them in a topic branch so Benh can merge that. The remaining patches are powerpc specific and still need some more review. cheers ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
