When passed a non-head list element, list_add_tail() actually adds the
new element to its left, which is what we want. Despite the slightly
confusing name, use the dedicated function which does the same thing as
the open-coded list_add(pos->prev).

Suggested-by: Jakub Kicinski <k...@kernel.org>
Signed-off-by: Jakob Koschel <jakobkosc...@gmail.com>
Signed-off-by: Vladimir Oltean <vladimir.olt...@nxp.com>
---
 drivers/net/dsa/sja1105/sja1105_vl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/sja1105/sja1105_vl.c 
b/drivers/net/dsa/sja1105/sja1105_vl.c
index e5ea8eb9ec4e..7fe9b18f1cbd 100644
--- a/drivers/net/dsa/sja1105/sja1105_vl.c
+++ b/drivers/net/dsa/sja1105/sja1105_vl.c
@@ -49,7 +49,7 @@ static int sja1105_insert_gate_entry(struct 
sja1105_gating_config *gating_cfg,
        e->rule = rule;
        e->gate_state = gate_state;
        e->interval = entry_time;
-       list_add(&e->list, pos->prev);
+       list_add_tail(&e->list, pos);
 
        gating_cfg->num_entries++;
 
-- 
2.25.1

Reply via email to