Re: [PATCH v19 01/13] kexec: Move ELF fields to struct kimage
Lakshmi Ramasubramanian writes:
> ELF related fields elf_headers, elf_headers_sz, and elf_load_addr are
> defined in architecture specific 'struct kimage_arch' for x86, powerpc,
> and arm64. The name of these fields are different in these
> architectures that makes it hard to have a common code for setting up
> the device tree for kexec system call.
>
> Move the ELF fields to 'struct kimage' defined in include/linux/kexec.h
> so common code can use it.
>
> Signed-off-by: Lakshmi Ramasubramanian
> Suggested-by: Rob Herring
> Fixes: 33488dc4d61f ("of: Add a common kexec FDT setup function")
This Fixes tag should be removed. It is referencing a patch from the
future (later in the series), and the commit id is meaningless.
> Reported-by: kernel test robot
> ---
> include/linux/kexec.h | 5 +
> 1 file changed, 5 insertions(+)
With that fixed:
Reviewed-by: Thiago Jung Bauermann
--
Thiago Jung Bauermann
IBM Linux Technology Center
[PATCH v19 01/13] kexec: Move ELF fields to struct kimage
ELF related fields elf_headers, elf_headers_sz, and elf_load_addr are
defined in architecture specific 'struct kimage_arch' for x86, powerpc,
and arm64. The name of these fields are different in these
architectures that makes it hard to have a common code for setting up
the device tree for kexec system call.
Move the ELF fields to 'struct kimage' defined in include/linux/kexec.h
so common code can use it.
Signed-off-by: Lakshmi Ramasubramanian
Suggested-by: Rob Herring
Fixes: 33488dc4d61f ("of: Add a common kexec FDT setup function")
Reported-by: kernel test robot
---
include/linux/kexec.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/linux/kexec.h b/include/linux/kexec.h
index 5f61389f5f36..0208fe8f8e42 100644
--- a/include/linux/kexec.h
+++ b/include/linux/kexec.h
@@ -305,6 +305,11 @@ struct kimage {
/* Virtual address of IMA measurement buffer for kexec syscall */
void *ima_buffer;
#endif
+
+ /* Core ELF header buffer */
+ void *elf_headers;
+ unsigned long elf_headers_sz;
+ unsigned long elf_load_addr;
};
/* kexec interface functions */
--
2.30.0
