Re: [PATCH v2] KVM: PPC: BookE: Fix W=1 warnings

2023-04-05 Thread Michael Ellerman
On Mon, 03 Apr 2023 14:53:14 +1000, Michael Ellerman wrote:
> Fix various W=1 warnings in booke.c:
> 
>   arch/powerpc/kvm/booke.c:1008:5: error: no previous prototype for 
> ‘kvmppc_handle_exit’ [-Werror=missing-prototypes]
>1008 | int kvmppc_handle_exit(struct kvm_vcpu *vcpu, unsigned int exit_nr)
> | ^~
>   arch/powerpc/kvm/booke.c:1009: warning: Function parameter or member 'vcpu' 
> not described in 'kvmppc_handle_exit'
>   arch/powerpc/kvm/booke.c:1009: warning: Function parameter or member 
> 'exit_nr' not described in 'kvmppc_handle_exit'
> 
> [...]

Applied to powerpc/topic/ppc-kvm.

[1/1] KVM: PPC: BookE: Fix W=1 warnings
  https://git.kernel.org/powerpc/c/43d05c6123ca1ace5982ca326c156502e735b7d5

cheers


[PATCH v2] KVM: PPC: BookE: Fix W=1 warnings

2023-04-02 Thread Michael Ellerman
Fix various W=1 warnings in booke.c:

  arch/powerpc/kvm/booke.c:1008:5: error: no previous prototype for 
‘kvmppc_handle_exit’ [-Werror=missing-prototypes]
   1008 | int kvmppc_handle_exit(struct kvm_vcpu *vcpu, unsigned int exit_nr)
| ^~
  arch/powerpc/kvm/booke.c:1009: warning: Function parameter or member 'vcpu' 
not described in 'kvmppc_handle_exit'
  arch/powerpc/kvm/booke.c:1009: warning: Function parameter or member 
'exit_nr' not described in 'kvmppc_handle_exit'

Reported-by: kernel test robot 
Link: https://lore.kernel.org/r/202304020827.3lez86wb-...@intel.com/
Signed-off-by: Michael Ellerman 
---
 arch/powerpc/kvm/booke.c | 2 +-
 arch/powerpc/kvm/booke.h | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

v2: Rebased on my topic/ppc-kvm branch where I already had some of the
fixes queued.

diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
index ce37d282be6d..a9c04073d27e 100644
--- a/arch/powerpc/kvm/booke.c
+++ b/arch/powerpc/kvm/booke.c
@@ -1000,7 +1000,7 @@ static int kvmppc_resume_inst_load(struct kvm_vcpu *vcpu,
}
 }
 
-/**
+/*
  * kvmppc_handle_exit
  *
  * Return value is in the form (errcode<<2 | RESUME_FLAG_HOST | RESUME_FLAG_NV)
diff --git a/arch/powerpc/kvm/booke.h b/arch/powerpc/kvm/booke.h
index be9da96d9f06..9c5b8e76014f 100644
--- a/arch/powerpc/kvm/booke.h
+++ b/arch/powerpc/kvm/booke.h
@@ -109,4 +109,7 @@ static inline void kvmppc_clear_dbsr(void)
 {
mtspr(SPRN_DBSR, mfspr(SPRN_DBSR));
 }
+
+int kvmppc_handle_exit(struct kvm_vcpu *vcpu, unsigned int exit_nr);
+
 #endif /* __KVM_BOOKE_H__ */
-- 
2.39.2