Re: [PATCH v2] dmaengine: Explicitly include correct DT includes

2023-08-01 Thread Vinod Koul


On Tue, 18 Jul 2023 08:31:35 -0600, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
> 
> [...]

Applied, thanks!

[1/1] dmaengine: Explicitly include correct DT includes
  commit: 897500c7ea91702966adb9b412fa39400b4edee6

Best regards,
-- 
~Vinod




[PATCH v2] dmaengine: Explicitly include correct DT includes

2023-07-18 Thread Rob Herring
The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring 
---
v2:
- Fix build error on bestcomm
---
 drivers/dma/apple-admac.c  | 3 ++-
 drivers/dma/at_hdmac.c | 2 +-
 drivers/dma/bcm-sba-raid.c | 4 +++-
 drivers/dma/bestcomm/bestcomm.c| 3 +--
 drivers/dma/dma-jz4780.c   | 1 -
 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 1 -
 drivers/dma/dw/rzn1-dmamux.c   | 4 +++-
 drivers/dma/fsl-qdma.c | 4 ++--
 drivers/dma/fsl_raid.c | 3 ++-
 drivers/dma/fsldma.c   | 3 ++-
 drivers/dma/img-mdc-dma.c  | 1 -
 drivers/dma/imx-dma.c  | 2 +-
 drivers/dma/imx-sdma.c | 1 -
 drivers/dma/lpc18xx-dmamux.c   | 4 +++-
 drivers/dma/mediatek/mtk-cqdma.c   | 1 -
 drivers/dma/mediatek/mtk-hsdma.c   | 1 -
 drivers/dma/mediatek/mtk-uart-apdma.c  | 1 -
 drivers/dma/mpc512x_dma.c  | 4 ++--
 drivers/dma/mxs-dma.c  | 1 -
 drivers/dma/nbpfaxi.c  | 1 -
 drivers/dma/owl-dma.c  | 3 ++-
 drivers/dma/ppc4xx/adma.c  | 2 +-
 drivers/dma/qcom/hidma.c   | 2 +-
 drivers/dma/sh/shdmac.c| 1 -
 drivers/dma/sprd-dma.c | 2 +-
 drivers/dma/stm32-dmamux.c | 4 +++-
 drivers/dma/stm32-mdma.c   | 1 -
 drivers/dma/sun6i-dma.c| 2 +-
 drivers/dma/tegra186-gpc-dma.c | 2 +-
 drivers/dma/tegra20-apb-dma.c  | 1 -
 drivers/dma/tegra210-adma.c| 3 ++-
 drivers/dma/ti/dma-crossbar.c  | 5 +++--
 drivers/dma/ti/edma.c  | 1 -
 drivers/dma/ti/k3-udma-private.c   | 2 ++
 drivers/dma/ti/k3-udma.c   | 1 -
 drivers/dma/ti/omap-dma.c  | 2 +-
 drivers/dma/xgene-dma.c| 3 ++-
 drivers/dma/xilinx/xilinx_dma.c| 4 ++--
 drivers/dma/xilinx/zynqmp_dma.c| 3 ++-
 39 files changed, 46 insertions(+), 43 deletions(-)

diff --git a/drivers/dma/apple-admac.c b/drivers/dma/apple-admac.c
index 4cf8da77bdd9..3af795635c5c 100644
--- a/drivers/dma/apple-admac.c
+++ b/drivers/dma/apple-admac.c
@@ -10,8 +10,9 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
index ee3a219e3a89..b2876f67471f 100644
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -20,7 +20,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c
index 064761289a73..94ea35330eb5 100644
--- a/drivers/dma/bcm-sba-raid.c
+++ b/drivers/dma/bcm-sba-raid.c
@@ -35,7 +35,9 @@
 #include 
 #include 
 #include 
-#include 
+#include 
+#include 
+#include 
 #include 
 #include 
 
diff --git a/drivers/dma/bestcomm/bestcomm.c b/drivers/dma/bestcomm/bestcomm.c
index eabbcfcaa7cb..80096f94032d 100644
--- a/drivers/dma/bestcomm/bestcomm.c
+++ b/drivers/dma/bestcomm/bestcomm.c
@@ -14,9 +14,8 @@
 #include 
 #include 
 #include 
-#include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c
index 9c1a6e9a9c03..adbd47bd6adf 100644
--- a/drivers/dma/dma-jz4780.c
+++ b/drivers/dma/dma-jz4780.c
@@ -13,7 +13,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c 
b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
index 796b6caf0bab..dd02f84e404d 100644
--- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
+++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
@@ -21,7 +21,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/dma/dw/rzn1-dmamux.c b/drivers/dma/dw/rzn1-dmamux.c
index f9912c3dd4d7..4fb8508419db 100644
--- a/drivers/dma/dw/rzn1-dmamux.c
+++ b/drivers/dma/dw/rzn1-dmamux.c
@@ -5,8 +5,10 @@
  * Based on TI crossbar driver written by Peter Ujfalusi 

  */
 #include 
-#include 
+#include 
 #include 
+#include 
+#include 
 #include 
 #include 
 #include 
diff --git