Re: [PATCH v2] selftests/powerpc/papr-vpd: Fix missing variable initialization

[Michael Ellerman]

On Thu, 04 Apr 2024 17:02:09 -0500, Nathan Lynch wrote:
> The "close handle without consuming VPD" testcase has inconsistent
> results because it fails to initialize the location code object it
> passes to ioctl() to create a VPD handle. Initialize the location code
> to the empty string as intended.
> 
> 

Applied to powerpc/fixes.

[1/1] selftests/powerpc/papr-vpd: Fix missing variable initialization
  https://git.kernel.org/powerpc/c/210cfef579260ed6c3b700e7baeae51a5e183f43

cheers

[PATCH v2] selftests/powerpc/papr-vpd: Fix missing variable initialization

[Nathan Lynch via B4 Relay]

From: Nathan Lynch 

The "close handle without consuming VPD" testcase has inconsistent
results because it fails to initialize the location code object it
passes to ioctl() to create a VPD handle. Initialize the location code
to the empty string as intended.

Signed-off-by: Nathan Lynch 
Reported-by: Geetika Moolchandani 
Fixes: 9118c5d32bdd ("powerpc/selftests: Add test for papr-vpd")
---
Changes in v2:
- Add Fixes: and Reported-by: tags.
- Link to v1: 
https://lore.kernel.org/r/20240404-papr-vpd-test-uninit-lc-v1-1-04cc22d7f...@linux.ibm.com
---
 tools/testing/selftests/powerpc/papr_vpd/papr_vpd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/powerpc/papr_vpd/papr_vpd.c 
b/tools/testing/selftests/powerpc/papr_vpd/papr_vpd.c
index 505294da1b9f..d6f99eb9be65 100644
--- a/tools/testing/selftests/powerpc/papr_vpd/papr_vpd.c
+++ b/tools/testing/selftests/powerpc/papr_vpd/papr_vpd.c
@@ -154,7 +154,7 @@ static int dev_papr_vpd_null_handle(void)
 static int papr_vpd_close_handle_without_reading(void)
 {
const int devfd = open(DEVPATH, O_RDONLY);
-   struct papr_location_code lc;
+   struct papr_location_code lc = { .str = "", };
int fd;
 
SKIP_IF_MSG(devfd < 0 && errno == ENOENT,

---
base-commit: bfe51886ca544956eb4ff924d1937ac01d0ca9c8
change-id: 20240403-papr-vpd-test-uninit-lc-306ce6cd5167

Best regards,
-- 
Nathan Lynch