Re: [PATCH v2 0/5] Allow CPU0 to be nohz full
On Tue, Apr 30, 2019 at 12:46:40PM +1000, Nicholas Piggin wrote: > Peter Zijlstra's on April 25, 2019 10:04 pm: > > On Thu, Apr 11, 2019 at 01:34:43PM +1000, Nicholas Piggin wrote: > >> Since last time, I added a compile time option to opt-out of this > >> if the platform does not support suspend on non-zero, and tried to > >> improve legibility of changelogs and explain the justification > >> better. > >> > >> I have been testing this on powerpc/pseries and it seems to work > >> fine (the firmware call to suspend can be called on any CPU and > >> resumes where it left off), but not included here because the > >> code has some bitrot unrelated to this series which I hacked to > >> fix. I will discuss it and either send an acked patch to go with > >> this series if it is small, or fix it in powerpc tree. > >> > > > > Rafael, Frederic, any comments? > > > > Sorry to ping again, I guess people are probably busy after vacation. > Any chance we could get this in next merge window? Peter are you okay > with the config option as it is, then we can look at adapting it to > what x86 needs as a follow up (e.g., allow nohz CPU0 for > cpu0_hotpluggable case)? Yeah, let me just queue these here patches. Not sure they'll still make the upcoming merge window, but we can try.
Re: [PATCH v2 0/5] Allow CPU0 to be nohz full
Peter Zijlstra's on April 25, 2019 10:04 pm: > On Thu, Apr 11, 2019 at 01:34:43PM +1000, Nicholas Piggin wrote: >> Since last time, I added a compile time option to opt-out of this >> if the platform does not support suspend on non-zero, and tried to >> improve legibility of changelogs and explain the justification >> better. >> >> I have been testing this on powerpc/pseries and it seems to work >> fine (the firmware call to suspend can be called on any CPU and >> resumes where it left off), but not included here because the >> code has some bitrot unrelated to this series which I hacked to >> fix. I will discuss it and either send an acked patch to go with >> this series if it is small, or fix it in powerpc tree. >> > > Rafael, Frederic, any comments? > Sorry to ping again, I guess people are probably busy after vacation. Any chance we could get this in next merge window? Peter are you okay with the config option as it is, then we can look at adapting it to what x86 needs as a follow up (e.g., allow nohz CPU0 for cpu0_hotpluggable case)? Thanks, Nick
Re: [PATCH v2 0/5] Allow CPU0 to be nohz full
On Thu, Apr 11, 2019 at 01:34:43PM +1000, Nicholas Piggin wrote: > Since last time, I added a compile time option to opt-out of this > if the platform does not support suspend on non-zero, and tried to > improve legibility of changelogs and explain the justification > better. > > I have been testing this on powerpc/pseries and it seems to work > fine (the firmware call to suspend can be called on any CPU and > resumes where it left off), but not included here because the > code has some bitrot unrelated to this series which I hacked to > fix. I will discuss it and either send an acked patch to go with > this series if it is small, or fix it in powerpc tree. > Rafael, Frederic, any comments?
[PATCH v2 0/5] Allow CPU0 to be nohz full
Since last time, I added a compile time option to opt-out of this if the platform does not support suspend on non-zero, and tried to improve legibility of changelogs and explain the justification better. I have been testing this on powerpc/pseries and it seems to work fine (the firmware call to suspend can be called on any CPU and resumes where it left off), but not included here because the code has some bitrot unrelated to this series which I hacked to fix. I will discuss it and either send an acked patch to go with this series if it is small, or fix it in powerpc tree. Thanks, Nick Nicholas Piggin (5): sched/core: allow the remote scheduler tick to be started on CPU0 PM / suspend: add function to disable secondaries for suspend kernel/cpu: Allow non-zero CPU to be primary for suspend / kexec freeze kernel/sched/isolation: require a present CPU in housekeeping mask nohz_full: Allow the boot CPU to be nohz_full include/linux/cpu.h | 15 kernel/cpu.c | 10 +++- kernel/kexec_core.c | 4 ++-- kernel/power/Kconfig | 9 +++ kernel/power/hibernate.c | 12 +- kernel/power/suspend.c| 4 ++-- kernel/sched/core.c | 2 +- kernel/sched/isolation.c | 18 ++ kernel/time/tick-common.c | 50 +++ kernel/time/tick-sched.c | 34 ++ 11 files changed, 131 insertions(+), 31 deletions(-) -- 2.20.1
