Re: [PATCH v2 3/3] ASoC: imx-audmix: fix object reference leaks in probe

2019-04-09 Thread Nicolin Chen
On Tue, Apr 09, 2019 at 11:27:42AM +, Viorel Suman wrote:
> Release the reference to the underlying device taken
> by of_find_device_by_node() call.
> 
> Signed-off-by: Viorel Suman 
> Reported-by: Julia Lawall 

Acked-by: Nicolin Chen 


[PATCH v2 3/3] ASoC: imx-audmix: fix object reference leaks in probe

2019-04-09 Thread Viorel Suman
Release the reference to the underlying device taken
by of_find_device_by_node() call.

Signed-off-by: Viorel Suman 
Reported-by: Julia Lawall 
---
 sound/soc/fsl/imx-audmix.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/sound/soc/fsl/imx-audmix.c b/sound/soc/fsl/imx-audmix.c
index 7983bd3..9aaf3e5 100644
--- a/sound/soc/fsl/imx-audmix.c
+++ b/sound/soc/fsl/imx-audmix.c
@@ -171,6 +171,7 @@ static int imx_audmix_probe(struct platform_device *pdev)
np->full_name);
return -EINVAL;
}
+   put_device(&audmix_pdev->dev);
 
num_dai = of_count_phandle_with_args(audmix_np, "dais", NULL);
if (num_dai != FSL_AUDMIX_MAX_DAIS) {
@@ -216,6 +217,7 @@ static int imx_audmix_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "failed to find SAI platform 
device\n");
return -EINVAL;
}
+   put_device(&cpu_pdev->dev);
 
dai_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s%s",
  fe_name_pref, args.np->full_name + 1);
@@ -280,6 +282,8 @@ static int imx_audmix_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "failed to find SAI platform device\n");
return -EINVAL;
}
+   put_device(&cpu_pdev->dev);
+
priv->cpu_mclk = devm_clk_get(&cpu_pdev->dev, "mclk1");
if (IS_ERR(priv->cpu_mclk)) {
ret = PTR_ERR(priv->cpu_mclk);
-- 
2.7.4