Re: [PATCH v2 3/3] kconfig: add dependencies of POWER_RESET for PowerMac
Hi, On 9/1/2023 2:10 PM, Christophe Leroy wrote: Le 01/09/2023 à 04:43, Yuan Tan a écrit : PowerMac's power off depends on ADB_CUDA to work. Enable it when POWER_RESET is set for convenience. Suggested-by: Zhangjin Wu Signed-off-by: Yuan Tan --- arch/powerpc/platforms/powermac/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/platforms/powermac/Kconfig b/arch/powerpc/platforms/powermac/Kconfig index 130707ec9f99..9e633d7e8367 100644 --- a/arch/powerpc/platforms/powermac/Kconfig +++ b/arch/powerpc/platforms/powermac/Kconfig @@ -2,6 +2,7 @@ config PPC_PMAC bool "Apple PowerMac based machines" depends on PPC_BOOK3S && CPU_BIG_ENDIAN + select ADB_CUDA if POWER_RESET ADB_CUDA depends on !PPC_PMAC64. What will happen if PPC_PMAC64 is selected ? select MPIC select FORCE_PCI select PPC_INDIRECT_PCI if PPC32 I didn't notice that ADB_CUDA depends on !PPC_PMAC64. In the case where PPC_PMAC64 is set, ADB_CUDA indeed should not be enabled. Thank you for pointing that out. I will fix it in v3 and check again in x86 and mips :)
Re: [PATCH v2 3/3] kconfig: add dependencies of POWER_RESET for PowerMac
Le 01/09/2023 à 04:43, Yuan Tan a écrit : > PowerMac's power off depends on ADB_CUDA to work. Enable it when > POWER_RESET is set for convenience. > > Suggested-by: Zhangjin Wu > Signed-off-by: Yuan Tan > --- > arch/powerpc/platforms/powermac/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/platforms/powermac/Kconfig > b/arch/powerpc/platforms/powermac/Kconfig > index 130707ec9f99..9e633d7e8367 100644 > --- a/arch/powerpc/platforms/powermac/Kconfig > +++ b/arch/powerpc/platforms/powermac/Kconfig > @@ -2,6 +2,7 @@ > config PPC_PMAC > bool "Apple PowerMac based machines" > depends on PPC_BOOK3S && CPU_BIG_ENDIAN > + select ADB_CUDA if POWER_RESET ADB_CUDA depends on !PPC_PMAC64. What will happen if PPC_PMAC64 is selected ? > select MPIC > select FORCE_PCI > select PPC_INDIRECT_PCI if PPC32
[PATCH v2 3/3] kconfig: add dependencies of POWER_RESET for PowerMac
PowerMac's power off depends on ADB_CUDA to work. Enable it when POWER_RESET is set for convenience. Suggested-by: Zhangjin Wu Signed-off-by: Yuan Tan --- arch/powerpc/platforms/powermac/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/platforms/powermac/Kconfig b/arch/powerpc/platforms/powermac/Kconfig index 130707ec9f99..9e633d7e8367 100644 --- a/arch/powerpc/platforms/powermac/Kconfig +++ b/arch/powerpc/platforms/powermac/Kconfig @@ -2,6 +2,7 @@ config PPC_PMAC bool "Apple PowerMac based machines" depends on PPC_BOOK3S && CPU_BIG_ENDIAN + select ADB_CUDA if POWER_RESET select MPIC select FORCE_PCI select PPC_INDIRECT_PCI if PPC32 -- 2.34.1
