Re: [PATCH v2 42/52] powerpc/64s/exception: machine check fwnmi does not trigger when in HV mode
Mahesh Jagannath Salgaonkar's on June 20, 2019 7:26 pm: > On 6/20/19 10:44 AM, Nicholas Piggin wrote: >> Remove dead code. >> >> Signed-off-by: Nicholas Piggin >> --- >> arch/powerpc/kernel/exceptions-64s.S | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/arch/powerpc/kernel/exceptions-64s.S >> b/arch/powerpc/kernel/exceptions-64s.S >> index 286bd5670d60..b12755a4f884 100644 >> --- a/arch/powerpc/kernel/exceptions-64s.S >> +++ b/arch/powerpc/kernel/exceptions-64s.S >> @@ -1040,9 +1040,6 @@ TRAMP_REAL_BEGIN(machine_check_pSeries) >> .globl machine_check_fwnmi >> machine_check_fwnmi: >> EXCEPTION_PROLOG_0 PACA_EXMC >> -BEGIN_FTR_SECTION >> -b machine_check_common_early >> -END_FTR_SECTION_IFCLR(CPU_FTR_HVMODE) > > Didn't We add that to handle SLB/ERAT errors in real mode for pseries ? > Are we taking that off ? Oh that's a stupid mistake, as patch title says I mistook it for IFSET. Good catch, thanks, that probably messes up a later patch too, I'll fix. Thanks, Nick
Re: [PATCH v2 42/52] powerpc/64s/exception: machine check fwnmi does not trigger when in HV mode
On 6/20/19 10:44 AM, Nicholas Piggin wrote: > Remove dead code. > > Signed-off-by: Nicholas Piggin > --- > arch/powerpc/kernel/exceptions-64s.S | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/powerpc/kernel/exceptions-64s.S > b/arch/powerpc/kernel/exceptions-64s.S > index 286bd5670d60..b12755a4f884 100644 > --- a/arch/powerpc/kernel/exceptions-64s.S > +++ b/arch/powerpc/kernel/exceptions-64s.S > @@ -1040,9 +1040,6 @@ TRAMP_REAL_BEGIN(machine_check_pSeries) > .globl machine_check_fwnmi > machine_check_fwnmi: > EXCEPTION_PROLOG_0 PACA_EXMC > -BEGIN_FTR_SECTION > - b machine_check_common_early > -END_FTR_SECTION_IFCLR(CPU_FTR_HVMODE) Didn't We add that to handle SLB/ERAT errors in real mode for pseries ? Are we taking that off ? > machine_check_pSeries_0: > EXCEPTION_PROLOG_1 EXC_STD, PACA_EXMC, 1, 0x200, 1, 1, 0 > /* >
[PATCH v2 42/52] powerpc/64s/exception: machine check fwnmi does not trigger when in HV mode
Remove dead code. Signed-off-by: Nicholas Piggin --- arch/powerpc/kernel/exceptions-64s.S | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S index 286bd5670d60..b12755a4f884 100644 --- a/arch/powerpc/kernel/exceptions-64s.S +++ b/arch/powerpc/kernel/exceptions-64s.S @@ -1040,9 +1040,6 @@ TRAMP_REAL_BEGIN(machine_check_pSeries) .globl machine_check_fwnmi machine_check_fwnmi: EXCEPTION_PROLOG_0 PACA_EXMC -BEGIN_FTR_SECTION - b machine_check_common_early -END_FTR_SECTION_IFCLR(CPU_FTR_HVMODE) machine_check_pSeries_0: EXCEPTION_PROLOG_1 EXC_STD, PACA_EXMC, 1, 0x200, 1, 1, 0 /* -- 2.20.1
