Re: [PATCH v3 1/3] powerpc/pseries: Update SCM hcall op-codes in hvcall.h
Thanks for reviewing this patch Mpe. Michael Ellerman writes: > "Oliver O'Halloran" writes: >> On Fri, Jun 28, 2019 at 1:39 PM Michael Ellerman wrote: >>> >>> Vaibhav Jain writes: >>> > *snip* >>> >>> How can we be changing the meaning of HCALL numbers without breaking all >>> existing usages? >> >> The changed one being changed here were never used by linux or >> implemented by either hypervisor. > > OK. Please say so in the change log so that it's clear it's not a > behaviour change. I have respinned this patchset to v4 updating this patch's description mentioning the hcall opcodes that are removed. > >>> Where are these hypervisor calls documented? >> >> In an internal spec from one the phyp guys. I have been complaining >> about it not being open (or merged into PAPR at the very least), but >> it doesn't look like there's been any movement there. > > Please send a patch for Documentation/powerpc/ describing the API for > the hypercalls we're using. Sure will send a separate patch documenting this. > cheers > -- Vaibhav Jain Linux Technology Center, IBM India Pvt. Ltd.
Re: [PATCH v3 1/3] powerpc/pseries: Update SCM hcall op-codes in hvcall.h
"Oliver O'Halloran" writes: > On Fri, Jun 28, 2019 at 1:39 PM Michael Ellerman wrote: >> >> Vaibhav Jain writes: >> > *snip* >> >> How can we be changing the meaning of HCALL numbers without breaking all >> existing usages? > > The changed one being changed here were never used by linux or > implemented by either hypervisor. OK. Please say so in the change log so that it's clear it's not a behaviour change. >> Where are these hypervisor calls documented? > > In an internal spec from one the phyp guys. I have been complaining > about it not being open (or merged into PAPR at the very least), but > it doesn't look like there's been any movement there. Please send a patch for Documentation/powerpc/ describing the API for the hypercalls we're using. cheers
Re: [PATCH v3 1/3] powerpc/pseries: Update SCM hcall op-codes in hvcall.h
On Fri, Jun 28, 2019 at 1:39 PM Michael Ellerman wrote: > > Vaibhav Jain writes: > > *snip* > > How can we be changing the meaning of HCALL numbers without breaking all > existing usages? The changed one being changed here were never used by linux or implemented by either hypervisor. > Where are these hypervisor calls documented? In an internal spec from one the phyp guys. I have been complaining about it not being open (or merged into PAPR at the very least), but it doesn't look like there's been any movement there. Oliver
Re: [PATCH v3 1/3] powerpc/pseries: Update SCM hcall op-codes in hvcall.h
Vaibhav Jain writes: > Update the hvcalls.h to include op-codes for new hcalls introduce to > manage SCM memory. Also update existing hcall definitions to reflect > current papr specification for SCM. > > Signed-off-by: Vaibhav Jain > --- > Change-log: > > v3: > * Added updated opcode for H_SCM_HEALTH [Oliver] > > v2: > * None new patch in this series. > --- > arch/powerpc/include/asm/hvcall.h | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/arch/powerpc/include/asm/hvcall.h > b/arch/powerpc/include/asm/hvcall.h > index 463c63a9fcf1..2023e327 100644 > --- a/arch/powerpc/include/asm/hvcall.h > +++ b/arch/powerpc/include/asm/hvcall.h > @@ -302,9 +302,14 @@ > #define H_SCM_UNBIND_MEM0x3F0 > #define H_SCM_QUERY_BLOCK_MEM_BINDING 0x3F4 > #define H_SCM_QUERY_LOGICAL_MEM_BINDING 0x3F8 > -#define H_SCM_MEM_QUERY 0x3FC > -#define H_SCM_BLOCK_CLEAR 0x400 > -#define MAX_HCALL_OPCODE H_SCM_BLOCK_CLEAR > +#define H_SCM_UNBIND_ALL0x3FC > +#define H_SCM_HEALTH0x400 > +#define H_SCM_PERFORMANCE_STATS 0x418 > +#define MAX_HCALL_OPCODE H_SCM_PERFORMANCE_STATS How can we be changing the meaning of HCALL numbers without breaking all existing usages? Where are these hypervisor calls documented? cheers
Re: [PATCH v3 1/3] powerpc/pseries: Update SCM hcall op-codes in hvcall.h
On Thu, Jun 27, 2019 at 2:53 AM Aneesh Kumar K.V wrote: > > Vaibhav Jain writes: > > > Update the hvcalls.h to include op-codes for new hcalls introduce to > > manage SCM memory. Also update existing hcall definitions to reflect > > current papr specification for SCM. > > > > Signed-off-by: Vaibhav Jain > > > Why split this as a separate patch? You should fold this to the next one > where we actually use the constant. I figured if you're going to update the hcall numbers to reflect reality then it should be done in a separate patch. Single logical change per patch and all that. Reviewed-by: Oliver O'Halloran
Re: [PATCH v3 1/3] powerpc/pseries: Update SCM hcall op-codes in hvcall.h
Vaibhav Jain writes: > Update the hvcalls.h to include op-codes for new hcalls introduce to > manage SCM memory. Also update existing hcall definitions to reflect > current papr specification for SCM. > > Signed-off-by: Vaibhav Jain Why split this as a separate patch? You should fold this to the next one where we actually use the constant. > --- > Change-log: > > v3: > * Added updated opcode for H_SCM_HEALTH [Oliver] > > v2: > * None new patch in this series. > --- > arch/powerpc/include/asm/hvcall.h | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/arch/powerpc/include/asm/hvcall.h > b/arch/powerpc/include/asm/hvcall.h > index 463c63a9fcf1..2023e327 100644 > --- a/arch/powerpc/include/asm/hvcall.h > +++ b/arch/powerpc/include/asm/hvcall.h > @@ -302,9 +302,14 @@ > #define H_SCM_UNBIND_MEM0x3F0 > #define H_SCM_QUERY_BLOCK_MEM_BINDING 0x3F4 > #define H_SCM_QUERY_LOGICAL_MEM_BINDING 0x3F8 > -#define H_SCM_MEM_QUERY 0x3FC > -#define H_SCM_BLOCK_CLEAR 0x400 > -#define MAX_HCALL_OPCODE H_SCM_BLOCK_CLEAR > +#define H_SCM_UNBIND_ALL0x3FC > +#define H_SCM_HEALTH0x400 > +#define H_SCM_PERFORMANCE_STATS 0x418 > +#define MAX_HCALL_OPCODE H_SCM_PERFORMANCE_STATS > + > +/* Scope args for H_SCM_UNBIND_ALL */ > +#define H_UNBIND_SCOPE_ALL (0x1) > +#define H_UNBIND_SCOPE_DRC (0x2) > > /* H_VIOCTL functions */ > #define H_GET_VIOA_DUMP_SIZE 0x01 > -- > 2.21.0
[PATCH v3 1/3] powerpc/pseries: Update SCM hcall op-codes in hvcall.h
Update the hvcalls.h to include op-codes for new hcalls introduce to manage SCM memory. Also update existing hcall definitions to reflect current papr specification for SCM. Signed-off-by: Vaibhav Jain --- Change-log: v3: * Added updated opcode for H_SCM_HEALTH [Oliver] v2: * None new patch in this series. --- arch/powerpc/include/asm/hvcall.h | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/include/asm/hvcall.h b/arch/powerpc/include/asm/hvcall.h index 463c63a9fcf1..2023e327 100644 --- a/arch/powerpc/include/asm/hvcall.h +++ b/arch/powerpc/include/asm/hvcall.h @@ -302,9 +302,14 @@ #define H_SCM_UNBIND_MEM0x3F0 #define H_SCM_QUERY_BLOCK_MEM_BINDING 0x3F4 #define H_SCM_QUERY_LOGICAL_MEM_BINDING 0x3F8 -#define H_SCM_MEM_QUERY0x3FC -#define H_SCM_BLOCK_CLEAR 0x400 -#define MAX_HCALL_OPCODE H_SCM_BLOCK_CLEAR +#define H_SCM_UNBIND_ALL0x3FC +#define H_SCM_HEALTH0x400 +#define H_SCM_PERFORMANCE_STATS 0x418 +#define MAX_HCALL_OPCODE H_SCM_PERFORMANCE_STATS + +/* Scope args for H_SCM_UNBIND_ALL */ +#define H_UNBIND_SCOPE_ALL (0x1) +#define H_UNBIND_SCOPE_DRC (0x2) /* H_VIOCTL functions */ #define H_GET_VIOA_DUMP_SIZE 0x01 -- 2.21.0
