Re: [PATCH v4] 83xx: add support for the kmeter1 board.
On Fri, Jun 12, 2009 at 07:27:42AM +0200, Heiko Schocher wrote:
Hello David,
David Gibson wrote:
On Thu, Jun 11, 2009 at 08:10:41PM +0200, Heiko Schocher wrote:
The following series implements basic board support for
the kmeter1 board from keymile, based on a MPC8360.
[snip]
+ par...@1400 {
+ reg = 0x1400 0x100;
+ device_type = par_io;
This should have a compatible value instead of a device_type value.
compatible = fsl,mpc8360-par_io; ?
Sounds reasonable, if there isn't an existing precedent to follow.
[snip]
+ num-ports = 7;
+
+ pio_ucc1: ucc_...@00 {
Since these nodes have addresses, they should also have reg
properties. And the parent should have #address-cells and
#size-cells.
added #address-cells and #size-cells, but couldn;t find what
I should write in a reg entry ... I think something like that:
reg = 0x00 0x01;
If you just want a plain index number, which is what it seems you have
here, then you'll want #address-cells = 1, #size-cells = 0 and reg
will then have one cell (i.e. 1 u32) with the index number
so subn...@0 {
reg = 0;
}
subn...@1 {
reg = 1;
}
Note also that it's usual for the unit addresses (that's the bits
after the @ sign) to be formatted without leading zeroes.
?
[snip]
+ q...@10 {
+ #address-cells = 1;
+ #size-cells = 1;
+ device_type = qe;
This device_type should not be here.
deleted.
Ok.
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
[PATCH v4] 83xx: add support for the kmeter1 board.
The following series implements basic board support for
the kmeter1 board from keymile, based on a MPC8360.
This series provides the following functionality:
- The board can boot with a serial console on UART1
- Ethernet:
UCC1 in RGMII mode
UCC2 in RGMII mode
UCC4 in RMII mode
UCC5 in RMII mode
UCC6 in RMII mode
UCC7 in RMII mode
UCC8 in RMII mode
following patch is necessary for working UCC in RMII mode:
http://lists.ozlabs.org/pipermail/linuxppc-dev/2009-April/070804.html
- Flash accessed via MTD layer
On this hardware there is an Intel P30 flash, following patch
series is necessary for working with this hardware:
http://lists.ozlabs.org/pipermail/linuxppc-dev/2009-April/070624.html
- I2C using I2C Bus 1 from the MPC8360 cpu
Signed-off-by: Heiko Schocher h...@denx.de
---
changes since v1:
- added comments from Kumar Gala and Scott Wood
- get rid of using get_immrbase() in board specific code
changes since v2:
- added comments from Kumar Gala
- rebased against 1406de8e11eb043681297adf86d6892ff8efc27a
from git://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git
changes since v3:
- updated mailinglistarchivelinks for necessary patches in commit text.
$ ./scripts/checkpatch.pl 0001--83xx-add-support-for-the-kmeter1-board.patch
total: 0 errors, 0 warnings, 1618 lines checked
0001--83xx-add-support-for-the-kmeter1-board.patch has no obvious style
problems and is ready for submission.
$
arch/powerpc/boot/dts/kmeter1.dts | 505 +++
arch/powerpc/configs/83xx/kmeter1_defconfig | 908 +++
arch/powerpc/platforms/83xx/Kconfig |7 +
arch/powerpc/platforms/83xx/Makefile|1 +
arch/powerpc/platforms/83xx/kmeter1.c | 188 ++
5 files changed, 1609 insertions(+), 0 deletions(-)
create mode 100644 arch/powerpc/boot/dts/kmeter1.dts
create mode 100644 arch/powerpc/configs/83xx/kmeter1_defconfig
create mode 100644 arch/powerpc/platforms/83xx/kmeter1.c
diff --git a/arch/powerpc/boot/dts/kmeter1.dts
b/arch/powerpc/boot/dts/kmeter1.dts
new file mode 100644
index 000..768813a
--- /dev/null
+++ b/arch/powerpc/boot/dts/kmeter1.dts
@@ -0,0 +1,505 @@
+/*
+ * Keymile KMETER1 Device Tree Source
+ *
+ * 2008 DENX Software Engineering GmbH
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation; either version 2 of the License, or (at your
+ * option) any later version.
+ */
+
+/dts-v1/;
+
+/ {
+ model = KMETER1;
+ compatible = keymile,KMETER1;
+ #address-cells = 1;
+ #size-cells = 1;
+
+ aliases {
+ ethernet0 = enet_piggy2;
+ ethernet1 = enet_estar1;
+ ethernet2 = enet_estar2;
+ ethernet3 = enet_eth1;
+ ethernet4 = enet_eth2;
+ ethernet5 = enet_eth3;
+ ethernet6 = enet_eth4;
+ serial0 = serial0;
+ };
+
+ cpus {
+ #address-cells = 1;
+ #size-cells = 0;
+
+ PowerPC,8...@0 {
+ device_type = cpu;
+ reg = 0x0;
+ d-cache-line-size = 32; // 32 bytes
+ i-cache-line-size = 32; // 32 bytes
+ d-cache-size = 32768; // L1, 32K
+ i-cache-size = 32768; // L1, 32K
+ timebase-frequency = 0; /* Filled in by U-Boot
*/
+ bus-frequency = 0;/* Filled in by U-Boot */
+ clock-frequency = 0; /* Filled in by U-Boot */
+ };
+ };
+
+ memory {
+ device_type = memory;
+ reg = 0 0;/* Filled in by U-Boot */
+ };
+
+ soc8...@e000 {
+ #address-cells = 1;
+ #size-cells = 1;
+ device_type = soc;
+ compatible = fsl,mpc8360-immr, simple-bus;
+ ranges = 0x0 0xe000 0x0020;
+ reg = 0xe000 0x0200;
+ bus-frequency = 0;/* Filled in by U-Boot */
+
+ i...@3000 {
+ #address-cells = 1;
+ #size-cells = 0;
+ cell-index = 0;
+ compatible = fsl-i2c;
+ reg = 0x3000 0x100;
+ interrupts = 14 0x8;
+ interrupt-parent = ipic;
+ dfsrr;
+ };
+
+ serial0: ser...@4500 {
+ cell-index = 0;
+ device_type = serial;
+ compatible = ns16550;
+ reg = 0x4500 0x100;
+ clock-frequency = 26400;
+ interrupts = 9 0x8;
+ interrupt-parent =
Re: [PATCH v4] 83xx: add support for the kmeter1 board.
On Thu, Jun 11, 2009 at 08:10:41PM +0200, Heiko Schocher wrote:
The following series implements basic board support for
the kmeter1 board from keymile, based on a MPC8360.
[snip]
+ par...@1400 {
+ reg = 0x1400 0x100;
+ device_type = par_io;
This should have a compatible value instead of a device_type value.
[snip]
+ num-ports = 7;
+
+ pio_ucc1: ucc_...@00 {
Since these nodes have addresses, they should also have reg
properties. And the parent should have #address-cells and
#size-cells.
[snip]
+ q...@10 {
+ #address-cells = 1;
+ #size-cells = 1;
+ device_type = qe;
This device_type should not be here.
+ compatible = fsl,qe;
+ ranges = 0x0 0x10 0x10;
+ reg = 0x10 0x480;
+ clock-frequency = 0; /* Filled in by U-Boot */
+ brg-frequency = 0;/* Filled in by U-Boot */
+ bus-frequency = 0;/* Filled in by U-Boot */
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v4] 83xx: add support for the kmeter1 board.
Hello David,
David Gibson wrote:
On Thu, Jun 11, 2009 at 08:10:41PM +0200, Heiko Schocher wrote:
The following series implements basic board support for
the kmeter1 board from keymile, based on a MPC8360.
[snip]
+par...@1400 {
+reg = 0x1400 0x100;
+device_type = par_io;
This should have a compatible value instead of a device_type value.
compatible = fsl,mpc8360-par_io; ?
[snip]
+num-ports = 7;
+
+pio_ucc1: ucc_...@00 {
Since these nodes have addresses, they should also have reg
properties. And the parent should have #address-cells and
#size-cells.
added #address-cells and #size-cells, but couldn;t find what
I should write in a reg entry ... I think something like that:
reg = 0x00 0x01;
?
[snip]
+q...@10 {
+#address-cells = 1;
+#size-cells = 1;
+device_type = qe;
This device_type should not be here.
deleted.
+compatible = fsl,qe;
+ranges = 0x0 0x10 0x10;
+reg = 0x10 0x480;
+clock-frequency = 0; /* Filled in by U-Boot */
+brg-frequency = 0;/* Filled in by U-Boot */
+bus-frequency = 0;/* Filled in by U-Boot */
bye
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
