Re: [PATCH v4 05/10] net/ps3_gelic: Add vlan_id structure

[Christophe Leroy]

Le 23/07/2021 à 22:31, Geoff Levand a écrit :

In an effort to make the PS3 gelic driver easier to maintain, add
a definition for the vlan_id structure.

Signed-off-by: Geoff Levand 


Commit 4298d9fdc87f ("net/ps3_gelic: Add vlan_id structure") has no obvious style problems and is 
ready for submission.




---
  drivers/net/ethernet/toshiba/ps3_gelic_net.c | 7 ---
  1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c 
b/drivers/net/ethernet/toshiba/ps3_gelic_net.c
index 946e9bfa071b..54e50ad9e629 100644
--- a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
+++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.c
@@ -1614,13 +1614,14 @@ static struct gelic_card *gelic_alloc_card_net(struct 
net_device **netdev)
  static void gelic_card_get_vlan_info(struct gelic_card *card)
  {
struct device *dev = ctodev(card);
+   unsigned int i;
u64 v1, v2;
int status;
-   unsigned int i;
-   struct {
+   struct vlan_id {
int tx;
int rx;
-   } vlan_id_ix[2] = {
+   };
+   struct vlan_id vlan_id_ix[2] = {
[GELIC_PORT_ETHERNET_0] = {
.tx = GELIC_LV1_VLAN_TX_ETHERNET_0,
.rx = GELIC_LV1_VLAN_RX_ETHERNET_0

[PATCH v4 05/10] net/ps3_gelic: Add vlan_id structure

[Geoff Levand]

In an effort to make the PS3 gelic driver easier to maintain, add
a definition for the vlan_id structure.

Signed-off-by: Geoff Levand 
---
 drivers/net/ethernet/toshiba/ps3_gelic_net.c | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c 
b/drivers/net/ethernet/toshiba/ps3_gelic_net.c
index 946e9bfa071b..54e50ad9e629 100644
--- a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
+++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.c
@@ -1614,13 +1614,14 @@ static struct gelic_card *gelic_alloc_card_net(struct 
net_device **netdev)
 static void gelic_card_get_vlan_info(struct gelic_card *card)
 {
struct device *dev = ctodev(card);
+   unsigned int i;
u64 v1, v2;
int status;
-   unsigned int i;
-   struct {
+   struct vlan_id {
int tx;
int rx;
-   } vlan_id_ix[2] = {
+   };
+   struct vlan_id vlan_id_ix[2] = {
[GELIC_PORT_ETHERNET_0] = {
.tx = GELIC_LV1_VLAN_TX_ETHERNET_0,
.rx = GELIC_LV1_VLAN_RX_ETHERNET_0
-- 
2.25.1