Re: [PATCH v4 1/5] powerpc/mce.c: Remove unused function get_mce_fault_addr()

[Balbir Singh]

On Mon, Oct 16, 2017 at 4:13 PM, Michael Ellerman  wrote:
> Balbir Singh  writes:
>
>> There are no users of get_mce_fault_addr()
>>
>> Fixes: b63a0ff ("powerpc/powernv: Machine check exception handling.")
>
> That fixes line is wrong, get_mce_fault_addr() was used in that commit.
>
> The last usage was removed in:
>
>   1363875bdb63 ("powerpc/64s: fix handling of non-synchronous machine checks")
>
> So that's what the fixes tag should point at if anything, I'll update it
> here.

Sorry, my git search was really awe-full! Thanks for fixing it.

Balbir Singh

Re: [PATCH v4 1/5] powerpc/mce.c: Remove unused function get_mce_fault_addr()

[Michael Ellerman]

Balbir Singh  writes:

> There are no users of get_mce_fault_addr()
>
> Fixes: b63a0ff ("powerpc/powernv: Machine check exception handling.")

That fixes line is wrong, get_mce_fault_addr() was used in that commit.

The last usage was removed in:

  1363875bdb63 ("powerpc/64s: fix handling of non-synchronous machine checks")

So that's what the fixes tag should point at if anything, I'll update it
here.

cheers

[PATCH v4 1/5] powerpc/mce.c: Remove unused function get_mce_fault_addr()

[Balbir Singh]

There are no users of get_mce_fault_addr()

Fixes: b63a0ff ("powerpc/powernv: Machine check exception handling.")

Signed-off-by: Balbir Singh 
Reviewed-by: Nicholas Piggin 
---
 arch/powerpc/include/asm/mce.h |  2 --
 arch/powerpc/kernel/mce.c  | 39 ---
 2 files changed, 41 deletions(-)

diff --git a/arch/powerpc/include/asm/mce.h b/arch/powerpc/include/asm/mce.h
index 190d69a..75292c7 100644
--- a/arch/powerpc/include/asm/mce.h
+++ b/arch/powerpc/include/asm/mce.h
@@ -210,6 +210,4 @@ extern void release_mce_event(void);
 extern void machine_check_queue_event(void);
 extern void machine_check_print_event_info(struct machine_check_event *evt,
   bool user_mode);
-extern uint64_t get_mce_fault_addr(struct machine_check_event *evt);
-
 #endif /* __ASM_PPC64_MCE_H__ */
diff --git a/arch/powerpc/kernel/mce.c b/arch/powerpc/kernel/mce.c
index 9b2ea7e..e254399 100644
--- a/arch/powerpc/kernel/mce.c
+++ b/arch/powerpc/kernel/mce.c
@@ -411,45 +411,6 @@ void machine_check_print_event_info(struct 
machine_check_event *evt,
 }
 EXPORT_SYMBOL_GPL(machine_check_print_event_info);
 
-uint64_t get_mce_fault_addr(struct machine_check_event *evt)
-{
-   switch (evt->error_type) {
-   case MCE_ERROR_TYPE_UE:
-   if (evt->u.ue_error.effective_address_provided)
-   return evt->u.ue_error.effective_address;
-   break;
-   case MCE_ERROR_TYPE_SLB:
-   if (evt->u.slb_error.effective_address_provided)
-   return evt->u.slb_error.effective_address;
-   break;
-   case MCE_ERROR_TYPE_ERAT:
-   if (evt->u.erat_error.effective_address_provided)
-   return evt->u.erat_error.effective_address;
-   break;
-   case MCE_ERROR_TYPE_TLB:
-   if (evt->u.tlb_error.effective_address_provided)
-   return evt->u.tlb_error.effective_address;
-   break;
-   case MCE_ERROR_TYPE_USER:
-   if (evt->u.user_error.effective_address_provided)
-   return evt->u.user_error.effective_address;
-   break;
-   case MCE_ERROR_TYPE_RA:
-   if (evt->u.ra_error.effective_address_provided)
-   return evt->u.ra_error.effective_address;
-   break;
-   case MCE_ERROR_TYPE_LINK:
-   if (evt->u.link_error.effective_address_provided)
-   return evt->u.link_error.effective_address;
-   break;
-   default:
-   case MCE_ERROR_TYPE_UNKNOWN:
-   break;
-   }
-   return 0;
-}
-EXPORT_SYMBOL(get_mce_fault_addr);
-
 /*
  * This function is called in real mode. Strictly no printk's please.
  *
-- 
2.9.5