Re: [RFC patch 0/5] Support BCLK input clock in tlv320aic31xx
Hi Mark, On 12/3/21 2:34 PM, Mark Brown wrote: > On Fri, Dec 03, 2021 at 02:25:17PM -0300, Ariel D'Alessandro wrote: >> On 11/22/21 9:00 PM, Mark Brown wrote: > >>> If any updates are required or you are submitting further changes they >>> should be sent as incremental updates against current git, existing >>> patches will not be replaced. > >> I gotta send a fix for one of the patches. So, should it be a new >> incremental patch or I can still send a patchset v2? > > See above. Got it, thank you for confirming it.
Re: [RFC patch 0/5] Support BCLK input clock in tlv320aic31xx
On Fri, Dec 03, 2021 at 02:25:17PM -0300, Ariel D'Alessandro wrote: > On 11/22/21 9:00 PM, Mark Brown wrote: > > If any updates are required or you are submitting further changes they > > should be sent as incremental updates against current git, existing > > patches will not be replaced. > I gotta send a fix for one of the patches. So, should it be a new > incremental patch or I can still send a patchset v2? See above. signature.asc Description: PGP signature
Re: [RFC patch 0/5] Support BCLK input clock in tlv320aic31xx
Hi Mark, On 11/22/21 9:00 PM, Mark Brown wrote: > On Fri, 19 Nov 2021 12:32:43 -0300, Ariel D'Alessandro wrote: >> The tlv320aic31xx codec allows using BCLK as the input clock for PLL, >> deriving all the frequencies through a set of divisors. >> >> In this case, codec sysclk is determined by the hwparams sample >> rate/format. So its frequency must be updated from the codec itself when >> these are changed. >> >> [...] > > Applied to > >https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next > > Thanks! > > [1/5] ASoC: tlv320aic31xx: Fix typo in BCLK clock name > commit: 7016fd940adf2f4d86032339b546c6ecd737062f > [2/5] ASoC: tlv320aic31xx: Add support for pll_r coefficient > commit: 2664b24a8c51c21b24c2b37b7f10d6485c35b7c1 > [3/5] ASoC: tlv320aic31xx: Add divs for bclk as clk_in > commit: 6e6752a9c78738e27bde6da5cefa393b589276bb > [4/5] ASoC: tlv320aic31xx: Handle BCLK set as PLL input configuration > commit: c5d22d5e12e776fee4e346dc098fe51d00c2f983 > [5/5] ASoC: fsl-asoc-card: Support fsl,imx-audio-tlv320aic31xx codec > commit: 8c9b9cfb7724685ce705f511b882f30597596536 > > All being well this means that it will be integrated into the linux-next > tree (usually sometime in the next 24 hours) and sent to Linus during > the next merge window (or sooner if it is a bug fix), however if > problems are discovered then the patch may be dropped or reverted. > > You may get further e-mails resulting from automated or manual testing > and review of the tree, please engage with people reporting problems and > send followup patches addressing any issues that are reported if needed. > > If any updates are required or you are submitting further changes they > should be sent as incremental updates against current git, existing > patches will not be replaced. Quick question: I gotta send a fix for one of the patches. So, should it be a new incremental patch or I can still send a patchset v2? Also, I sent an incremental update patchset on top of this one: [PATCH 0/4] fsl-asoc-card: Add optional dt property for setting mclk-id I could merge altogether on a patchset v2. Please let me know, and sorry the process it's not clear to me :-) Thanks, Ariel
Re: [RFC patch 0/5] Support BCLK input clock in tlv320aic31xx
On Fri, 19 Nov 2021 12:32:43 -0300, Ariel D'Alessandro wrote: > The tlv320aic31xx codec allows using BCLK as the input clock for PLL, > deriving all the frequencies through a set of divisors. > > In this case, codec sysclk is determined by the hwparams sample > rate/format. So its frequency must be updated from the codec itself when > these are changed. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/5] ASoC: tlv320aic31xx: Fix typo in BCLK clock name commit: 7016fd940adf2f4d86032339b546c6ecd737062f [2/5] ASoC: tlv320aic31xx: Add support for pll_r coefficient commit: 2664b24a8c51c21b24c2b37b7f10d6485c35b7c1 [3/5] ASoC: tlv320aic31xx: Add divs for bclk as clk_in commit: 6e6752a9c78738e27bde6da5cefa393b589276bb [4/5] ASoC: tlv320aic31xx: Handle BCLK set as PLL input configuration commit: c5d22d5e12e776fee4e346dc098fe51d00c2f983 [5/5] ASoC: fsl-asoc-card: Support fsl,imx-audio-tlv320aic31xx codec commit: 8c9b9cfb7724685ce705f511b882f30597596536 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
[RFC patch 0/5] Support BCLK input clock in tlv320aic31xx
The tlv320aic31xx codec allows using BCLK as the input clock for PLL, deriving all the frequencies through a set of divisors. In this case, codec sysclk is determined by the hwparams sample rate/format. So its frequency must be updated from the codec itself when these are changed. This patchset modifies the tlv320aic31xx driver to update its sysclk if BCLK is used as the input clock. This allows to be used by the generic fsl-asoc-card, without having to add a specific driver. Ariel D'Alessandro (5): ASoC: tlv320aic31xx: Fix typo in BCLK clock name ASoC: tlv320aic31xx: Add support for pll_r coefficient ASoC: tlv320aic31xx: Add divs for bclk as clk_in ASoC: tlv320aic31xx: Handle BCLK set as PLL input configuration ASoC: fsl-asoc-card: Support fsl,imx-audio-tlv320aic31xx codec sound/soc/codecs/tlv320aic31xx.c | 105 --- sound/soc/codecs/tlv320aic31xx.h | 2 +- sound/soc/fsl/fsl-asoc-card.c| 12 3 files changed, 83 insertions(+), 36 deletions(-) -- 2.30.2
