Re: [V2, 02/68] powerpc/mm/nohash: Return correctly from flush_tlb_page

2016-04-20 Thread Aneesh Kumar K.V 
Michael Ellerman  writes:

> On Sat, 2016-09-04 at 06:12:58 UTC, "Aneesh Kumar K.V" wrote:
>> if it is a hugetlb address return without calling __flush_tlb_page.
>
> Why?
>
> cheers

Because flush_hugetlb_page will do the necessary flush

-aneesh

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [V2, 02/68] powerpc/mm/nohash: Return correctly from flush_tlb_page

2016-04-19 Thread Michael Ellerman 
On Sat, 2016-09-04 at 06:12:58 UTC, "Aneesh Kumar K.V" wrote:
> if it is a hugetlb address return without calling __flush_tlb_page.
 
Why?

cheers
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH V2 02/68] powerpc/mm/nohash: Return correctly from flush_tlb_page

2016-04-09 Thread Aneesh Kumar K.V 
if it is a hugetlb address return without calling __flush_tlb_page.

Cc: Scott Wood 
Signed-off-by: Aneesh Kumar K.V 
---
 arch/powerpc/mm/tlb_nohash.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/powerpc/mm/tlb_nohash.c b/arch/powerpc/mm/tlb_nohash.c
index f4668488512c..8ed4c037cb00 100644
--- a/arch/powerpc/mm/tlb_nohash.c
+++ b/arch/powerpc/mm/tlb_nohash.c
@@ -328,9 +328,8 @@ void flush_tlb_page(struct vm_area_struct *vma, unsigned 
long vmaddr)
 {
 #ifdef CONFIG_HUGETLB_PAGE
if (vma && is_vm_hugetlb_page(vma))
-   flush_hugetlb_page(vma, vmaddr);
+   return flush_hugetlb_page(vma, vmaddr);
 #endif
-
__flush_tlb_page(vma ? vma->vm_mm : NULL, vmaddr,
 mmu_get_tsize(mmu_virtual_psize), 0);
 }
-- 
2.5.0

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev