Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: Set default slot number for common cases
On Thu, Jan 9, 2014 at 7:41 AM, Nicolin Chen guangyu.c...@freescale.com wrote: For those platforms using DAI master mode like I2S, it's better to pre-set a default slot number so that there's no need for these common cases to set the slot number from its machine driver any more. Signed-off-by: Nicolin Chen guangyu.c...@freescale.com --- sound/soc/fsl/fsl_ssi.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 94dedcb..57ab45b 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -711,6 +711,16 @@ static int fsl_ssi_setup(struct fsl_ssi_private *ssi_private) if (ssi_private-imx_ac97) fsl_ssi_setup_ac97(ssi_private); + /* Set a default slot number so that there is no need for those common +* cases like I2S mode to call the extra set_tdm_slot() any more. +*/ Incorrect style for multi-line comment. Regards, Fabio Estevam ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: Set default slot number for common cases
Hi Fabio, On Thu, Jan 09, 2014 at 08:24:24AM -0200, Fabio Estevam wrote: On Thu, Jan 9, 2014 at 7:41 AM, Nicolin Chen guangyu.c...@freescale.com wrote: For those platforms using DAI master mode like I2S, it's better to pre-set a default slot number so that there's no need for these common cases to set the slot number from its machine driver any more. Signed-off-by: Nicolin Chen guangyu.c...@freescale.com --- sound/soc/fsl/fsl_ssi.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 94dedcb..57ab45b 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -711,6 +711,16 @@ static int fsl_ssi_setup(struct fsl_ssi_private *ssi_private) if (ssi_private-imx_ac97) fsl_ssi_setup_ac97(ssi_private); + /* Set a default slot number so that there is no need for those common +* cases like I2S mode to call the extra set_tdm_slot() any more. +*/ Incorrect style for multi-line comment. Is this for the initial line? The CodingStyle contains two types of multi-line comment, one of which drops the initial line just like mine, even though it's saying 'For files in net/ and drivers/net/ the preferred style', so I thought it shouldn't be quite bother. I don't mind to add it up though. Thank you, Nicolin ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: Set default slot number for common cases
On Thu, Jan 9, 2014 at 8:34 AM, Nicolin Chen guangyu.c...@freescale.com wrote: Is this for the initial line? The CodingStyle contains two types of multi-line Yes, correct. comment, one of which drops the initial line just like mine, even though it's saying 'For files in net/ and drivers/net/ the preferred style', so I thought it shouldn't be quite bother. Yes, net and drivers/net are different and checkpatch reports it accordingly. Regards, Fabio Estevam ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
