Re: [alsa-devel] [PATCH V4 2/5] Main rewite of the mpc5200 audio DMA code
On Mon, May 25, 2009 at 06:15:09PM -0400, Jon Smirl wrote: Rewrite the mpc5200 audio DMA code to support both I2S and AC97. Signed-off-by: Jon Smirl jonsm...@gmail.com Grant, I'm OK with that if you are? ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [alsa-devel] [PATCH V4 2/5] Main rewite of the mpc5200 audio DMA code
On Tue, May 26, 2009 at 5:01 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Mon, May 25, 2009 at 06:15:09PM -0400, Jon Smirl wrote: Rewrite the mpc5200 audio DMA code to support both I2S and AC97. Signed-off-by: Jon Smirl jonsm...@gmail.com Grant, I'm OK with that if you are? Acked-by: Grant Likely grant.lik...@secretlab.ca -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [alsa-devel] [PATCH V4 2/5] Main rewite of the mpc5200 audio DMA code
On Tue, May 26, 2009 at 12:51 PM, Grant Likely
grant.lik...@secretlab.ca wrote:
On Tue, May 26, 2009 at 5:01 AM, Mark Brown
broo...@opensource.wolfsonmicro.com wrote:
On Mon, May 25, 2009 at 06:15:09PM -0400, Jon Smirl wrote:
Rewrite the mpc5200 audio DMA code to support both I2S and AC97.
Signed-off-by: Jon Smirl jonsm...@gmail.com
Grant, I'm OK with that if you are?
Acked-by: Grant Likely grant.lik...@secretlab.ca
Put in the V5 version this one has this in the h file:
-int psc_dma_trigger(struct snd_pcm_substream *substream, int cmd,
- struct snd_soc_dai *dai);
+/* whack this after Timur's patch is merged in to
arch/powerpc/include/asm/delay.h */
+#define spin_event_timeout(condition, timeout, delay, rc) \
+{ \
+ unsigned long __loops = tb_ticks_per_usec * timeout;\
+ unsigned long __start = get_tbl(); \
+ while ((rc = (condition)) (tb_ticks_since(__start) = __loops)) \
+ if (delay) \
+ udelay(delay); \
+ else\
+ cpu_relax();\
+}
+/* whack this after Timur's patch is merged in to
arch/powerpc/include/asm/delay.h */
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
Jon Smirl
jonsm...@gmail.com
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [alsa-devel] [PATCH V4 2/5] Main rewite of the mpc5200 audio DMA code
On Tue, May 26, 2009 at 10:53 AM, Jon Smirl jonsm...@gmail.com wrote:
On Tue, May 26, 2009 at 12:51 PM, Grant Likely
grant.lik...@secretlab.ca wrote:
On Tue, May 26, 2009 at 5:01 AM, Mark Brown
broo...@opensource.wolfsonmicro.com wrote:
On Mon, May 25, 2009 at 06:15:09PM -0400, Jon Smirl wrote:
Rewrite the mpc5200 audio DMA code to support both I2S and AC97.
Signed-off-by: Jon Smirl jonsm...@gmail.com
Grant, I'm OK with that if you are?
Acked-by: Grant Likely grant.lik...@secretlab.ca
Put in the V5 version this one has this in the h file:
-int psc_dma_trigger(struct snd_pcm_substream *substream, int cmd,
- struct snd_soc_dai *dai);
+/* whack this after Timur's patch is merged in to
arch/powerpc/include/asm/delay.h */
+#define spin_event_timeout(condition, timeout, delay, rc) \
+{ \
+ unsigned long __loops = tb_ticks_per_usec * timeout; \
+ unsigned long __start = get_tbl(); \
+ while ((rc = (condition)) (tb_ticks_since(__start) = __loops)) \
+ if (delay) \
+ udelay(delay); \
+ else \
+ cpu_relax(); \
+}
+/* whack this after Timur's patch is merged in to
arch/powerpc/include/asm/delay.h */
sure, no problem if it will grease the merge.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [alsa-devel] [PATCH V4 2/5] Main rewite of the mpc5200 audio DMA code
On Tue, May 26, 2009 at 11:53 AM, Jon Smirl jonsm...@gmail.com wrote:
Put in the V5 version this one has this in the h file:
-int psc_dma_trigger(struct snd_pcm_substream *substream, int cmd,
- struct snd_soc_dai *dai);
+/* whack this after Timur's patch is merged in to
arch/powerpc/include/asm/delay.h */
+#define spin_event_timeout(condition, timeout, delay, rc) \
+{ \
+ unsigned long __loops = tb_ticks_per_usec * timeout; \
+ unsigned long __start = get_tbl(); \
+ while ((rc = (condition)) (tb_ticks_since(__start) = __loops)) \
+ if (delay) \
+ udelay(delay); \
+ else \
+ cpu_relax(); \
+}
+/* whack this after Timur's patch is merged in to
arch/powerpc/include/asm/delay.h */
It won't be that simple. V9 of my patch changes the number of
parameters, so not only will you need to whack this copy of the macro,
you'll also need to change the callers.
--
Timur Tabi
Linux kernel developer at Freescale
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [alsa-devel] [PATCH V4 2/5] Main rewite of the mpc5200 audio DMA code
On Tue, May 26, 2009 at 12:08:01PM -0500, Timur Tabi wrote: It won't be that simple. V9 of my patch changes the number of parameters, so not only will you need to whack this copy of the macro, you'll also need to change the callers. OK, in the interests of cutting down on the amount of review here I've applied v5 of the series and then marked the AC97 machine drivers as BROKEN for the time being - once everything lands in mainline we can make sure that the driver is in sync with the final spin_event_timeout() API and remove the BROKEN marking. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
