Rather than put a big script into the trap handler, have it call
a function.

Reviewed-by: Thomas Huth <th...@redhat.com>
Signed-off-by: Nicholas Piggin <npig...@gmail.com>
---
 scripts/arch-run.bash | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash
index 11d47a85c..c1dd67abe 100644
--- a/scripts/arch-run.bash
+++ b/scripts/arch-run.bash
@@ -269,10 +269,21 @@ search_qemu_binary ()
        export PATH=$save_path
 }
 
+initrd_cleanup ()
+{
+       rm -f $KVM_UNIT_TESTS_ENV
+       if [ "$KVM_UNIT_TESTS_ENV_OLD" ]; then
+               export KVM_UNIT_TESTS_ENV="$KVM_UNIT_TESTS_ENV_OLD"
+       else
+               unset KVM_UNIT_TESTS_ENV
+       fi
+       unset KVM_UNIT_TESTS_ENV_OLD
+}
+
 initrd_create ()
 {
        if [ "$ENVIRON_DEFAULT" = "yes" ]; then
-               trap_exit_push 'rm -f $KVM_UNIT_TESTS_ENV; [ 
"$KVM_UNIT_TESTS_ENV_OLD" ] && export 
KVM_UNIT_TESTS_ENV="$KVM_UNIT_TESTS_ENV_OLD" || unset KVM_UNIT_TESTS_ENV; unset 
KVM_UNIT_TESTS_ENV_OLD'
+               trap_exit_push 'initrd_cleanup'
                [ -f "$KVM_UNIT_TESTS_ENV" ] && export 
KVM_UNIT_TESTS_ENV_OLD="$KVM_UNIT_TESTS_ENV"
                export KVM_UNIT_TESTS_ENV=$(mktemp)
                env_params
-- 
2.42.0

Reply via email to