Re: [kvm-unit-tests v2 02/10] powerpc: add local variant of SPR test

2023-03-26 Thread Nicholas Piggin
On Thu Mar 23, 2023 at 9:26 PM AEST, Thomas Huth wrote:
> On 20/03/2023 08.03, Nicholas Piggin wrote:
> > This adds the non-migration variant of the SPR test to the matrix,
> > which can be simpler to run and debug.
> > 
> > Reviewed-by: Thomas Huth 
> > Signed-off-by: Nicholas Piggin 
> > ---
> >   powerpc/unittests.cfg | 4 
> >   1 file changed, 4 insertions(+)
> > 
> > diff --git a/powerpc/unittests.cfg b/powerpc/unittests.cfg
> > index 1e74948..3e41598 100644
> > --- a/powerpc/unittests.cfg
> > +++ b/powerpc/unittests.cfg
> > @@ -68,5 +68,9 @@ groups = h_cede_tm
> >   
> >   [sprs]
> >   file = sprs.elf
> > +groups = sprs
>
> Looking at this again, I think you don't really need a "groups =" entry here 
> ... I'd suggest to drop that line.

Okay, will do.

Thanks,
Nick


Re: [kvm-unit-tests v2 02/10] powerpc: add local variant of SPR test

2023-03-23 Thread Thomas Huth

On 20/03/2023 08.03, Nicholas Piggin wrote:

This adds the non-migration variant of the SPR test to the matrix,
which can be simpler to run and debug.

Reviewed-by: Thomas Huth 
Signed-off-by: Nicholas Piggin 
---
  powerpc/unittests.cfg | 4 
  1 file changed, 4 insertions(+)

diff --git a/powerpc/unittests.cfg b/powerpc/unittests.cfg
index 1e74948..3e41598 100644
--- a/powerpc/unittests.cfg
+++ b/powerpc/unittests.cfg
@@ -68,5 +68,9 @@ groups = h_cede_tm
  
  [sprs]

  file = sprs.elf
+groups = sprs


Looking at this again, I think you don't really need a "groups =" entry here 
... I'd suggest to drop that line.


 Thomas



+[sprs-migration]
+file = sprs.elf
  extra_params = -append '-w'
  groups = migration




[kvm-unit-tests v2 02/10] powerpc: add local variant of SPR test

2023-03-20 Thread Nicholas Piggin
This adds the non-migration variant of the SPR test to the matrix,
which can be simpler to run and debug.

Reviewed-by: Thomas Huth 
Signed-off-by: Nicholas Piggin 
---
 powerpc/unittests.cfg | 4 
 1 file changed, 4 insertions(+)

diff --git a/powerpc/unittests.cfg b/powerpc/unittests.cfg
index 1e74948..3e41598 100644
--- a/powerpc/unittests.cfg
+++ b/powerpc/unittests.cfg
@@ -68,5 +68,9 @@ groups = h_cede_tm
 
 [sprs]
 file = sprs.elf
+groups = sprs
+
+[sprs-migration]
+file = sprs.elf
 extra_params = -append '-w'
 groups = migration
-- 
2.37.2