[patch] powerpc: sysfs fix compiler warning

[Christian Krafft]

From: Christian Krafft [EMAIL PROTECTED]

This patch fixes the following compiler warning:
arch/powerpc/kernel/sysfs.c:385: warning: ignoring return value of
`sysfs_create_group',

Signed-off-by: Christian Krafft [EMAIL PROTECTED]

--- linux-2.6.orig/arch/powerpc/kernel/sysfs.c
+++ linux-2.6/arch/powerpc/kernel/sysfs.c
@@ -380,16 +380,25 @@ int cpu_add_sysdev_attr_group(struct att
 {
int cpu;
struct sys_device *sysdev;
+   int error = 0;
 
mutex_lock(cpu_mutex);
 
for_each_possible_cpu(cpu) {
sysdev = get_cpu_sysdev(cpu);
-   sysfs_create_group(sysdev-kobj, attrs);
+   error = sysfs_create_group(sysdev-kobj, attrs);
+
+   if (error) {
+   for_each_possible_cpu(cpu) {
+   sysdev = get_cpu_sysdev(cpu);
+   sysfs_remove_group(sysdev-kobj, attrs);
+   }
+   break;
+   }
}
 
mutex_unlock(cpu_mutex);
-   return 0;
+   return error;
 }
 EXPORT_SYMBOL_GPL(cpu_add_sysdev_attr_group);
 


-- 
Mit freundlichen Gruessen,
kind regards,

Christian Krafft
IBM Systems  Technology Group,
Linux Kernel Development
IT Specialist


Vorsitzender des Aufsichtsrats: Martin Jetter
Geschaeftsfuehrung: Herbert Kircher
Sitz der Gesellschaft:  Boeblingen
Registriergericht:  Amtsgericht Stuttgart, HRB 243294



signature.asc
Description: PGP signature
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [patch] powerpc: sysfs fix compiler warning

[Michael Buesch]

On Friday 29 June 2007 16:50:10 Christian Krafft wrote:
 From: Christian Krafft [EMAIL PROTECTED]
 
 This patch fixes the following compiler warning:
 arch/powerpc/kernel/sysfs.c:385: warning: ignoring return value of
 `sysfs_create_group',
 
 Signed-off-by: Christian Krafft [EMAIL PROTECTED]
 
 --- linux-2.6.orig/arch/powerpc/kernel/sysfs.c
 +++ linux-2.6/arch/powerpc/kernel/sysfs.c
 @@ -380,16 +380,25 @@ int cpu_add_sysdev_attr_group(struct att
  {
   int cpu;
   struct sys_device *sysdev;
 + int error = 0;
  
   mutex_lock(cpu_mutex);
  
   for_each_possible_cpu(cpu) {
   sysdev = get_cpu_sysdev(cpu);
 - sysfs_create_group(sysdev-kobj, attrs);
 + error = sysfs_create_group(sysdev-kobj, attrs);
 +
 + if (error) {
 + for_each_possible_cpu(cpu) {
 + sysdev = get_cpu_sysdev(cpu);
 + sysfs_remove_group(sysdev-kobj, attrs);

Is sysfs_remove_group() safe to call on kobjs for which
we did not call sysfs_create_group()?

 + }
 + break;
 + }
   }
  
   mutex_unlock(cpu_mutex);
 - return 0;
 + return error;
  }
  EXPORT_SYMBOL_GPL(cpu_add_sysdev_attr_group);
  
 
 



-- 
Greetings Michael.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev