Re: [patch 09/39] powerpc/pseries/msi: Use msi_domain_ops::msi_post_free()

[Jason Gunthorpe]

On Fri, Nov 11, 2022 at 02:54:28PM +0100, Thomas Gleixner wrote:
> Use the new msi_post_free() callback which is invoked after the interrupts
> have been freed to tell the hypervisor about the shutdown.
> 
> This allows to remove the exposure of __msi_domain_free_irqs().
> 
> Signed-off-by: Thomas Gleixner 
> Cc: Michael Ellerman 
> Cc: Christophe Leroy 
> Cc: linuxppc-dev@lists.ozlabs.org
> ---
>  arch/powerpc/platforms/pseries/msi.c |7 ++-
>  1 file changed, 2 insertions(+), 5 deletions(-)

Reviewed-by: Jason Gunthorpe 

Jason

[patch 09/39] powerpc/pseries/msi: Use msi_domain_ops::msi_post_free()

[Thomas Gleixner]

Use the new msi_post_free() callback which is invoked after the interrupts
have been freed to tell the hypervisor about the shutdown.

This allows to remove the exposure of __msi_domain_free_irqs().

Signed-off-by: Thomas Gleixner 
Cc: Michael Ellerman 
Cc: Christophe Leroy 
Cc: linuxppc-dev@lists.ozlabs.org
---
 arch/powerpc/platforms/pseries/msi.c |7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)

--- a/arch/powerpc/platforms/pseries/msi.c
+++ b/arch/powerpc/platforms/pseries/msi.c
@@ -447,21 +447,18 @@ static void pseries_msi_ops_msi_free(str
  * RTAS can not disable one MSI at a time. It's all or nothing. Do it
  * at the end after all IRQs have been freed.
  */
-static void pseries_msi_domain_free_irqs(struct irq_domain *domain,
-struct device *dev)
+static void pseries_msi_post_free(struct irq_domain *domain, struct device 
*dev)
 {
if (WARN_ON_ONCE(!dev_is_pci(dev)))
return;
 
-   __msi_domain_free_irqs(domain, dev);
-
rtas_disable_msi(to_pci_dev(dev));
 }
 
 static struct msi_domain_ops pseries_pci_msi_domain_ops = {
.msi_prepare= pseries_msi_ops_prepare,
.msi_free   = pseries_msi_ops_msi_free,
-   .domain_free_irqs = pseries_msi_domain_free_irqs,
+   .msi_post_free  = pseries_msi_post_free,
 };
 
 static void pseries_msi_shutdown(struct irq_data *d)