[patch 1/3] powerpc: Sky CPU: redundant or incorrect tests on unsigned

2009-11-17 Thread akpm 
From: Roel Kluin roel.kl...@gmail.com

count is unsigned and cannot be less than 0.

Signed-off-by: Roel Kluin roel.kl...@gmail.com
Acked-by: Cyrill Gorcunov gorcu...@gmail.com
Cc: Benjamin Herrenschmidt b...@kernel.crashing.org
Cc: Kumar Gala ga...@gate.crashing.org
Cc: Brian Waite wa...@skycomputers.com
Signed-off-by: Andrew Morton a...@linux-foundation.org
---

 drivers/misc/hdpuftrs/hdpu_cpustate.c |5 -
 1 file changed, 5 deletions(-)

diff -puN 
drivers/misc/hdpuftrs/hdpu_cpustate.c~powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned
 drivers/misc/hdpuftrs/hdpu_cpustate.c
--- 
a/drivers/misc/hdpuftrs/hdpu_cpustate.c~powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned
+++ a/drivers/misc/hdpuftrs/hdpu_cpustate.c
@@ -121,8 +121,6 @@ static ssize_t cpustate_read(struct file
 {
unsigned char data;
 
-   if (count  0)
-   return -EFAULT;
if (count == 0)
return 0;
 
@@ -137,9 +135,6 @@ static ssize_t cpustate_write(struct fil
 {
unsigned char data;
 
-   if (count  0)
-   return -EFAULT;
-
if (count == 0)
return 0;
 
_
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[patch 1/3] powerpc: Sky CPU: redundant or incorrect tests on unsigned

2009-08-06 Thread akpm 
From: Roel Kluin roel.kl...@gmail.com

count is unsigned and cannot be less than 0.

Signed-off-by: Roel Kluin roel.kl...@gmail.com
Cc: Cyrill Gorcunov gorcu...@gmail.com
Cc: Benjamin Herrenschmidt b...@kernel.crashing.org
Cc: Kumar Gala ga...@gate.crashing.org
Cc: Brian Waite wa...@skycomputers.com
Signed-off-by: Andrew Morton a...@linux-foundation.org
---

 drivers/misc/hdpuftrs/hdpu_cpustate.c |5 -
 1 file changed, 5 deletions(-)

diff -puN 
drivers/misc/hdpuftrs/hdpu_cpustate.c~powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned
 drivers/misc/hdpuftrs/hdpu_cpustate.c
--- 
a/drivers/misc/hdpuftrs/hdpu_cpustate.c~powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned
+++ a/drivers/misc/hdpuftrs/hdpu_cpustate.c
@@ -121,8 +121,6 @@ static ssize_t cpustate_read(struct file
 {
unsigned char data;
 
-   if (count  0)
-   return -EFAULT;
if (count == 0)
return 0;
 
@@ -137,9 +135,6 @@ static ssize_t cpustate_write(struct fil
 {
unsigned char data;
 
-   if (count  0)
-   return -EFAULT;
-
if (count == 0)
return 0;
 
_
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev