Re: [patch 11/39] genirq/irqdomain: Move bus token enum into a seperate header

[Jason Gunthorpe]

On Fri, Nov 11, 2022 at 02:54:32PM +0100, Thomas Gleixner wrote:
> Split the bus token defines out into a seperate header file to avoid
> inclusion of irqdomain.h in msi.h.
> 
> Signed-off-by: Thomas Gleixner 
> ---
>  include/linux/irqdomain.h  |   22 +-
>  include/linux/irqdomain_defs.h |   26 ++
>  2 files changed, 27 insertions(+), 21 deletions(-)

Reviewed-by: Jason Gunthorpe 

Jason

Re: [patch 11/39] genirq/irqdomain: Move bus token enum into a seperate header

[Ashok Raj]

On Fri, Nov 11, 2022 at 02:54:32PM +0100, Thomas Gleixner wrote:
> Split the bus token defines out into a seperate header file to avoid
> inclusion of irqdomain.h in msi.h.
> 
> Signed-off-by: Thomas Gleixner 
> ---
>  include/linux/irqdomain.h  |   22 +-
>  include/linux/irqdomain_defs.h |   26 ++
>  2 files changed, 27 insertions(+), 21 deletions(-)
> 


for Patches 5-11:

Reviewed-by: Ashok Raj 

[patch 11/39] genirq/irqdomain: Move bus token enum into a seperate header

[Thomas Gleixner]

Split the bus token defines out into a seperate header file to avoid
inclusion of irqdomain.h in msi.h.

Signed-off-by: Thomas Gleixner 
---
 include/linux/irqdomain.h  |   22 +-
 include/linux/irqdomain_defs.h |   26 ++
 2 files changed, 27 insertions(+), 21 deletions(-)

--- a/include/linux/irqdomain.h
+++ b/include/linux/irqdomain.h
@@ -31,6 +31,7 @@
 #define _LINUX_IRQDOMAIN_H
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -68,27 +69,6 @@ struct irq_fwspec {
 void of_phandle_args_to_fwspec(struct device_node *np, const u32 *args,
   unsigned int count, struct irq_fwspec *fwspec);
 
-/*
- * Should several domains have the same device node, but serve
- * different purposes (for example one domain is for PCI/MSI, and the
- * other for wired IRQs), they can be distinguished using a
- * bus-specific token. Most domains are expected to only carry
- * DOMAIN_BUS_ANY.
- */
-enum irq_domain_bus_token {
-   DOMAIN_BUS_ANY  = 0,
-   DOMAIN_BUS_WIRED,
-   DOMAIN_BUS_GENERIC_MSI,
-   DOMAIN_BUS_PCI_MSI,
-   DOMAIN_BUS_PLATFORM_MSI,
-   DOMAIN_BUS_NEXUS,
-   DOMAIN_BUS_IPI,
-   DOMAIN_BUS_FSL_MC_MSI,
-   DOMAIN_BUS_TI_SCI_INTA_MSI,
-   DOMAIN_BUS_WAKEUP,
-   DOMAIN_BUS_VMD_MSI,
-};
-
 /**
  * struct irq_domain_ops - Methods for irq_domain objects
  * @match: Match an interrupt controller device node to a host, returns
--- /dev/null
+++ b/include/linux/irqdomain_defs.h
@@ -0,0 +1,26 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _LINUX_IRQDOMAIN_DEFS_H
+#define _LINUX_IRQDOMAIN_DEFS_H
+
+/*
+ * Should several domains have the same device node, but serve
+ * different purposes (for example one domain is for PCI/MSI, and the
+ * other for wired IRQs), they can be distinguished using a
+ * bus-specific token. Most domains are expected to only carry
+ * DOMAIN_BUS_ANY.
+ */
+enum irq_domain_bus_token {
+   DOMAIN_BUS_ANY  = 0,
+   DOMAIN_BUS_WIRED,
+   DOMAIN_BUS_GENERIC_MSI,
+   DOMAIN_BUS_PCI_MSI,
+   DOMAIN_BUS_PLATFORM_MSI,
+   DOMAIN_BUS_NEXUS,
+   DOMAIN_BUS_IPI,
+   DOMAIN_BUS_FSL_MC_MSI,
+   DOMAIN_BUS_TI_SCI_INTA_MSI,
+   DOMAIN_BUS_WAKEUP,
+   DOMAIN_BUS_VMD_MSI,
+};
+
+#endif /* _LINUX_IRQDOMAIN_DEFS_H */